cpufreq: Convert to using %pOF instead of full_name

PATCH In review Rob Herring 3 participants 3 messages Jul 18, 2017 – Jul 19, 2017

Subsystems (3)

PowerPC CPU frequency scaling framework Arm/STI architecture

lore

Share & tools

lore

Rob Herring

author

2017-07-18 21:42 UTC #0 lore raw

PATCH 1/1 cpufreq: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>

Cc "Rafael J. Wysocki" <[email protected]>

Cc Viresh Kumar <[email protected]>

Cc Benjamin Herrenschmidt <[email protected]>

Cc Paul Mackerras <[email protected]>

Cc Michael Ellerman <[email protected]>

Cc Patrice Chotard <[email protected]>

Cc linux-pm at vger.kernel.org

Cc linuxppc-dev at lists.ozlabs.org

Cc linux-arm-kernel at lists.infradead.org

Cc kernel at stlinux.com

---
 drivers/cpufreq/pmac64-cpufreq.c | 2 +-
 drivers/cpufreq/sti-cpufreq.c    | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

drivers/cpufreq/pmac64-cpufreq.c +1 -1

index 267e0894c62d..be623dd7b9f2 100644
@@ -516,7 +516,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpunode)
 		goto bail;
 	}
 
-	DBG("cpufreq: i2c clock chip found: %s\n", hwclock->full_name);
+	DBG("cpufreq: i2c clock chip found: %pOF\n", hwclock);
 
 	/* Now get all the platform functions */
 	pfunc_cpu_getfreq =

drivers/cpufreq/sti-cpufreq.c +4 -4

index d2d0430d09d4..47105735df12 100644
@@ -65,8 +65,8 @@ static int sti_cpufreq_fetch_major(void) {
 	ret = of_property_read_u32_index(np, "st,syscfg",
 					 MAJOR_ID_INDEX, &major_offset);
 	if (ret) {
-		dev_err(dev, "No major number offset provided in %s [%d]\n",
-			np->full_name, ret);
+		dev_err(dev, "No major number offset provided in %pOF [%d]\n",
+			np, ret);
 		return ret;
 	}

@@ -92,8 +92,8 @@ static int sti_cpufreq_fetch_minor(void)
 					 MINOR_ID_INDEX, &minor_offset);
 	if (ret) {
 		dev_err(dev,
-			"No minor number offset provided %s [%d]\n",
-			np->full_name, ret);
+			"No minor number offset provided %pOF [%d]\n",
+			np, ret);
 		return ret;
 	}

--
2.11.0

Viresh Kumar

maintainer Acked-by on v1 1/1

2017-07-19 06:38 UTC #1 lore raw

Quoted 49 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.
Signed-off-by Rob Herring <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc linux-pm at vger.kernel.org
Cc linuxppc-dev at lists.ozlabs.org
Cc linux-arm-kernel at lists.infradead.org
Cc kernel at stlinux.com
---
 drivers/cpufreq/pmac64-cpufreq.c | 2 +-
 drivers/cpufreq/sti-cpufreq.c    | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/cpufreq/pmac64-cpufreq.c +1 -1
index 267e0894c62d..be623dd7b9f2 100644
@@ -516,7 +516,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpunode)
 		goto bail;
 	}
 
-	DBG("cpufreq: i2c clock chip found: %s\n", hwclock->full_name);
+	DBG("cpufreq: i2c clock chip found: %pOF\n", hwclock);
 
 	/* Now get all the platform functions */
 	pfunc_cpu_getfreq =
drivers/cpufreq/sti-cpufreq.c +2 -2
index d2d0430d09d4..47105735df12 100644
@@ -65,8 +65,8 @@ static int sti_cpufreq_fetch_major(void) {
 	ret = of_property_read_u32_index(np, "st,syscfg",
 					 MAJOR_ID_INDEX, &major_offset);
 	if (ret) {
-		dev_err(dev, "No major number offset provided in %s [%d]\n",
-			np->full_name, ret);
+		dev_err(dev, "No major number offset provided in %pOF [%d]\n",
+			np, ret);
 		return ret;
 	}
 

drivers/cpufreq/sti-cpufreq.c static int sti_cpufreq_fetch_minor(void) · line 98

Quoted 9 lines

drivers/cpufreq/sti-cpufreq.c +2 -2

@@ -92,8 +92,8 @@ static int sti_cpufreq_fetch_minor(void)
 					 MINOR_ID_INDEX, &minor_offset);
 	if (ret) {
 		dev_err(dev,
-			"No minor number offset provided %s [%d]\n",
-			np->full_name, ret);
+			"No minor number offset provided %pOF [%d]\n",
+			np, ret);
 		return ret;
 	}

Acked-by Viresh Kumar <[email protected]>

Signature · 1 line

viresh

Patrice CHOTARD

Acked-by on v1 1/1

2017-07-19 07:06 UTC #2 lore raw

In reply to Rob Herring

Quoted 60 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.
Signed-off-by Rob Herring <[email protected]>
Cc "Rafael J. Wysocki" <[email protected]>
Cc Viresh Kumar <[email protected]>
Cc Benjamin Herrenschmidt <[email protected]>
Cc Paul Mackerras <[email protected]>
Cc Michael Ellerman <[email protected]>
Cc Patrice Chotard <[email protected]>
Cc linux-pm at vger.kernel.org
Cc linuxppc-dev at lists.ozlabs.org
Cc linux-arm-kernel at lists.infradead.org
Cc kernel at stlinux.com
---
  drivers/cpufreq/pmac64-cpufreq.c | 2 +-
  drivers/cpufreq/sti-cpufreq.c    | 8 ++++----
  2 files changed, 5 insertions(+), 5 deletions(-)
drivers/cpufreq/pmac64-cpufreq.c +1 -1
index 267e0894c62d..be623dd7b9f2 100644
@@ -516,7 +516,7 @@ static int __init g5_pm72_cpufreq_init(struct device_node *cpunode)
  		goto bail;
  	}
 
-	DBG("cpufreq: i2c clock chip found: %s\n", hwclock->full_name);
+	DBG("cpufreq: i2c clock chip found: %pOF\n", hwclock);
 
  	/* Now get all the platform functions */
  	pfunc_cpu_getfreq =
drivers/cpufreq/sti-cpufreq.c +4 -5
index d2d0430d09d4..47105735df12 100644
@@ -65,8 +65,8 @@ static int sti_cpufreq_fetch_major(void) {
  	ret = of_property_read_u32_index(np, "st,syscfg",
  					 MAJOR_ID_INDEX, &major_offset);
  	if (ret) {
-		dev_err(dev, "No major number offset provided in %s [%d]\n",
-			np->full_name, ret);
+		dev_err(dev, "No major number offset provided in %pOF [%d]\n",
+			np, ret);
  		return ret;
  	}
 
@@ -92,8 +92,8 @@ static int sti_cpufreq_fetch_minor(void)
  					 MINOR_ID_INDEX, &minor_offset);
  	if (ret) {
  		dev_err(dev,
-			"No minor number offset provided %s [%d]\n",
-			np->full_name, ret);
+			"No minor number offset provided %pOF [%d]\n",
+			np, ret);
  		return ret;
  	}
 
--

Quoted 2 lines

2.11.0

For ST cpufreq:

Acked-by Patrice Chotard <[email protected]>

Thanks