Skip to contentSkip to conversation

cpuidle: Convert to using %pOF instead of full_name

PATCH In review Rob Herring 3 participants 5 messages Jul 18, 2017 – Aug 23, 2017 CPU idle time management framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cpuidle: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Cc "Rafael J. Wysocki" <[email protected]>
Cc Daniel Lezcano <[email protected]>
---
 drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
drivers/cpuidle/dt_idle_states.c +10 -10
index ae8eb0359889..bafd4dbf55d4 100644
@@ -53,16 +53,16 @@ static int init_state_node(struct cpuidle_state *idle_state,
 		err = of_property_read_u32(state_node, "entry-latency-us",
 					   &entry_latency);
 		if (err) {
-			pr_debug(" * %s missing entry-latency-us property\n",
-				 state_node->full_name);
+			pr_debug(" * %pOF missing entry-latency-us property\n",
+				 state_node);
 			return -EINVAL;
 		}
 
 		err = of_property_read_u32(state_node, "exit-latency-us",
 					   &exit_latency);
 		if (err) {
-			pr_debug(" * %s missing exit-latency-us property\n",
-				 state_node->full_name);
+			pr_debug(" * %pOF missing exit-latency-us property\n",
+				 state_node);
 			return -EINVAL;
 		}
 		/*
@@ -75,8 +75,8 @@ static int init_state_node(struct cpuidle_state *idle_state,
 	err = of_property_read_u32(state_node, "min-residency-us",
 				   &idle_state->target_residency);
 	if (err) {
-		pr_debug(" * %s missing min-residency-us property\n",
-			     state_node->full_name);
+		pr_debug(" * %pOF missing min-residency-us property\n",
+			     state_node);
 		return -EINVAL;
 	}
 
@@ -186,8 +186,8 @@ int dt_init_idle_driver(struct cpuidle_driver *drv,
 		}
 
 		if (!idle_state_valid(state_node, i, cpumask)) {
-			pr_warn("%s idle state not valid, bailing out\n",
-				state_node->full_name);
+			pr_warn("%pOF idle state not valid, bailing out\n",
+				state_node);
 			err = -EINVAL;
 			break;
 		}
@@ -200,8 +200,8 @@ int dt_init_idle_driver(struct cpuidle_driver *drv,
 		idle_state = &drv->states[state_idx++];
 		err = init_state_node(idle_state, matches, state_node);
 		if (err) {
-			pr_err("Parsing idle state node %s failed with err %d\n",
-			       state_node->full_name, err);
+			pr_err("Parsing idle state node %pOF failed with err %d\n",
+			       state_node, err);
 			err = -EINVAL;
 			break;
 		}

--
2.11.0

#1 lore raw
Quoted 11 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Cc "Rafael J. Wysocki" <[email protected]>
Cc Daniel Lezcano <[email protected]>
---
 drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Rafael, Ping. Please apply this one and 2 others for cpufreq and PM-domains which haven't been applied yet.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
Quoted 13 lines · Rob Herring
Quoted 11 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Cc "Rafael J. Wysocki" <[email protected]>
Cc Daniel Lezcano <[email protected]>
---
 drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
Quoted 2 lines

Rafael, Ping. Please apply this one and 2 others for cpufreq and PM-domains which haven't been applied yet.

I thought that these would go in through the DT tree.

I'll try to find them, but next time please make it clear how you want to route things.

Thanks,
Rafael

#3 lore raw
Quoted 14 lines · Rafael J. Wysocki
Quoted 13 lines · Rob Herring
Quoted 11 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Cc "Rafael J. Wysocki" <[email protected]>
Cc Daniel Lezcano <[email protected]>
---
 drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)
Quoted 7 lines
Quoted 2 lines

Rafael, Ping. Please apply this one and 2 others for cpufreq and PM-domains which haven't been applied yet.

I thought that these would go in through the DT tree.

I'll try to find them, but next time please make it clear how you want to route things.

Sorry, I thought addressed TO you and not in a series was enough to imply that.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 18 lines · CEST Rob Herring
Quoted 17 lines · Rafael J. Wysocki
Quoted 15 lines · Rob Herring
Quoted 11 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Cc "Rafael J. Wysocki" <[email protected]>
Cc Daniel Lezcano <[email protected]>
---
 drivers/cpuidle/dt_idle_states.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

Rafael, Ping. Please apply this one and 2 others for cpufreq and PM-domains which haven't been applied yet.

Quoted 6 lines
Quoted 4 lines

I thought that these would go in through the DT tree.

I'll try to find them, but next time please make it clear how you want to route things.

Sorry, I thought addressed TO you and not in a series was enough to imply that.

Well, Patchwork doesn't tell me who the patch was addressed to. :-)

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html