Skip to contentSkip to conversation

EDAC: Convert to using %pOF instead of full_name

PATCH Applied Rob Herring 2 participants 2 messages Jul 18, 2017 – Jul 19, 2017 EDAC-core

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 EDAC: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Cc Borislav Petkov <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
---
 drivers/edac/cpc925_edac.c | 2 +-
 drivers/edac/ppc4xx_edac.c | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)
drivers/edac/cpc925_edac.c +1 -1
index 837b62c4993d..afd29a5a51c3 100644
@@ -618,7 +618,7 @@ static u32 cpc925_cpu_mask_disabled(void)
 		}
 
 		if (reg == NULL || *reg > 2) {
-			cpc925_printk(KERN_ERR, "Bad reg value at %s\n", cpunode->full_name);
+			cpc925_printk(KERN_ERR, "Bad reg value at %pOF\n", cpunode);
 			continue;
 		}
 
drivers/edac/ppc4xx_edac.c +4 -4
index e55e92590106..8807f427dd69 100644
@@ -1267,8 +1267,8 @@ static int ppc4xx_edac_probe(struct platform_device *op)
 	memcheck = (mcopt1 & SDRAM_MCOPT1_MCHK_MASK);
 
 	if (memcheck == SDRAM_MCOPT1_MCHK_NON) {
-		ppc4xx_edac_printk(KERN_INFO, "%s: No ECC memory detected or "
-				   "ECC is disabled.\n", np->full_name);
+		ppc4xx_edac_printk(KERN_INFO, "%pOF: No ECC memory detected or "
+				   "ECC is disabled.\n", np);
 		status = -ENODEV;
 		goto done;
 	}
@@ -1287,9 +1287,9 @@ static int ppc4xx_edac_probe(struct platform_device *op)
 	mci = edac_mc_alloc(ppc4xx_edac_instance, ARRAY_SIZE(layers), layers,
 			    sizeof(struct ppc4xx_edac_pdata));
 	if (mci == NULL) {
-		ppc4xx_edac_printk(KERN_ERR, "%s: "
+		ppc4xx_edac_printk(KERN_ERR, "%pOF: "
 				   "Failed to allocate EDAC MC instance!\n",
-				   np->full_name);
+				   np);
 		status = -ENOMEM;
 		goto done;
 	}

--
2.11.0

maintainer Applied
#1 lore raw
Quoted 4 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Quoted 8 lines
Cc Borislav Petkov <[email protected]>
Cc Mauro Carvalho Chehab <[email protected]>
---
 drivers/edac/cpc925_edac.c | 2 +-
 drivers/edac/ppc4xx_edac.c | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

Applied, thanks.

Signature · 5 lines
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--