Skip to contentSkip to conversation

firmware: Convert to using %pOF instead of full_name

PATCH Applied Rob Herring 3 participants 3 messages Jul 18, 2017 – Aug 16, 2017 System control & power/management interface (SCPI/SCMI) Message Protocol drivers

lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 firmware: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Sudeep Holla <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
---
 drivers/firmware/arm_scpi.c | 2 +-
 drivers/firmware/psci.c     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/firmware/arm_scpi.c +1 -1
index 8043e51de897..59190c374696 100644
@@ -965,7 +965,7 @@ static int scpi_probe(struct platform_device *pdev)
 
 	count = of_count_phandle_with_args(np, "mboxes", "#mbox-cells");
 	if (count < 0) {
-		dev_err(dev, "no mboxes property in '%s'\n", np->full_name);
+		dev_err(dev, "no mboxes property in '%pOF'\n", np);
 		return -ENODEV;
 	}
drivers/firmware/psci.c +2 -2
index 493a56a4cfc4..d687ca3d5049 100644
@@ -280,8 +280,8 @@ static int psci_dt_cpu_init_idle(struct device_node *cpu_node, int cpu)
 					   "arm,psci-suspend-param",
 					   &state);
 		if (ret) {
-			pr_warn(" * %s missing arm,psci-suspend-param property\n",
-				state_node->full_name);
+			pr_warn(" * %pOF missing arm,psci-suspend-param property\n",
+				state_node);
 			of_node_put(state_node);
 			goto free_mem;
 		}

--
2.11.0

Acked-by on v1 1/1
#1 lore raw
Quoted 19 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Sudeep Holla <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
Cc linux-arm-kernel at lists.infradead.org
---
 drivers/firmware/arm_scpi.c | 2 +-
 drivers/firmware/psci.c     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/firmware/arm_scpi.c +0 -0
index 8043e51de897..59190c374696 100644

drivers/firmware/arm_scpi.c static int scpi_probe(struct platform_device *pdev) · line 971

Quoted 8 lines
drivers/firmware/arm_scpi.c +1 -1
@@ -965,7 +965,7 @@ static int scpi_probe(struct platform_device *pdev)
 
 	count = of_count_phandle_with_args(np, "mboxes", "#mbox-cells");
 	if (count < 0) {
-		dev_err(dev, "no mboxes property in '%s'\n", np->full_name);
+		dev_err(dev, "no mboxes property in '%pOF'\n", np);
 		return -ENODEV;
 	}

(For the SCPI part)

Acked-by Sudeep Holla <[email protected]>

I assume you will ask ARM-SoC guys to pick this up. Let us know if you think otherwise.

Signature · 2 lines
Regards,
Sudeep
Applied
#2 lore raw
In reply to Rob Herring
Quoted 9 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Sudeep Holla <[email protected]>
Cc Mark Rutland <[email protected]>
Cc Lorenzo Pieralisi <[email protected]>
Cc linux-arm-kernel at lists.infradead.org

Applied to next/drivers with Sudeep's ack, thanks.

Arnd