Skip to contentSkip to conversation

fpga: Convert to using %pOF instead of full_name

PATCH In review Rob Herring 3 participants 5 messages Jul 18, 2017 – Aug 10, 2017 FPGA manager framework

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fpga: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

---
 drivers/fpga/fpga-region.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fpga/fpga-region.c +2 -2
index 3b6b2f4182a1..d9ab7c75b14f 100644
@@ -319,8 +319,8 @@ static int child_regions_with_firmware(struct device_node *overlay)
 	of_node_put(child_region);
 
 	if (ret)
-		pr_err("firmware-name not allowed in child FPGA region: %s",
-		       child_region->full_name);
+		pr_err("firmware-name not allowed in child FPGA region: %pOF",
+		       child_region);
 
 	return ret;
 }

--
2.11.0

maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Quoted 22 lines
---
 drivers/fpga/fpga-region.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fpga/fpga-region.c +2 -3
index 3b6b2f4182a1..d9ab7c75b14f 100644
@@ -319,8 +319,8 @@ static int child_regions_with_firmware(struct device_node *overlay)
 	of_node_put(child_region);
 
 	if (ret)
-		pr_err("firmware-name not allowed in child FPGA region: %s",
-		       child_region->full_name);
+		pr_err("firmware-name not allowed in child FPGA region: %pOF",
+		       child_region);
 
 	return ret;
 }
--

2.11.0

Acked-by
#2 lore raw
Quoted 10 lines · Moritz Fischer
Quoted 8 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Quoted 22 lines
Quoted 22 lines
---
 drivers/fpga/fpga-region.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/fpga/fpga-region.c +2 -3
index 3b6b2f4182a1..d9ab7c75b14f 100644
@@ -319,8 +319,8 @@ static int child_regions_with_firmware(struct device_node *overlay)
      of_node_put(child_region);
 
      if (ret)
-             pr_err("firmware-name not allowed in child FPGA region: %s",
-                    child_region->full_name);
+             pr_err("firmware-name not allowed in child FPGA region: %pOF",
+                    child_region);
 
      return ret;
 }
--

2.11.0

#3 lore raw
Quoted 6 lines · Alan Tull
Quoted 5 lines · Moritz Fischer
Quoted 4 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Quoted 7 lines
Quoted 5 lines
Quoted 4 lines

This hasn't been applied in -next. Are you going to send to Greg?

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw

I sent it on 8/2/2017. I probably missed a window.

Alan

Quoted 11 lines · Rob Herring
Quoted 10 lines · Alan Tull
Quoted 9 lines · Moritz Fischer
Quoted 8 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line

This hasn't been applied in -next. Are you going to send to Greg?

Rob

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html