Skip to contentSkip to conversation

misc: Convert to using %pOF instead of full_name

PATCH In review Rob Herring 2 participants 3 messages Jul 18, 2017 – Aug 9, 2017 Char and misc drivers

lore
Share & tools
lore

Rob Herring

author
#0 lore raw

PATCH 1/1 misc: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
---
 drivers/misc/eeprom/idt_89hpesx.c |  8 ++++----
 drivers/misc/sram.c               | 12 ++++++------
 2 files changed, 10 insertions(+), 10 deletions(-)
drivers/misc/eeprom/idt_89hpesx.c +4 -4
index ab0df6a17690..37312b548a03 100644
@@ -1132,8 +1132,8 @@ static void idt_get_ofdata(struct idt_89hpesx_dev *pdev)
 		for_each_available_child_of_node(node, child) {
 			ee_id = idt_ee_match_id(child);
 			if (IS_ERR_OR_NULL(ee_id)) {
-				dev_warn(dev, "Skip unsupported child node %s",
-					child->full_name);
+				dev_warn(dev, "Skip unsupported child node %pOF",
+					child);
 				continue;
 			} else
 				break;

@@ -1151,8 +1151,8 @@ static void idt_get_ofdata(struct idt_89hpesx_dev *pdev)
 		/* Get custom EEPROM address from 'reg' attribute */
 		addr_be = of_get_property(child, "reg", &len);
 		if (!addr_be || (len < sizeof(*addr_be))) {
-			dev_warn(dev, "No reg on %s, use default address %d",
-				child->full_name, EEPROM_DEF_ADDR);
+			dev_warn(dev, "No reg on %pOF, use default address %d",
+				child, EEPROM_DEF_ADDR);
 			pdev->inieecmd = 0;
 			pdev->eeaddr = EEPROM_DEF_ADDR << 1;
 		} else {
drivers/misc/sram.c +6 -6
index d1185b78cf9a..fc0415771c00 100644
@@ -196,15 +196,15 @@ static int sram_reserve_regions(struct sram_dev *sram, struct resource *res)
 		ret = of_address_to_resource(child, 0, &child_res);
 		if (ret < 0) {
 			dev_err(sram->dev,
-				"could not get address for node %s\n",
-				child->full_name);
+				"could not get address for node %pOF\n",
+				child);
 			goto err_chunks;
 		}
 
 		if (child_res.start < res->start || child_res.end > res->end) {
 			dev_err(sram->dev,
-				"reserved block %s outside the sram area\n",
-				child->full_name);
+				"reserved block %pOF outside the sram area\n",
+				child);
 			ret = -EINVAL;
 			goto err_chunks;
 		}

@@ -230,8 +230,8 @@ static int sram_reserve_regions(struct sram_dev *sram, struct resource *res)
 			ret = of_property_read_string(child, "label", &label);
 			if (ret && ret != -EINVAL) {
 				dev_err(sram->dev,
-					"%s has invalid label name\n",
-					child->full_name);
+					"%pOF has invalid label name\n",
+					child);
 				goto err_chunks;
 			}
 			if (!label)

--
2.11.0

author
#1 lore raw
Quoted 7 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>

Greg, ping. You picked up most of the the other patches, but not this one.

Quoted 4 lines
---
 drivers/misc/eeprom/idt_89hpesx.c |  8 ++++----
 drivers/misc/sram.c               | 12 ++++++------
 2 files changed, 10 insertions(+), 10 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#2 lore raw
Quoted 10 lines · Rob Herring
Quoted 7 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>
Cc Arnd Bergmann <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>

Greg, ping. You picked up most of the the other patches, but not this one.

My queue is still really long, due to travel and a semi-vacation. They are not lost, will get picked up "soon"...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html