Skip to contentSkip to conversation

spmi: Convert to using %pOF instead of full_name

PATCH In review Rob Herring 2 participants 3 messages Jul 18, 2017 – Aug 9, 2017 SPMI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 spmi: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

---
 drivers/spmi/spmi.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
drivers/spmi/spmi.c +6 -8
index 2b9b0941d9eb..c14b4201210c 100644
@@ -454,27 +454,25 @@ static void of_spmi_register_devices(struct spmi_controller *ctrl)
 		struct spmi_device *sdev;
 		u32 reg[2];
 
-		dev_dbg(&ctrl->dev, "adding child %s\n", node->full_name);
+		dev_dbg(&ctrl->dev, "adding child %pOF\n", node);
 
 		err = of_property_read_u32_array(node, "reg", reg, 2);
 		if (err) {
 			dev_err(&ctrl->dev,
-				"node %s err (%d) does not have 'reg' property\n",
-				node->full_name, err);
+				"node %pOF err (%d) does not have 'reg' property\n",
+				node, err);
 			continue;
 		}
 
 		if (reg[1] != SPMI_USID) {
 			dev_err(&ctrl->dev,
-				"node %s contains unsupported 'reg' entry\n",
-				node->full_name);
+				"node %pOF contains unsupported 'reg' entry\n",
+				node);
 			continue;
 		}
 
 		if (reg[0] >= SPMI_MAX_SLAVE_ID) {
-			dev_err(&ctrl->dev,
-				"invalid usid on node %s\n",
-				node->full_name);
+			dev_err(&ctrl->dev, "invalid usid on node %pOF\n", node);
 			continue;
 		}
 

--
2.11.0

#1 lore raw

+Stephen

Quoted 8 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

---
 drivers/spmi/spmi.c | 14 ++++++--------

1 file chqanged, 6 insertions(+), 8 deletions(-)

Looks like I missed Stephen recently being added as maintainer. Do you need me to resend this?

Rob

Reviewed-by
#2 lore raw
Quoted 7 lines · Rob Herring

+Stephen

Quoted 4 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Quoted 7 lines
Quoted 4 lines
---
 drivers/spmi/spmi.c | 14 ++++++--------

1 file chqanged, 6 insertions(+), 8 deletions(-)

Looks like I missed Stephen recently being added as maintainer. Do you need me to resend this?

Greg is still applying the patches, unless he doesn't want to do it. I'm just "R" for reviewer.

Signature · 7 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html