usb: Convert to using %pOF instead of full_name
Subsystems (2)
PATCH 1/1 usb: Convert to using %pOF instead of full_name
Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.
Signed-off-by Rob Herring <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
Cc Felipe Balbi <[email protected]>
--- drivers/usb/common/common.c | 4 ++-- drivers/usb/core/ledtrig-usbport.c | 4 ++-- drivers/usb/core/sysfs.c | 2 +- drivers/usb/host/fsl-mph-dr-of.c | 4 ++-- drivers/usb/mtu3/mtu3_host.c | 4 ++-- drivers/usb/phy/phy.c | 4 ++-- 6 files changed, 11 insertions(+), 11 deletions(-)
drivers/usb/common/common.c +2 -2
@@ -227,8 +227,8 @@ int of_usb_update_otg_caps(struct device_node *np, otg_caps->otg_rev = otg_rev;break ;default : -pr_err ("%s: unsupported otg-rev: 0x%x\n" , - np->full_name, otg_rev); +pr_err ("%pOF: unsupported otg-rev: 0x%x\n" , + np, otg_rev);return -EINVAL ; } }else {
drivers/usb/core/ledtrig-usbport.c +2 -2
@@ -149,8 +149,8 @@ static bool usbport_trig_port_observed(struct usbport_trig_data *usbport_data, count =of_count_phandle_with_args (led_np,"trigger-sources" ,"#trigger-source-cells" );if (count <0 ) { -dev_warn (dev,"Failed to get trigger sources for %s\n" , - led_np->full_name); +dev_warn (dev,"Failed to get trigger sources for %pOF\n" , + led_np);return false; }
drivers/usb/core/sysfs.c +1 -1
@@ -113,7 +113,7 @@ static ssize_t devspec_show(struct device *dev, struct device_attribute *attr, {struct device_node *of_node = dev->of_node; -return sprintf (buf,"%s\n" ,of_node_full_name (of_node)); +return sprintf (buf,"%pOF\n" , of_node); }static DEVICE_ATTR_RO (devspec);#endif
drivers/usb/host/fsl-mph-dr-of.c +2 -2
@@ -55,8 +55,8 @@ static struct fsl_usb2_dev_data *get_dr_mode_data(struct device_node *np)return &dr_mode_data[i]; } } -pr_warn ("%s: Invalid 'dr_mode' property, fallback to host mode\n" , - np->full_name); +pr_warn ("%pOF: Invalid 'dr_mode' property, fallback to host mode\n" , + np);return &dr_mode_data[0 ];/* mode not specified, use host */ }
drivers/usb/mtu3/mtu3_host.c +2 -2
@@ -258,8 +258,8 @@ int ssusb_host_init(struct ssusb_mtk *ssusb, struct device_node *parent_dn) ret =of_platform_populate (parent_dn,NULL ,NULL , parent_dev);if (ret) { -dev_dbg (parent_dev,"failed to create child devices at %s\n" , - parent_dn->full_name); +dev_dbg (parent_dev,"failed to create child devices at %pOF\n" , + parent_dn);return ret; }
drivers/usb/phy/phy.c +2 -2
@@ -302,8 +302,8 @@ struct usb_phy *devm_usb_get_phy_by_phandle(struct device *dev, node =of_parse_phandle (dev->of_node, phandle, index);if (!node) { -dev_dbg (dev,"failed to get %s phandle in %s node\n" , phandle, - dev->of_node->full_name); +dev_dbg (dev,"failed to get %s phandle in %pOF node\n" , phandle, + dev->of_node);return ERR_PTR (-ENODEV ); } phy =devm_usb_get_phy_by_node (dev, node,NULL );
--
2.11.0
Hi,
Quoted 8 lines · Rob Herring
Now that we have a custom printf format specifier, convert users of
full_nameto use %pOF instead. This is preparation to remove storing of the full path string for each node.Signed-off-by Rob Herring <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Felipe Balbi <[email protected]>
is this going through your tree?
Acked-by Felipe Balbi <[email protected]>
Signature · 1 line
balbi
Quoted 8 lines · Felipe Balbi
Hi,
Quoted 4 lines · Rob Herring
Now that we have a custom printf format specifier, convert users of
full_nameto use %pOF instead. This is preparation to remove storing of the full path string for each node.
Quoted 6 lines
Quoted 4 lines
Signed-off-by Rob Herring <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Felipe Balbi <[email protected]>is this going through your tree?
No, please apply.
Quoted 5 lines
Acked-by Felipe Balbi <[email protected]>--
balbi