video: fbdev: Convert to using %pOF instead of full_name

PATCH In review Rob Herring 2 participants 4 messages Jul 18, 2017 – Aug 7, 2017

Subsystems (2)

Framebuffer layer Framebuffer core

lore

Share & tools

lore

Rob Herring

author

2017-07-18 21:43 UTC #0 lore raw

PATCH 1/1 video: fbdev: Convert to using %pOF instead of full_name

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Signed-off-by Rob Herring <[email protected]>

Cc Bartlomiej Zolnierkiewicz <[email protected]>

Cc [email protected]

---
 drivers/video/fbdev/bw2.c         |  4 ++--
 drivers/video/fbdev/cg14.c        |  4 ++--
 drivers/video/fbdev/cg3.c         |  4 ++--
 drivers/video/fbdev/cg6.c         |  4 ++--
 drivers/video/fbdev/core/fbmon.c  |  4 ++--
 drivers/video/fbdev/ffb.c         |  4 ++--
 drivers/video/fbdev/leo.c         |  4 ++--
 drivers/video/fbdev/offb.c        | 10 ++++------
 drivers/video/fbdev/p9100.c       |  4 ++--
 drivers/video/fbdev/sunxvr1000.c  | 10 +++++-----
 drivers/video/fbdev/tcx.c         |  4 ++--
 drivers/video/of_display_timing.c | 41 +++++++++++++++------------------------
 drivers/video/of_videomode.c      |  2 +-
 13 files changed, 44 insertions(+), 55 deletions(-)

drivers/video/fbdev/bw2.c +2 -2

index 8c5b281f0b29..7aa972072357 100644
@@ -333,8 +333,8 @@ static int bw2_probe(struct platform_device *op)
 
 	dev_set_drvdata(&op->dev, info);
 
-	printk(KERN_INFO "%s: bwtwo at %lx:%lx\n",
-	       dp->full_name, par->which_io, info->fix.smem_start);
+	printk(KERN_INFO "%pOF: bwtwo at %lx:%lx\n",
+	       dp, par->which_io, info->fix.smem_start);
 
 	return 0;

drivers/video/fbdev/cg14.c +2 -2

index 43e915eaf606..8de88b129b62 100644
@@ -553,8 +553,8 @@ static int cg14_probe(struct platform_device *op)
 
 	dev_set_drvdata(&op->dev, info);
 
-	printk(KERN_INFO "%s: cgfourteen at %lx:%lx, %dMB\n",
-	       dp->full_name,
+	printk(KERN_INFO "%pOF: cgfourteen at %lx:%lx, %dMB\n",
+	       dp,
 	       par->iospace, info->fix.smem_start,
 	       par->ramsize >> 20);

drivers/video/fbdev/cg3.c +2 -2

index 716391f22e75..6c334260cf53 100644
@@ -412,8 +412,8 @@ static int cg3_probe(struct platform_device *op)
 
 	dev_set_drvdata(&op->dev, info);
 
-	printk(KERN_INFO "%s: cg3 at %lx:%lx\n",
-	       dp->full_name, par->which_io, info->fix.smem_start);
+	printk(KERN_INFO "%pOF: cg3 at %lx:%lx\n",
+	       dp, par->which_io, info->fix.smem_start);
 
 	return 0;

drivers/video/fbdev/cg6.c +2 -2

index bdf901ed5291..0296c21acc78 100644
@@ -810,8 +810,8 @@ static int cg6_probe(struct platform_device *op)
 
 	dev_set_drvdata(&op->dev, info);
 
-	printk(KERN_INFO "%s: CGsix [%s] at %lx:%lx\n",
-	       dp->full_name, info->fix.id,
+	printk(KERN_INFO "%pOF: CGsix [%s] at %lx:%lx\n",
+	       dp, info->fix.id,
 	       par->which_io, info->fix.smem_start);
 
 	return 0;

drivers/video/fbdev/core/fbmon.c +2 -2

index 41d7979d81c5..2b2d67328514 100644
@@ -1479,8 +1479,8 @@ int of_get_fb_videomode(struct device_node *np, struct fb_videomode *fb,
 	if (ret)
 		return ret;
 
-	pr_debug("%s: got %dx%d display mode from %s\n",
-		of_node_full_name(np), vm.hactive, vm.vactive, np->name);
+	pr_debug("%pOF: got %dx%d display mode from %s\n",
+		np, vm.hactive, vm.vactive, np->name);
 	dump_fb_videomode(fb);
 
 	return 0;

drivers/video/fbdev/ffb.c +2 -2

index dda31e0a45af..6b1915872af1 100644
@@ -997,9 +997,9 @@ static int ffb_probe(struct platform_device *op)
 
 	dev_set_drvdata(&op->dev, info);
 
-	printk(KERN_INFO "%s: %s at %016lx, type %d, "
+	printk(KERN_INFO "%pOF: %s at %016lx, type %d, "
 	       "DAC pnum[%x] rev[%d] manuf_rev[%d]\n",
-	       dp->full_name,
+	       dp,
 	       ((par->flags & FFB_FLAG_AFB) ? "AFB" : "FFB"),
 	       par->physbase, par->board_type,
 	       dac_pnum, dac_rev, dac_mrev);

drivers/video/fbdev/leo.c +2 -2

index 62e59dc90ee6..71862188f528 100644
@@ -619,8 +619,8 @@ static int leo_probe(struct platform_device *op)
 
 	dev_set_drvdata(&op->dev, info);
 
-	printk(KERN_INFO "%s: leo at %lx:%lx\n",
-	       dp->full_name,
+	printk(KERN_INFO "%pOF: leo at %lx:%lx\n",
+	       dp,
 	       par->which_io, info->fix.smem_start);
 
 	return 0;

drivers/video/fbdev/offb.c +4 -6

index 9be884b0c778..90d38de34479 100644
@@ -383,7 +383,7 @@ static void offb_init_palette_hacks(struct fb_info *info, struct device_node *dp
 		FB_VISUAL_PSEUDOCOLOR : FB_VISUAL_STATIC_PSEUDOCOLOR;
 }
 
-static void __init offb_init_fb(const char *name, const char *full_name,
+static void __init offb_init_fb(const char *name,
 				int width, int height, int depth,
 				int pitch, unsigned long address,
 				int foreign_endian, struct device_node *dp)

@@ -402,14 +402,13 @@ static void __init offb_init_fb(const char *name, const char *full_name,
 	       "Using unsupported %dx%d %s at %lx, depth=%d, pitch=%d\n",
 	       width, height, name, address, depth, pitch);
 	if (depth != 8 && depth != 15 && depth != 16 && depth != 32) {
-		printk(KERN_ERR "%s: can't use depth = %d\n", full_name,
-		       depth);
+		printk(KERN_ERR "%pOF: can't use depth = %d\n", dp, depth);
 		release_mem_region(res_start, res_size);
 		return;
 	}
 
 	info = framebuffer_alloc(sizeof(u32) * 16, NULL);
-
+
 	if (info == 0) {
 		release_mem_region(res_start, res_size);
 		return;

@@ -515,7 +514,7 @@ static void __init offb_init_fb(const char *name, const char *full_name,
 	if (register_framebuffer(info) < 0)
 		goto out_err;
 
-	fb_info(info, "Open Firmware frame buffer device on %s\n", full_name);
+	fb_info(info, "Open Firmware frame buffer device on %pOF\n", dp);
 	return;
 
 out_err:

@@ -644,7 +643,6 @@ static void __init offb_init_nodriver(struct device_node *dp, int no_real_node)
 		if (strcmp(dp->name, "valkyrie") == 0)
 			address += 0x1000;
 		offb_init_fb(no_real_node ? "bootx" : dp->name,
-			     no_real_node ? "display" : dp->full_name,
 			     width, height, depth, pitch, address,
 			     foreign_endian, no_real_node ? NULL : dp);
 	}

drivers/video/fbdev/p9100.c +2 -2

index 1f6ee76af878..64de5cda541d 100644
@@ -304,8 +304,8 @@ static int p9100_probe(struct platform_device *op)
 
 	dev_set_drvdata(&op->dev, info);
 
-	printk(KERN_INFO "%s: p9100 at %lx:%lx\n",
-	       dp->full_name,
+	printk(KERN_INFO "%pOF: p9100 at %lx:%lx\n",
+	       dp,
 	       par->which_io, info->fix.smem_start);
 
 	return 0;

drivers/video/fbdev/sunxvr1000.c +5 -5

index fb37f6e05391..8fe37c0ef2f5 100644
@@ -33,8 +33,8 @@ static int gfb_get_props(struct gfb_info *gp)
 	gp->depth = of_getintprop_default(gp->of_node, "depth", 32);
 
 	if (!gp->width || !gp->height) {
-		printk(KERN_ERR "gfb: Critical properties missing for %s\n",
-		       gp->of_node->full_name);
+		printk(KERN_ERR "gfb: Critical properties missing for %pOF\n",
+		       gp->of_node);
 		return -EINVAL;
 	}

@@ -151,12 +151,12 @@ static int gfb_probe(struct platform_device *op)
 	if (err)
 		goto err_unmap_fb;
 
-	printk("gfb: Found device at %s\n", dp->full_name);
+	printk("gfb: Found device at %pOF\n", dp);
 
 	err = register_framebuffer(info);
 	if (err < 0) {
-		printk(KERN_ERR "gfb: Could not register framebuffer %s\n",
-		       dp->full_name);
+		printk(KERN_ERR "gfb: Could not register framebuffer %pOF\n",
+		       dp);
 		goto err_unmap_fb;
 	}

drivers/video/fbdev/tcx.c +2 -2

index 54ad08854c94..c98d8a569ccd 100644
@@ -467,8 +467,8 @@ static int tcx_probe(struct platform_device *op)
 
 	dev_set_drvdata(&op->dev, info);
 
-	printk(KERN_INFO "%s: TCX at %lx:%lx, %s\n",
-	       dp->full_name,
+	printk(KERN_INFO "%pOF: TCX at %lx:%lx, %s\n",
+	       dp,
 	       par->which_io,
 	       info->fix.smem_start,
 	       par->lowdepth ? "8-bit only" : "24-bit depth");

drivers/video/of_display_timing.c +16 ~~-25~~

115 lines not on this page · raw message

drivers/video/of_videomode.c +1 -1

index b5102aa6090d..9b5f9de88fec 100644
@@ -36,7 +36,7 @@ int of_get_videomode(struct device_node *np, struct videomode *vm,
 
 	disp = of_get_display_timings(np);
 	if (!disp) {
-		pr_err("%s: no timings specified\n", of_node_full_name(np));
+		pr_err("%pOF: no timings specified\n", np);
 		return -EINVAL;
 	}

--
2.11.0

Bartlomiej Zolnierkiewicz

2017-08-01 13:47 UTC #1 lore raw

Quoted 7 lines · Rob Herring

Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.
Signed-off-by Rob Herring <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc [email protected]

The patch Looks fine to me. Do you want me to merge it through fbdev tree or do you have some other plan for %pOF conversion patches?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

Rob Herring

author

2017-08-01 17:24 UTC #2 lore raw

Quoted 11 lines · Bartlomiej Zolnierkiewicz

Quoted 7 lines · Rob Herring
Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.
Signed-off-by Rob Herring <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc [email protected]
The patch Looks fine to me. Do you want me to merge it through fbdev tree or do you have some other plan for %pOF conversion patches?

Please take thru the fbdev tree.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Bartlomiej Zolnierkiewicz

2017-08-07 15:02 UTC #3 lore raw

Quoted 7 lines · Rob Herring

Quoted 5 lines · Bartlomiej Zolnierkiewicz
Quoted 4 lines · Rob Herring
Now that we have a custom printf format specifier, convert users of full_name to use %pOF instead. This is preparation to remove storing of the full path string for each node.

Quoted 8 lines

Quoted 6 lines
Quoted 3 lines
Signed-off-by Rob Herring <[email protected]>
Cc Bartlomiej Zolnierkiewicz <[email protected]>
Cc [email protected]
The patch Looks fine to me. Do you want me to merge it through fbdev tree or do you have some other plan for %pOF conversion patches?
Please take thru the fbdev tree.

Patch queued for 4.14, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics