Skip to contentSkip to conversation

crypto: omap-sham: remove unnecessary static in omap_sham_remove()

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Jul 18, 2017 – Aug 3, 2017 Crypto API

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 crypto: omap-sham: remove unnecessary static in omap_sham_remove()

Remove unnecessary static on local variable dd. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a difference in the object file size. This log is the output of the size command, before and after the code change:

before:
text data bss dec hex filename
26135 11944 128 38207 953f drivers/crypto/omap-sham.o

after:
text data bss dec hex filename
26084 11856 64 38004 9474 drivers/crypto/omap-sham.o

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/crypto/omap-sham.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/omap-sham.c +1 -1
index 9ad9d39..c40ac30 100644
@@ -2133,7 +2133,7 @@ static int omap_sham_probe(struct platform_device *pdev)
 
 static int omap_sham_remove(struct platform_device *pdev)
 {
-	static struct omap_sham_dev *dd;
+	struct omap_sham_dev *dd;
 	int i, j;
 
 	dd = platform_get_drvdata(pdev);
Signature · 1 line
2.5.0
maintainer
#1 lore raw
Quoted 16 lines · Gustavo A. R. Silva

Remove unnecessary static on local variable dd. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a difference in the object file size. This log is the output of the size command, before and after the code change:

before:
text data bss dec hex filename
26135 11944 128 38207 953f drivers/crypto/omap-sham.o

Quoted 5 lines

after:
text data bss dec hex filename
26084 11856 64 38004 9474 drivers/crypto/omap-sham.o

Signed-off-by Gustavo A. R. Silva <[email protected]>

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt