Skip to contentSkip to conversation

crypto: img-hash: remove unnecessary static in img_hash_remove()

PATCH In review Gustavo A. R. Silva 2 participants 2 messages Jul 18, 2017 – Aug 3, 2017 Crypto API

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 crypto: img-hash: remove unnecessary static in img_hash_remove()

Remove unnecessary static on local variable hdev. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a significant difference in the object file size. This log is the output of the size command, before and after the code change:

before:

   text    data     bss     dec     hex filename
  14842    6464     128   21434    53ba drivers/crypto/img-hash.o

after:
text data bss dec hex filename
14789 6376 64 21229 52ed drivers/crypto/img-hash.o

Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/crypto/img-hash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/img-hash.c +1 -1
index 0c6a917..b87000a 100644
@@ -1054,7 +1054,7 @@ static int img_hash_probe(struct platform_device *pdev)
 
 static int img_hash_remove(struct platform_device *pdev)
 {
-	static struct img_hash_dev *hdev;
+	struct img_hash_dev *hdev;
 
 	hdev = platform_get_drvdata(pdev);
 	spin_lock(&img_hash.lock);
Signature · 1 line
2.5.0
maintainer
#1 lore raw
Quoted 13 lines · Gustavo A. R. Silva

Remove unnecessary static on local variable hdev. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the object file size.

This issue was detected using Coccinelle and the following semantic patch:
https://github.com/GustavoARSilva/coccinelle/blob/master/static/static_unused.cocci

In the following log you can see a significant difference in the object file size. This log is the output of the size command, before and after the code change:

before:

Quoted 8 lines
  text    data     bss     dec     hex filename
 14842    6464     128   21434    53ba drivers/crypto/img-hash.o

after:
text data bss dec hex filename
14789 6376 64 21229 52ed drivers/crypto/img-hash.o

Signed-off-by Gustavo A. R. Silva <[email protected]>

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt