Skip to contentSkip to conversation

bwm-ng: update to latest upstream version to fix build issue

PATCH New Kelvin Cheung 2 participants 5 messages Jul 5, 2017 – Jul 19, 2017

lore
Share & tools
lore

Kelvin Cheung

author
#0 lore raw

PATCH 1/1 bwm-ng: update to latest upstream version to fix build issue

From: Keguang Zhang <[email protected]>

The latest upstream version had fixed the build issus.

Fixes:
http://autobuild.buildroot.net/results/1d9/1d9f0b62e4cc387f508b4fe0086621ab9996a085/

Signed-off-by Keguang Zhang <[email protected]>
---
 package/bwm-ng/bwm-ng.hash | 2 +-
 package/bwm-ng/bwm-ng.mk   | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)
package/bwm-ng/bwm-ng.hash +1 -1
index 1d3a240..4c12b0d 100644
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256  027cf3c960cd96fc9ffacdf7713df62d0fc55eeef4a1388289f8a62ae5e50df0  bwm-ng-0.6.1.tar.gz
+sha256  4b34a8ac2eae2d204d6dea8258c5e34b37094259086f8c9169391409a9311fb5  bwm-ng-f54b3fad2c80bfe63f920c9b5e7c1d80389c57ef.tar.gz
package/bwm-ng/bwm-ng.mk +3 -2
index 85ee689..587ffbe 100644
@@ -4,11 +4,12 @@
 #
 ################################################################################
 
-BWM_NG_VERSION = 0.6.1
-BWM_NG_SITE = http://www.gropp.org/bwm-ng
+BWM_NG_VERSION = f54b3fad2c80bfe63f920c9b5e7c1d80389c57ef
+BWM_NG_SITE = $(call github,vgropp,bwm-ng,$(BWM_NG_VERSION))
 BWM_NG_CONF_OPTS = --with-procnetdev --with-diskstats
 BWM_NG_LICENSE = GPL-2.0
 BWM_NG_LICENSE_FILES = COPYING
+BWM_NG_AUTORECONF = YES
 
 ifeq ($(BR2_PACKAGE_NCURSES),y)
 BWM_NG_CONF_OPTS += --with-ncurses
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 bwm-ng: update to latest upstream version to fix build issue

Hello,

Quoted 8 lines · Kelvin Cheung

From: Keguang Zhang <[email protected]>

The latest upstream version had fixed the build issus.

Fixes:
http://autobuild.buildroot.net/results/1d9/1d9f0b62e4cc387f508b4fe0086621ab9996a085/

Signed-off-by Keguang Zhang <[email protected]>

Thanks. However, rather than bumping and having to autoreconf, I'm wondering if simply adding
https://github.com/vgropp/bwm-ng/commit/d5daf15c2098040b8b01753d3cdce8c1c79fc528.patch
inside package/bwm-ng/ isn't a simpler solution.

Peter?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 bwm-ng: update to latest upstream version to fix build issue

Hi Thomas,
Since the upstream had fixed the error, we have no reason to keep a patch inside package/bwm-ng/.

Moreover, the update contains not only th fix for build issue, but also a improvement
https://github.com/vgropp/bwm-ng/commit/e9b980464e1fd72ae1b3d1002afb3b911daad619.patch
.

Therefore, I think updating version is better.

2017-07-05 18:38 GMT+08:00 Thomas Petazzoni <
[email protected]>:

Quoted 27 lines

Hello,

Quoted 6 lines · Kelvin Cheung

From: Keguang Zhang <[email protected]>

The latest upstream version had fixed the build issus.

Fixes:
http://autobuild.buildroot.net/results/1d9/

1d9f0b62e4cc387f508b4fe0086621ab9996a085/

Quoted 2 lines
Signed-off-by Keguang Zhang <[email protected]>

Thanks. However, rather than bumping and having to autoreconf, I'm wondering if simply adding
https://github.com/vgropp/bwm-ng/commit/d5daf15c2098040b8b01753d3cdce8
c1c79fc528.patch
inside package/bwm-ng/ isn't a simpler solution.

Peter?

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Signature · 6 lines
Best regards,

Kelvin Cheung
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170706/d2ff412a/attachment.html>
author
#3 lore raw

PATCH 1/1 bwm-ng: update to latest upstream version to fix build issue

Hi Thomas,
The autobuild keeps sending the mail to mek.
Can this patch be accepted?
Thanks!

2017-07-06 10:00 GMT+08:00 Kelvin Cheung <[email protected]>:

Quoted 49 lines

Hi Thomas,
Since the upstream had fixed the error, we have no reason to keep a patch inside package/bwm-ng/.

Moreover, the update contains not only th fix for build issue, but also a improvement
https://github.com/vgropp/bwm-ng/commit/e9b980464e1fd72ae1b3d1002afb3b
911daad619.patch.

Therefore, I think updating version is better.

2017-07-05 18:38 GMT+08:00 Thomas Petazzoni <thomas.petazzoni@free- electrons.com>:

Quoted 19 lines

Hello,

Quoted 6 lines · Kelvin Cheung

From: Keguang Zhang <[email protected]>

The latest upstream version had fixed the build issus.

Fixes:
http://autobuild.buildroot.net/results/1d9/1d9f0b62e4cc387f5

08b4fe0086621ab9996a085/

Quoted 2 lines
Signed-off-by Keguang Zhang <[email protected]>

Thanks. However, rather than bumping and having to autoreconf, I'm wondering if simply adding
https://github.com/vgropp/bwm-ng/commit/d5daf15c2098040b8b01
753d3cdce8c1c79fc528.patch
inside package/bwm-ng/ isn't a simpler solution.

Quoted 8 lines

Peter?

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

--
Best regards,

Kelvin Cheung

Signature · 6 lines
Best regards,

Kelvin Cheung
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170719/8ea72a14/attachment.html>
Applied
#4 lore raw

PATCH 1/1 bwm-ng: update to latest upstream version to fix build issue

In reply to Kelvin Cheung

Hello,

Quoted 4 lines · Kelvin Cheung

From: Keguang Zhang <[email protected]>

The latest upstream version had fixed the build issus.

Quoted 8 lines

Fixes:
http://autobuild.buildroot.net/results/1d9/1d9f0b62e4cc387f508b4fe0086621ab9996a085/

Signed-off-by Keguang Zhang <[email protected]>
---
 package/bwm-ng/bwm-ng.hash | 2 +-
 package/bwm-ng/bwm-ng.mk   | 5 +++--
 2 files changed, 4 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com