ext4: remove unused mode parameter
PATCH 1/1 ext4: remove unused mode parameter
ext4_alloc_file_blocks() does not use its mode parameter. Remove it.
Fixes 0e8b6879f3c2 ("ext4: refactor ext4_fallocate code")
Signed-off-by Tahsin Erdogan <[email protected]>
--- fs/ext4/extents.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)
fs/ext4/extents.c +4 -5
@@ -4652,7 +4652,7 @@ int ext4_ext_truncate(handle_t *handle, struct inode *inode)static int ext4_alloc_file_blocks (struct file *file,ext4_lblk_t offset,ext4_lblk_t len,loff_t new_size, -int flags,int mode) +int flags) {struct inode *inode =file_inode (file);handle_t *handle;
@@ -4815,7 +4815,7 @@ static long ext4_zero_range(struct file *file, loff_t offset,round_down (offset,1 << blkbits) >> blkbits, (round_up ((offset + len),1 << blkbits) -round_down (offset,1 << blkbits)) >> blkbits, - new_size, flags, mode); + new_size, flags);if (ret) goto out_dio;
@@ -4841,7 +4841,7 @@ static long ext4_zero_range(struct file *file, loff_t offset, inode->i_mtime = inode->i_ctime =current_time (inode); ret =ext4_alloc_file_blocks (file, lblk, max_blocks, new_size, - flags, mode); + flags);up_write (&EXT4_I (inode)->i_mmap_sem);if (ret) goto out_dio;
@@ -4976,8 +4976,7 @@ long ext4_fallocate(struct file *file, int mode, loff_t offset, loff_t len)ext4_inode_block_unlocked_dio (inode);inode_dio_wait (inode); - ret =ext4_alloc_file_blocks (file, lblk, max_blocks, new_size, - flags, mode); + ret =ext4_alloc_file_blocks (file, lblk, max_blocks, new_size, flags);ext4_inode_resume_unlocked_dio (inode);if (ret) goto out;
Signature · 1 line
2.14.0.rc0.284.gd933b75aa4-goog
Quoted 3 lines · Tahsin Erdogan
ext4_alloc_file_blocks()does not use its mode parameter. Remove it.Signed-off-by Tahsin Erdogan <[email protected]>
Thanks, applied.
- Ted