Skip to contentSkip to conversation

drm/panel: simple: Fix width and height for Olimex LCD-OLinuXino-4.3TS

PATCH Applied Jonathan Liu 3 participants 3 messages Jul 20, 2017 – Aug 18, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/panel: simple: Fix width and height for Olimex LCD-OLinuXino-4.3TS

The physical size of the panel is 105.5 (W) x 67.2 (H) x 4.05 (D) mm but the active display area is 95.04 (W) x 53.856 (H) mm.

The width and height should be set to the active display area.

---
 drivers/gpu/drm/panel/panel-simple.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/panel/panel-simple.c +2 -2
index 474fa759e06e..39a622a547e7 100644
@@ -1522,8 +1522,8 @@ static const struct panel_desc olimex_lcd_olinuxino_43ts = {
 	.modes = &olimex_lcd_olinuxino_43ts_mode,
 	.num_modes = 1,
 	.size = {
-		.width = 105,
-		.height = 67,
+		.width = 95,
+		.height = 54,
 	},
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
Signature · 1 line
2.13.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 6 lines · Jonathan Liu

The physical size of the panel is 105.5 (W) x 67.2 (H) x 4.05 (D) mm but the active display area is 95.04 (W) x 53.856 (H) mm.

The width and height should be set to the active display area.

You probably want:

Fixes cf5c9e6dc70d ("drm/panel: simple: Add timings for the Olimex
                      LCD-OLinuXino-4.3TS")

Otherwise,

against the panel datasheet linked from Olimex's product page. This should probably go in through drm-misc?

#2 lore raw
In reply to Jonathan Liu
Quoted 9 lines · Jonathan Liu

The physical size of the panel is 105.5 (W) x 67.2 (H) x 4.05 (D) mm but the active display area is 95.04 (W) x 53.856 (H) mm.

The width and height should be set to the active display area.

---
 drivers/gpu/drm/panel/panel-simple.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to drm-misc-next, thanks.

Thierry

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel