Skip to contentSkip to conversation

staging: pi433: - style fix, space at start of line

PATCH In review Derek Robson 3 participants 3 messages Jul 22, 2017 – Jul 24, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 3/3 staging: pi433: - style fix, space at start of line

Fixed checkpatch errors of "please, no spaces at the start of a line"

---
 drivers/staging/pi433/rf69.c      |   4 +-
 drivers/staging/pi433/rf69_enum.h | 206 +++++++++++++++++++-------------------
 2 files changed, 105 insertions(+), 105 deletions(-)
drivers/staging/pi433/rf69.c +2 -2
index d931437f0b6a..f450bbf3fbbc 100644
@@ -440,8 +440,8 @@ int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mant
 	// check value for mantisse and exponent
 	if (exponent > 7)   INVALID_PARAM;
 	if ( (mantisse!=mantisse16) &&
-	     (mantisse!=mantisse20) &&
-             (mantisse!=mantisse24) ) INVALID_PARAM;
+		(mantisse!=mantisse20) &&
+		(mantisse!=mantisse24) ) INVALID_PARAM;
 
 	// read old value
 	newValue = READ_REG(reg);
drivers/staging/pi433/rf69_enum.h +103 -103

284 lines not on this page · raw message

Signature · 1 line
2.13.2
Reviewed-by on v1 3/3
#1 lore raw

Regarding the patch for rf69.c, I'd prefer to have all mantisses allinged (all 'm' as a column below each other, all 'a' below each other, ...). For me that improves the readability a lot. Maybe that can be acchieved somehow without breaking the style rules - but for sure, that's just luxury :-)

Thanks to Derk for his routine piece of work :-)

Marcus

Quoted 321 lines

Derek Robson <[email protected]> hat am 22. Juli 2017 um 05:51 geschrieben:

Fixed checkpatch errors of "please, no spaces at the start of a line"

---
drivers/staging/pi433/rf69.c | 4 +- drivers/staging/pi433/rf69_enum.h | 206 +++++++++++++++++++-------------------

2 files changed, 105 insertions(+), 105 deletions(-)
drivers/staging/pi433/rf69.c +0 -0
index d931437f0b6a..f450bbf3fbbc 100644
@@ -440,8 +440,8 @@ int rf69_set_bandwidth_intern(struct spi_device *spi, u8

reg, enum mantisse mant
// check value for mantisse and exponent
if (exponent > 7) INVALID_PARAM;
if ( (mantisse!=mantisse16) &&
- (mantisse!=mantisse20) &&
- (mantisse!=mantisse24) ) INVALID_PARAM;
+ (mantisse!=mantisse20) &&
+ (mantisse!=mantisse24) ) INVALID_PARAM;

// read old value
newValue = READ_REG(reg);

drivers/staging/pi433/rf69_enum.h +0 -0
index fbfb59bd3f3d..635629415e63 100644
@@ -20,181 +20,181 @@
 

enum optionOnOff
{
- optionOff,
- optionOn
+ optionOff,
+ optionOn
};

enum mode
{
- mode_sleep,
- standby,
- synthesizer,
- transmit,
- receive
+ mode_sleep,
+ standby,
+ synthesizer,
+ transmit,
+ receive
};

enum dataMode
{
- packet,
- continuous,
- continuousNoSync
+ packet,
+ continuous,
+ continuousNoSync
};

enum modulation
{
- OOK,
- FSK
+ OOK,
+ FSK
};

enum modShaping
{
- shapingOff,
- shaping1_0,
- shaping0_5,
- shaping0_3,
- shapingBR,
- shaping2BR
+ shapingOff,
+ shaping1_0,
+ shaping0_5,
+ shaping0_3,
+ shapingBR,
+ shaping2BR
};

enum paRamp
{
- ramp3400,
- ramp2000,
- ramp1000,
- ramp500,
- ramp250,
- ramp125,
- ramp100,
- ramp62,
- ramp50,
- ramp40,
- ramp31,
- ramp25,
- ramp20,
- ramp15,
- ramp12,
- ramp10
+ ramp3400,
+ ramp2000,
+ ramp1000,
+ ramp500,
+ ramp250,
+ ramp125,
+ ramp100,
+ ramp62,
+ ramp50,
+ ramp40,
+ ramp31,
+ ramp25,
+ ramp20,
+ ramp15,
+ ramp12,
+ ramp10
};

enum antennaImpedance
{
- fiftyOhm,
- twohundretOhm
+ fiftyOhm,
+ twohundretOhm
};

enum lnaGain
{
- automatic,
- max,
- maxMinus6,
- maxMinus12,
- maxMinus24,
- maxMinus36,
- maxMinus48,
- undefined
+ automatic,
+ max,
+ maxMinus6,
+ maxMinus12,
+ maxMinus24,
+ maxMinus36,
+ maxMinus48,
+ undefined
};

enum dccPercent
{
- dcc16Percent,
- dcc8Percent,
- dcc4Percent,
- dcc2Percent,
- dcc1Percent,
- dcc0_5Percent,
- dcc0_25Percent,
- dcc0_125Percent
+ dcc16Percent,
+ dcc8Percent,
+ dcc4Percent,
+ dcc2Percent,
+ dcc1Percent,
+ dcc0_5Percent,
+ dcc0_25Percent,
+ dcc0_125Percent
};

enum mantisse
{
- mantisse16,
- mantisse20,
- mantisse24
+ mantisse16,
+ mantisse20,
+ mantisse24
};

enum thresholdType
{
- fixed,
- peak,
- average
+ fixed,
+ peak,
+ average
};

enum thresholdStep
{
- step_0_5db,
- step_1_0db,
- step_1_5db,
- step_2_0db,
- step_3_0db,
- step_4_0db,
- step_5_0db,
- step_6_0db
+ step_0_5db,
+ step_1_0db,
+ step_1_5db,
+ step_2_0db,
+ step_3_0db,
+ step_4_0db,
+ step_5_0db,
+ step_6_0db
};

enum thresholdDecrement
{
- dec_every8th,
- dec_every4th,
- dec_every2nd,
- dec_once,
- dec_twice,
- dec_4times,
- dec_8times,
- dec_16times
+ dec_every8th,
+ dec_every4th,
+ dec_every2nd,
+ dec_once,
+ dec_twice,
+ dec_4times,
+ dec_8times,
+ dec_16times
};

enum flag
{
- modeSwitchCompleted,
- readyToReceive,
- readyToSend,
- pllLocked,
- rssiExceededThreshold,
- timeout,
- automode,
- syncAddressMatch,
- fifoFull,
-// fifoNotEmpty, collision with next enum; replaced by following enum...
- fifoEmpty,
- fifoLevelBelowThreshold,
- fifoOverrun,
- packetSent,
- payloadReady,
- crcOk,
- batteryLow
+ modeSwitchCompleted,
+ readyToReceive,
+ readyToSend,
+ pllLocked,
+ rssiExceededThreshold,
+ timeout,
+ automode,
+ syncAddressMatch,
+ fifoFull,
+ // fifoNotEmpty, collision with next enum; replaced by following enum...
+ fifoEmpty,
+ fifoLevelBelowThreshold,
+ fifoOverrun,
+ packetSent,
+ payloadReady,
+ crcOk,
+ batteryLow
};

enum fifoFillCondition
{
- afterSyncInterrupt,
- always
+ afterSyncInterrupt,
+ always
};

enum packetFormat
{
- packetLengthFix,
- packetLengthVar
+ packetLengthFix,
+ packetLengthVar
};

enum txStartCondition
{
- fifoLevel,
- fifoNotEmpty
+ fifoLevel,
+ fifoNotEmpty
};

enum addressFiltering
{
- filteringOff,
- nodeAddress,
- nodeOrBroadcastAddress
+ filteringOff,
+ nodeAddress,
+ nodeOrBroadcastAddress
};

enum dagc
{
- normalMode,
- improve,
- improve4LowModulationIndex
+ normalMode,
+ improve,
+ improve4LowModulationIndex
};

--
2.13.2

#2 lore raw
In reply to Derek Robson
Quoted 13 lines · Derek Robson

Fixed checkpatch errors of "please, no spaces at the start of a line"

---
 drivers/staging/pi433/rf69.c      |   4 +-
 drivers/staging/pi433/rf69_enum.h | 206 +++++++++++++++++++-------------------
 2 files changed, 105 insertions(+), 105 deletions(-)
drivers/staging/pi433/rf69.c +0 -0
index d931437f0b6a..f450bbf3fbbc 100644

drivers/staging/pi433/rf69.c int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mant · line 445

Quoted 8 lines
drivers/staging/pi433/rf69.c +2 -2
@@ -440,8 +440,8 @@ int rf69_set_bandwidth_intern(struct spi_device *spi, u8 reg, enum mantisse mant
 	// check value for mantisse and exponent
 	if (exponent > 7)   INVALID_PARAM;
 	if ( (mantisse!=mantisse16) &&
-	     (mantisse!=mantisse20) &&
-             (mantisse!=mantisse24) ) INVALID_PARAM;
+		(mantisse!=mantisse20) &&
+		(mantisse!=mantisse24) ) INVALID_PARAM;
 

This is wrong. It should be aligned like this:

	if (exponent > 7)
		INVALID_PARAM;
	if (mantisse != mantisse16 &&
	    mantisse != mantisse20 &&
	    mantisse != mantisse24)
		INVALID_PARAM;

regards,
dan carpenter