package/openal: bump version to 1.18.0

PATCH New André Hentschel 2 participants 4 messages Jul 21, 2017 – Jul 22, 2017

lore

Share & tools

lore

André Hentschel

author

2017-07-21 13:33 UTC #0 lore raw

PATCH 1/1 package/openal: bump version to 1.18.0

Signed-off-by Andr? Hentschel <[email protected]>

---
 .../0001-Build-NEON-code-with-mfpu-neon.patch      | 29 ----------
 ...heck-for-run-time-NEON-support-by-reading.patch | 67 ----------------------
 ...003-Properly-check-if-proc-cpuinfo-opened.patch | 24 --------
 ...k-if-mfpu-neon-is-available-for-compiling.patch | 47 ---------------
 .../openal/0005-Fix-detection-of-C11-atomics.patch | 53 -----------------
 package/openal/openal.hash                         |  2 +-
 package/openal/openal.mk                           |  2 +-
 7 files changed, 2 insertions(+), 222 deletions(-)
 delete mode 100644 package/openal/0001-Build-NEON-code-with-mfpu-neon.patch
 delete mode 100644 package/openal/0002-Check-for-run-time-NEON-support-by-reading.patch
 delete mode 100644 package/openal/0003-Properly-check-if-proc-cpuinfo-opened.patch
 delete mode 100644 package/openal/0004-Check-if-mfpu-neon-is-available-for-compiling.patch
 delete mode 100644 package/openal/0005-Fix-detection-of-C11-atomics.patch

package/openal/0001-Build-NEON-code-with-mfpu-neon.patch deleted +0 ~~-29~~

deleted file mode 100644
index 090fdfc..0000000
@@ -1,29 +0,0 @@
-From 27916ce3db023454a0295ee63ea196fbc246674c Mon Sep 17 00:00:00 2001
-From: Thomas Petazzoni <[email protected]>
-Date: Tue, 6 Sep 2016 22:19:14 +0200
-Subject: [PATCH] Build NEON code with -mfpu=neon
-
-The ARM-specific NEON code needs to be built with -mfpu=neon to avoid
-build failures when a difference FPU is used by default by the
-compiler.
-
-Fixes issue #54.
-
-[Upstream commit: https://github.com/kcat/openal-soft/commit/27916ce3db023454a0295ee63ea196fbc246674c]
-Signed-off-by: Thomas Petazzoni <[email protected]>
----
- CMakeLists.txt | 1 +
- 1 file changed, 1 insertion(+)
-
-diff --git a/CMakeLists.txt b/CMakeLists.txt
-index d8f15153..d92bbb7d 100644
---- a/CMakeLists.txt
-+++ b/CMakeLists.txt
-@@ -767,6 +767,7 @@ IF(HAVE_ARM_NEON_H)
-         SET(HAVE_NEON 1)
-         SET(ALC_OBJS  ${ALC_OBJS} Alc/mixer_neon.c)
-         SET(CPU_EXTS "${CPU_EXTS}, Neon")
-+        SET_SOURCE_FILES_PROPERTIES(Alc/mixer_neon.c PROPERTIES COMPILE_FLAGS -mfpu=neon)
-     ENDIF()
- ENDIF()
- IF(ALSOFT_REQUIRE_NEON AND NOT HAVE_NEON)

package/openal/0002-Check-for-run-time-NEON-support-by-reading.patch deleted +0 ~~-67~~

67 lines not on this page · raw message

package/openal/0003-Properly-check-if-proc-cpuinfo-opened.patch deleted +0 ~~-24~~

deleted file mode 100644
index 60a93c0..0000000
@@ -1,24 +0,0 @@
-From c3c283a0b5d0130afafaa2a5b6ce6fbc30b6e6a1 Mon Sep 17 00:00:00 2001
-From: Chris Robinson <[email protected]>
-Date: Thu, 8 Sep 2016 02:02:09 -0700
-Subject: [PATCH] Properly check if /proc/cpuinfo opened
-
-[Upstream commit: https://github.com/kcat/openal-soft/commit/c3c283a0b5d0130afafaa2a5b6ce6fbc30b6e6a1]
-Signed-off-by: Thomas Petazzoni <[email protected]>
----
- Alc/helpers.c | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/Alc/helpers.c b/Alc/helpers.c
-index 4ffda46c..26ed535a 100644
---- a/Alc/helpers.c
-+++ b/Alc/helpers.c
-@@ -234,7 +234,7 @@ void FillCPUCaps(ALuint capfilter)
- #endif
- #ifdef HAVE_NEON
-     FILE *file = fopen("/proc/cpuinfo", "rt");
--    if(file)
-+    if(!file)
-         ERR("Failed to open /proc/cpuinfo, cannot check for NEON support\n");
-     else
-     {

package/openal/0004-Check-if-mfpu-neon-is-available-for-compiling.patch deleted +0 ~~-47~~

47 lines not on this page · raw message

package/openal/0005-Fix-detection-of-C11-atomics.patch deleted +0 ~~-53~~

53 lines not on this page · raw message

package/openal/openal.hash +1 -1

index 260f1b7..cb2586a 100644
@@ -1,2 +1,2 @@
 # Locally calculated
-sha256	a341f8542f1f0b8c65241a17da13d073f18ec06658e1a1606a8ecc8bbc2b3314	openal-soft-1.17.2.tar.bz2
+sha256	4433b1391c61a7ca36d82c946c8f0ffe410569d6437e4ce72b3547aaf966ecde	openal-soft-1.18.0.tar.bz2

package/openal/openal.mk +1 -1

index 55bf544..207526a 100644
@@ -4,7 +4,7 @@
 #
 ################################################################################
 
-OPENAL_VERSION = 1.17.2
+OPENAL_VERSION = 1.18.0
 OPENAL_SOURCE = openal-soft-$(OPENAL_VERSION).tar.bz2
 OPENAL_SITE = http://kcat.strangesoft.net/openal-releases
 OPENAL_LICENSE = LGPL-2.0+

Signature · 1 line

2.7.4

Thomas Petazzoni

2017-07-21 13:55 UTC #1 lore raw

PATCH 1/1 package/openal: bump version to 1.18.0

Hello,

Quoted 7 lines · Andr? Hentschel

Signed-off-by Andr? Hentschel <[email protected]>

---
 .../0001-Build-NEON-code-with-mfpu-neon.patch      | 29 ----------
 ...heck-for-run-time-NEON-support-by-reading.patch | 67 ----------------------
 ...003-Properly-check-if-proc-cpuinfo-opened.patch | 24 --------
 ...k-if-mfpu-neon-is-available-for-compiling.patch | 47 ---------------
 .../openal/0005-Fix-detection-of-C11-atomics.patch | 53 -----------------

When you drop patches, it's nice to have a slightly more descriptive commit log that says why those patches are dropped. For some of them, it's quite obvious, since they were backports from upstream commits (0001, 0002, 0003 and 0004), but for some others, it's not really obvious (patch 0005).

Is the patch 0005 now upstream and part of 1.18.0 ?

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

André Hentschel

author

2017-07-21 14:07 UTC #2 lore raw

PATCH 1/1 package/openal: bump version to 1.18.0

Am 21.07.2017 um 15:55 schrieb Thomas Petazzoni:

Quoted 11 lines

Hello,

Quoted 7 lines · Andr? Hentschel

Signed-off-by Andr? Hentschel <[email protected]>

---
 .../0001-Build-NEON-code-with-mfpu-neon.patch      | 29 ----------
 ...heck-for-run-time-NEON-support-by-reading.patch | 67 ----------------------
 ...003-Properly-check-if-proc-cpuinfo-opened.patch | 24 --------
 ...k-if-mfpu-neon-is-available-for-compiling.patch | 47 ---------------
 .../openal/0005-Fix-detection-of-C11-atomics.patch | 53 -----------------

Quoted 7 lines

When you drop patches, it's nice to have a slightly more descriptive commit log that says why those patches are dropped. For some of them, it's quite obvious, since they were backports from upstream commits (0001, 0002, 0003 and 0004), but for some others, it's not really obvious (patch 0005).
Is the patch 0005 now upstream and part of 1.18.0 ?

Hi,

yes it is: https://github.com/kcat/openal-soft/blob/master/CMakeLists.txt#L211

Thx!

Thomas Petazzoni

Applied

2017-07-22 13:16 UTC #3 lore raw

PATCH 1/1 package/openal: bump version to 1.18.0

In reply to André Hentschel

Hello,

Quoted 15 lines · Andr? Hentschel

Signed-off-by Andr? Hentschel <[email protected]>

---
 .../0001-Build-NEON-code-with-mfpu-neon.patch      | 29 ----------
 ...heck-for-run-time-NEON-support-by-reading.patch | 67 ----------------------
 ...003-Properly-check-if-proc-cpuinfo-opened.patch | 24 --------
 ...k-if-mfpu-neon-is-available-for-compiling.patch | 47 ---------------
 .../openal/0005-Fix-detection-of-C11-atomics.patch | 53 -----------------
 package/openal/openal.hash                         |  2 +-
 package/openal/openal.mk                           |  2 +-
 7 files changed, 2 insertions(+), 222 deletions(-)
 delete mode 100644 package/openal/0001-Build-NEON-code-with-mfpu-neon.patch
 delete mode 100644 package/openal/0002-Check-for-run-time-NEON-support-by-reading.patch
 delete mode 100644 package/openal/0003-Properly-check-if-proc-cpuinfo-opened.patch
 delete mode 100644 package/openal/0004-Check-if-mfpu-neon-is-available-for-compiling.patch
 delete mode 100644 package/openal/0005-Fix-detection-of-C11-atomics.patch

Applied to master after improving the commit log to explain the status of the removed patches.

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com