brcm-patchram-plus: new package

PATCH New Alexey Roslyakov 3 participants 4 messages Jul 21, 2017 – Jul 28, 2017

Share & tools

Alexey Roslyakov

author

2017-07-21 14:45 UTC #0 lore raw

PATCH 1/1 brcm-patchram-plus: new package

Many of Broadcom BCM43XX WiFi/Bluetooth combo chips have pretty tricky initialization. Broadcom patchram utility has been released to address the issue.

Signed-off-by Alexey Roslyakov <[email protected]>

---
 DEVELOPERS                                         |  3 +++
 package/Config.in                                  |  1 +
 package/brcm-patchram-plus/Config.in               |  6 ++++++
 package/brcm-patchram-plus/brcm-patchram-plus.hash |  2 ++
 package/brcm-patchram-plus/brcm-patchram-plus.mk   | 20 ++++++++++++++++++++
 5 files changed, 32 insertions(+)
 create mode 100644 package/brcm-patchram-plus/Config.in
 create mode 100644 package/brcm-patchram-plus/brcm-patchram-plus.hash
 create mode 100644 package/brcm-patchram-plus/brcm-patchram-plus.mk

DEVELOPERS +3 -0

index 7b7c5ab4e6..45466591da 100644
@@ -73,6 +73,9 @@ N:	Alexandre Esse <[email protected]>
 F:	package/kvazaar/
 F:	package/v4l2loopback/
 
+N:	Alexey Roslyakov <[email protected]>
+F:	package/brcm-patchram-plus
+
 N:	Alistair Francis <[email protected]>
 F:	package/xen/

package/Config.in +1 -0

index 7bb9471670..254bb540be 100644
@@ -372,6 +372,7 @@ endmenu
 	source "package/avrdude/Config.in"
 	source "package/bcache-tools/Config.in"
 	source "package/biosdevname/Config.in"
+	source "package/brcm-patchram-plus/Config.in"
 	source "package/cbootimage/Config.in"
 	source "package/cc-tool/Config.in"
 	source "package/cdrkit/Config.in"

package/brcm-patchram-plus/Config.in new file +6 -0

new file mode 100644
index 0000000000..f7df21d2b2
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_BRCM_PATCHRAM_PLUS
+	bool "brcm-patchram-plus"
+	help
+		Utility's to configure and test Broadcom Bluetooth chips on Linux.
+
+		https://code.google.com/archive/p/broadcom-bluetooth/

package/brcm-patchram-plus/brcm-patchram-plus.hash new file +2 -0

new file mode 100644
index 0000000000..2ecb1d72bc
@@ -0,0 +1,2 @@
+locally computed hash
+sha256	b80ea97f6ab96b68a54c7ae855c43544dcdfee501b4741de8fdfebe1c322ba53 brcm-patchram-plus_0.1.1.tar.gz

package/brcm-patchram-plus/brcm-patchram-plus.mk new file +20 -0

new file mode 100644
index 0000000000..903910db71
@@ -0,0 +1,20 @@
+################################################################################
+#
+# brcm_patchram_plus tool
+#
+################################################################################
+
+BRCM_PATCHRAM_PLUS_VERSION = 0.1.1
+BRCM_PATCHRAM_PLUS_SOURCE = brcm-patchram-plus_$(BRCM_PATCHRAM_PLUS_VERSION).tar.gz
+BRCM_PATCHRAM_PLUS_SITE = https://launchpad.net/ubuntu/+archive/primary/+files
+BRCM_PATCHRAM_PLUS_LICENSE = Apache-2.0
+
+define BRCM_PATCHRAM_PLUS_BUILD_CMDS
+	$(TARGET_CC) -o $(@D)/brcm_patchram_plus $(@D)/brcm_patchram_plus.c
+endef
+
+define BRCM_PATCHRAM_PLUS_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/brcm_patchram_plus $(TARGET_DIR)/usr/bin/brcm_patchram_plus
+endef
+
+$(eval $(generic-package))

Signature · 1 line

2.13.0

Thomas Petazzoni

2017-07-22 13:25 UTC #1 lore raw

PATCH 1/1 brcm-patchram-plus: new package

Hello,

Quoted 4 lines · Alexey Roslyakov

Many of Broadcom BCM43XX WiFi/Bluetooth combo chips have pretty tricky initialization. Broadcom patchram utility has been released to address the issue.
Signed-off-by Alexey Roslyakov <[email protected]>

Thanks for this contribution! See a few comments below.

DEVELOPERS N: Alexandre Esse <[email protected]> · line 77

Quoted 10 lines

DEVELOPERS +2 -0

index 7b7c5ab4e6..45466591da 100644
@@ -73,6 +73,9 @@ N:	Alexandre Esse <[email protected]>
 F:	package/kvazaar/
 F:	package/v4l2loopback/
 
+N:	Alexey Roslyakov <[email protected]>
+F:	package/brcm-patchram-plus

Please end the package path with a /, like all other entries in the DEVELOPERS file.

package/brcm-patchram-plus/Config.in line 6

Quoted 12 lines

package/brcm-patchram-plus/Config.in new file +6 -0

new file mode 100644
index 0000000000..f7df21d2b2
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_BRCM_PATCHRAM_PLUS
+	bool "brcm-patchram-plus"
+	help
+		Utility's to configure and test Broadcom Bluetooth chips on Linux.
+
+		https://code.google.com/archive/p/broadcom-bluetooth/

Indentation for the help text is one tab + two spaces. I would recommend you to run utils/check-package on your new package to catch such coding style issues.

package/brcm-patchram-plus/Config.in

Quoted 3 lines

package/brcm-patchram-plus/Config.in new file +3 -0

+BRCM_PATCHRAM_PLUS_VERSION = 0.1.1
+BRCM_PATCHRAM_PLUS_SOURCE = brcm-patchram-plus_$(BRCM_PATCHRAM_PLUS_VERSION).tar.gz
+BRCM_PATCHRAM_PLUS_SITE = https://launchpad.net/ubuntu/+archive/primary/+files

Perhaps using the git repository at
https://chromium.googlesource.com/chromiumos/third_party/broadcom would be a more "official" upstream ?

package/brcm-patchram-plus/Config.in

Quoted 7 lines

package/brcm-patchram-plus/Config.in new file +7 -0

+define BRCM_PATCHRAM_PLUS_BUILD_CMDS
+	$(TARGET_CC) -o $(@D)/brcm_patchram_plus $(@D)/brcm_patchram_plus.c
+endef
+
+define BRCM_PATCHRAM_PLUS_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/brcm_patchram_plus $(TARGET_DIR)/usr/bin/brcm_patchram_plus
+endef

What about using the Makefile that comes inside the package ? At least in the Git repository I pointed to, there is a Makefile that seems suitable.

Thanks!

Thoma

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Arnout Vandecappelle

2017-07-22 19:34 UTC #2 lore raw

PATCH 1/1 brcm-patchram-plus: new package

Quoted 3 lines · Thomas Petazzoni

Hello,
On Fri, 21 Jul 2017 21:45:20 +0700, Alexey Roslyakov wrote:

[snip]

Quoted 4 lines

package/brcm-patchram-plus/Config.in line 4
Quoted 4 lines
package/brcm-patchram-plus/Config.in new file +4 -0
+config BR2_PACKAGE_BRCM_PATCHRAM_PLUS
+	bool "brcm-patchram-plus"
+	help
+		Utility's to configure and test Broadcom Bluetooth chips on Linux.

Utilities

As I understand it, recent kernels should be able to load the firmware directly
from the driver, and recent bluez should be able to issue the other HCI commands. Is that correct or not?

Quoted 7 lines

package/brcm-patchram-plus/Config.in line 6
Quoted 2 lines
package/brcm-patchram-plus/Config.in new file +2 -0
+
+		https://code.google.com/archive/p/broadcom-bluetooth/
Indentation for the help text is one tab + two spaces. I would recommend you to run utils/check-package on your new package to catch such coding style issues.

Quoted 7 lines

package/brcm-patchram-plus/brcm-patchram-plus.mk line 9
Quoted 3 lines
package/brcm-patchram-plus/brcm-patchram-plus.mk new file +3 -0
+BRCM_PATCHRAM_PLUS_VERSION = 0.1.1
+BRCM_PATCHRAM_PLUS_SOURCE = brcm-patchram-plus_$(BRCM_PATCHRAM_PLUS_VERSION).tar.gz
+BRCM_PATCHRAM_PLUS_SITE = https://launchpad.net/ubuntu/+archive/primary/+files
Perhaps using the git repository at
https://chromium.googlesource.com/chromiumos/third_party/broadcom would be a more "official" upstream ?

Indeed, that's what's used by openembedded. It also has an additional feature
--enable_bt_rfkill.

There is also https://github.com/MarkMendelsohn/brcm_patchram - certainly less
official, but possibly better maintained. Well, it doesn't have --enable_bt_rfkill.

Regards,
Arnout

Quoted 16 lines

package/brcm-patchram-plus/brcm-patchram-plus.mk line 18
Quoted 7 lines
package/brcm-patchram-plus/brcm-patchram-plus.mk new file +7 -0
+define BRCM_PATCHRAM_PLUS_BUILD_CMDS
+	$(TARGET_CC) -o $(@D)/brcm_patchram_plus $(@D)/brcm_patchram_plus.c
+endef
+
+define BRCM_PATCHRAM_PLUS_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/brcm_patchram_plus $(TARGET_DIR)/usr/bin/brcm_patchram_plus
+endef
What about using the Makefile that comes inside the package ? At least in the Git repository I pointed to, there is a Makefile that seems suitable.
Thanks!
Thoma

Signature · 6 lines

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

Alexey Roslyakov

author

2017-07-28 06:39 UTC #3 lore raw

PATCH 1/1 brcm-patchram-plus: new package

In reply to Thomas Petazzoni

Thomas,
thank you for your suggestions.
Actually, it was confusing me (what to use as upstream) and I wished to write my concerns in the cover letter. But forgot to write it.

I'll send updated patch later today.

Quoted 75 lines · Thomas Petazzoni

Hello,
Quoted 1 line · Alexey Roslyakov
Many of Broadcom BCM43XX WiFi/Bluetooth combo chips have pretty tricky
initialization.
Quoted 3 lines
Broadcom patchram utility has been released to address the issue.
Signed-off-by Alexey Roslyakov <[email protected]>
Thanks for this contribution! See a few comments below.
DEVELOPERS N: Alexandre Esse <[email protected]> · line 77
Quoted 10 lines
DEVELOPERS +2 -0
index 7b7c5ab4e6..45466591da 100644
@@ -73,6 +73,9 @@ N:  Alexandre Esse <[email protected]>
 F:   package/kvazaar/
 F:   package/v4l2loopback/
 
+N:   Alexey Roslyakov <[email protected]>
+F:   package/brcm-patchram-plus
Please end the package path with a /, like all other entries in the DEVELOPERS file.
Review
Quoted 1 line
(quoted diff) +0 -0
b/package/brcm-patchram-plus/Config.in
package/brcm-patchram-plus/Config.in line 4
Quoted 9 lines
new file mode 100644
index 0000000000..f7df21d2b2
package/brcm-patchram-plus/Config.in new file +4 -0
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_BRCM_PATCHRAM_PLUS
+     bool "brcm-patchram-plus"
+     help
+             Utility's to configure and test Broadcom Bluetooth chips
on Linux.
package/brcm-patchram-plus/Config.in line 6
Quoted 2 lines
package/brcm-patchram-plus/Config.in new file +2 -0
+
+             https://code.google.com/archive/p/broadcom-bluetooth/
Indentation for the help text is one tab + two spaces. I would recommend you to run utils/check-package on your new package to catch such coding style issues.
package/brcm-patchram-plus/Config.in
Quoted 2 lines
package/brcm-patchram-plus/Config.in new file +2 -0
+BRCM_PATCHRAM_PLUS_VERSION = 0.1.1
+BRCM_PATCHRAM_PLUS_SOURCE = brcm-patchram-plus_$(BRCM_
PATCHRAM_PLUS_VERSION).tar.gz
Quoted 1 line
+BRCM_PATCHRAM_PLUS_SITE = https://launchpad.net/ubuntu/+
archive/primary/+files
Perhaps using the git repository at
https://chromium.googlesource.com/chromiumos/third_party/broadcom would be a more "official" upstream ?
package/brcm-patchram-plus/Config.in
Quoted 6 lines
package/brcm-patchram-plus/Config.in new file +6 -0
+define BRCM_PATCHRAM_PLUS_BUILD_CMDS
+     $(TARGET_CC) -o $(@D)/brcm_patchram_plus $(@D)/brcm_patchram_plus.c
+endef
+
+define BRCM_PATCHRAM_PLUS_INSTALL_TARGET_CMDS
+     $(INSTALL) -D -m 0755 $(@D)/brcm_patchram_plus
$(TARGET_DIR)/usr/bin/brcm_patchram_plus
Quoted 1 line
+endef
What about using the Makefile that comes inside the package ? At least in the Git repository I pointed to, there is a Makefile that seems suitable.
Thanks!
Thoma
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Signature · 6 lines

With best regards,
  Alexey Roslyakov
Email: alexey.roslyakov at gmail.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20170728/a1e4dd26/attachment.html>