Skip to contentSkip to conversation

staging: vboxvideo: Kconfig: Fix typos in help text

PATCH Superseded Martin Kepplinger 3 participants 6 messages Jul 24, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vboxvideo: Kconfig: Fix typos in help text

This fixes typos in vboxvideo's help text.

---
 drivers/staging/vboxvideo/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vboxvideo/Kconfig +2 -2
index a52746f9a670..2b058d573cf1 100644
@@ -6,7 +6,7 @@ config DRM_VBOXVIDEO
 	  This is a KMS driver for the virtual Graphics Card used in
 	  Virtual Box virtual machines.
 
-	  Although it is possible to builtin this module, it is advised
+	  Although it is possible to build in this module, it is advised
 	  to build this driver as a module, so that it can be updated
-	  independently of the kernel. Select M to built this driver as a
+	  independently of the kernel. Select M to build this driver as a
 	  module and add support for these devices via drm/kms interfaces.
Signature · 1 line
2.11.0
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 3 lines · Martin Kepplinger

This fixes typos in vboxvideo's help text.

Looks good to me:

Regards,

Hans

Quoted 19 lines
---
  drivers/staging/vboxvideo/Kconfig | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vboxvideo/Kconfig +2 -2
index a52746f9a670..2b058d573cf1 100644
@@ -6,7 +6,7 @@ config DRM_VBOXVIDEO
  	  This is a KMS driver for the virtual Graphics Card used in
  	  Virtual Box virtual machines.
 
-	  Although it is possible to builtin this module, it is advised
+	  Although it is possible to build in this module, it is advised
  	  to build this driver as a module, so that it can be updated
-	  independently of the kernel. Select M to built this driver as a
+	  independently of the kernel. Select M to build this driver as a
  	  module and add support for these devices via drm/kms interfaces.
#2 lore raw
In reply to Martin Kepplinger
Quoted 12 lines · Martin Kepplinger

This fixes typos in vboxvideo's help text.

---
 drivers/staging/vboxvideo/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/vboxvideo/Kconfig +0 -0
index a52746f9a670..2b058d573cf1 100644

drivers/staging/vboxvideo/Kconfig config DRM_VBOXVIDEO · line 9

Quoted 5 lines
drivers/staging/vboxvideo/Kconfig +1 -1
@@ -6,7 +6,7 @@ config DRM_VBOXVIDEO
 	  This is a KMS driver for the virtual Graphics Card used in
 	  Virtual Box virtual machines.
 
-	  Although it is possible to builtin this module, it is advised
+	  Although it is possible to build in this module, it is advised

I feel like this is unclear. Perhaps say something like:

Although it is possible to build this driver built-in to the kernel, it is advised ...

regards,
dan carpenter

#3 lore raw

PATCH v2 1/1 staging: vboxvideo: Kconfig: Fix typos in help text

This fixes typos in vboxvideo's help text. Most notably, "to builtin this module" becomes "to build this driver built-in to the kernel".

---

Thanks Dan. I actually also had the feeling that even though it's better, it's not as clear as it could be. It's either a module or built-in; not both.

revision history
----------------
v2: Say "to build this driver built-in to the kernel" instead of "build in
this module".

 drivers/staging/vboxvideo/Kconfig | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/staging/vboxvideo/Kconfig +5 -4
index a52746f9a670..b8df8f60823a 100644
@@ -6,7 +6,8 @@ config DRM_VBOXVIDEO
 	  This is a KMS driver for the virtual Graphics Card used in
 	  Virtual Box virtual machines.
 
-	  Although it is possible to builtin this module, it is advised
-	  to build this driver as a module, so that it can be updated
-	  independently of the kernel. Select M to built this driver as a
-	  module and add support for these devices via drm/kms interfaces.
+	  Although it is possible to build this driver built-in to the
+	  kernel, it is advised to build this driver as a module, so that
+	  it can be updated independently of the kernel. Select M to build
+	  this driver as a module and add support for these devices via
+	  drm/kms interfaces.
Signature · 1 line
2.11.0
#4 lore raw

PATCH v3 1/1 staging: vboxvideo: Kconfig: Fix typos in help text

This fixes typos in vboxvideo's help text. Most notably, "to builtin this module" becomes "to build this driver built-in to the kernel".

---

revision history
----------------
v3: Avoid a repetition of "this driver".

v2: Say "to build this driver built-in to the kernel" instead of "build in
this module". - Thanks Dan.

 drivers/staging/vboxvideo/Kconfig | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/staging/vboxvideo/Kconfig +5 -4
index a52746f9a670..3200b6895178 100644
@@ -6,7 +6,8 @@ config DRM_VBOXVIDEO
 	  This is a KMS driver for the virtual Graphics Card used in
 	  Virtual Box virtual machines.
 
-	  Although it is possible to builtin this module, it is advised
-	  to build this driver as a module, so that it can be updated
-	  independently of the kernel. Select M to built this driver as a
-	  module and add support for these devices via drm/kms interfaces.
+	  Although it is possible to build this driver built-in to the
+	  kernel, it is advised to build it as a module, so that it can
+	  be updated independently of the kernel. Select M to build this
+	  driver as a module and add support for these devices via drm/kms
+	  interfaces.
Signature · 1 line
2.11.0