Skip to contentSkip to conversation

ARM: add missing includes to header files

PATCH In review Johan Hovold 3 participants 6 messages Jul 4, 2017 – Jul 24, 2017

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover ARM: add missing includes to header files

Add two missing include directives to two header files to avoid compile breakage when the required symbols have not already been defined.

The missing SCU include broke compilation of the (not-yet-merged) suspend support for am335x when !CONFIG_HAVE_ARM_SCU for example:

	https://lkml.kernel.org/r/20170704131441.GH27842 at localhost

Johan

Johan Hovold (2):
ARM: scu: add missing errno include
ARM: pm: add missing types include

 arch/arm/include/asm/smp_scu.h | 1 +
 arch/arm/include/asm/suspend.h | 2 ++
 2 files changed, 3 insertions(+)
Signature · 1 line
2.13.2
#1 lore raw

PATCH 1/2 ARM: scu: add missing errno include

Add missing errno include to make the header self-contained and avoid compilation breakage when compiling shared code without CONFIG_HAVE_ARM_SCU.

---
 arch/arm/include/asm/smp_scu.h | 1 +
 1 file changed, 1 insertion(+)
arch/arm/include/asm/smp_scu.h +1 -0
index bfe163c40024..5983f6bc62d5 100644
@@ -7,6 +7,7 @@
 
 #ifndef __ASSEMBLER__
 
+#include <linux/errno.h>
 #include <asm/cputype.h>
 
 static inline bool scu_a9_has_base(void)
Signature · 1 line
2.13.2
#2 lore raw

PATCH 2/2 ARM: pm: add missing types include

In reply to Johan Hovold

Add missing types.h include to make the suspend header self-contained and avoid compilation breakage due to include-directive ordering.

---
 arch/arm/include/asm/suspend.h | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/include/asm/suspend.h +2 -0
index 6c7182f32cef..a61905c86732 100644
@@ -1,6 +1,8 @@
 #ifndef __ASM_ARM_SUSPEND_H
 #define __ASM_ARM_SUSPEND_H
 
+#include <linux/types.h>
+
 struct sleep_save_sp {
 	u32 *save_ptr_stash;
 	u32 save_ptr_stash_phys;
Signature · 1 line
2.13.2
Acked-by on v1 2/2
#3 lore raw

Re: [PATCH 2/2] ARM: pm: add missing types include

Quoted 4 lines · Johan Hovold

Add missing types.h include to make the suspend header self-contained and avoid compilation breakage due to include-directive ordering.

Quoted 6 lines

+++ b/arch/arm/include/asm/suspend.h
#define __ASM_ARM_SUSPEND_H

arch/arm/include/asm/suspend.h +2 -0
+#include <linux/types.h>
+
 struct sleep_save_sp {
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#4 lore raw
In reply to Johan Hovold
Quoted 8 lines · Johan Hovold

Add two missing include directives to two header files to avoid compile breakage when the required symbols have not already been defined.

The missing SCU include broke compilation of the (not-yet-merged) suspend support for am335x when !CONFIG_HAVE_ARM_SCU for example:

	https://lkml.kernel.org/r/20170704131441.GH27842 at localhost

These look reasonable, please send them to the patch system for merging after this merge window, thanks.

Signature · 3 lines
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
#5 lore raw
Quoted 5 lines · Russell King - ARM Linux
Quoted 4 lines · Johan Hovold

Add two missing include directives to two header files to avoid compile breakage when the required symbols have not already been defined.

Quoted 7 lines
Quoted 4 lines

The missing SCU include broke compilation of the (not-yet-merged) suspend support for am335x when !CONFIG_HAVE_ARM_SCU for example:

	https://lkml.kernel.org/r/20170704131441.GH27842 at localhost

These look reasonable, please send them to the patch system for merging after this merge window, thanks.

These two are now in your patch tracker (since a week).

Thanks,
Johan