Skip to contentSkip to conversation

ARM: dts: aspeed: Add gpio-keys-polled for fan presence

PATCH Superseded Christopher Bostic 2 participants 2 messages Jul 26, 2017 – Jul 27, 2017

Subsystems (2)
Device tree bindings Arm/Aspeed machine support

v5 of 6 Superseded Latest is v6 →

lore
Share & tools
lore

Christopher Bostic

author
#0 lore raw

PATCH v5 1/1 ARM: dts: aspeed: Add gpio-keys-polled for fan presence

Define gpio-keys-polled. Add pca-955x chip IO as GPIO source. Polling period of 1 second determined to be the max acceptable value based on discussions with Brad Bishop and Matt Spinler.

Signed-off-by Christopher Bostic <[email protected]>

---
v5 - Fix gpio-keys-polled driver probe errors. Missing pca955x
gpio cells property and wrong format for poll-interval.
v4 - Add details regarding polling period to commit message. v3 - Remove 'autorepeat'
- Increase polling period to 1 second.
- Remove GPIO specifiers from pca955x in dev tree
v2 - Change 'linux,code' from a unique global value to a local one
for all the gpio-keys-polled devices.

---
 arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 32 ++++++++++++++++++++++++
 1 file changed, 32 insertions(+)
arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts +32 -0
index d964901..22dbb91 100644
@@ -56,6 +56,37 @@
 		};
 	};
 
+	gpio-keys-polled {
+		compatible = "gpio-keys-polled";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		poll-interval = <1000>;
+
+		fan0-presence {
+			label = "fan0-presence";
+			gpios = <&pca0 4 GPIO_ACTIVE_LOW>;
+			linux,code = <4>;
+		};
+
+		fan1-presence {
+			label = "fan1-presence";
+			gpios = <&pca0 5 GPIO_ACTIVE_LOW>;
+			linux,code = <5>;
+		};
+
+		fan2-presence {
+			label = "fan2-presence";
+			gpios = <&pca0 6 GPIO_ACTIVE_LOW>;
+			linux,code = <6>;
+		};
+
+		fan3-presence {
+			label = "fan3-presence";
+			gpios = <&pca0 7 GPIO_ACTIVE_LOW>;
+			linux,code = <7>;
+		};
+	};
+
 	leds {
 		compatible = "gpio-leds";
 

@@ -224,6 +255,7 @@
 		reg = <0x60>;
 		#address-cells = <1>;
 		#size-cells = <0>;
+		#gpio-cells = <2>;
 
 		fan0: led@0 {
 			label = "fan0";
Signature · 1 line
1.8.2.2
maintainer
#1 lore raw
Quoted 5 lines · Christopher Bostic

Define gpio-keys-polled. Add pca-955x chip IO as GPIO source. Polling period of 1 second determined to be the max acceptable value based on discussions with Brad Bishop and Matt Spinler.

Signed-off-by Christopher Bostic <[email protected]>
Quoted 9 lines

---
v5 - Fix gpio-keys-polled driver probe errors. Missing pca955x
gpio cells property and wrong format for poll-interval.
v4 - Add details regarding polling period to commit message. v3 - Remove 'autorepeat'
- Increase polling period to 1 second.
- Remove GPIO specifiers from pca955x in dev tree
v2 - Change 'linux,code' from a unique global value to a local one
for all the gpio-keys-polled devices.

From off-list:

Quoted 6 lines · Christopher Bostic
Quoted 6 lines

Even after these probe fixes something more is needed. I tried a bunch of stuff but I could not get the input subsys device created by gpio-keys to work, for these gpios. I ran strace on my test app here:

https://github.com/bradbishop/gpio-keys

Quoted 8 lines
Quoted 3 lines

and it seems like I’m getting ENOENT back on one of the ioctls. Do you have some
time to dig into this?

I'll have a look at the ioctl issue.

Thanks,
Chris

I will hold off on merging this patch until it has been tested.

Cheers,

Joel