drm/i915: Remove unused i915_err_print_instdone
Subsystems (2)
Tvrtko Ursulin
maintainerPATCH 1/1 drm/i915: Remove unused i915_err_print_instdone
From: Tvrtko Ursulin <[email protected]>
Somewhere, sometime, in some refactoring it seems to have been left behind with no callers.
--- drivers/gpu/drm/i915/i915_irq.c | 26 -------------------------- 1 file changed, 26 deletions(-)
drivers/gpu/drm/i915/i915_irq.c +0 -26
@@ -2640,32 +2640,6 @@ static void i915_reset_device(struct drm_i915_private *dev_priv) KOBJ_CHANGE, reset_done_event); } -static inline void -i915_err_print_instdone (struct drm_i915_private *dev_priv, -struct intel_instdone *instdone) -{ -int slice; -int subslice; - -pr_err (" INSTDONE: 0x%08x\n" , instdone->instdone); - -if (INTEL_GEN (dev_priv) <=3 ) -return ; - -pr_err (" SC_INSTDONE: 0x%08x\n" , instdone->slice_common); - -if (INTEL_GEN (dev_priv) <=6 ) -return ; - -for_each_instdone_slice_subslice (dev_priv, slice, subslice) -pr_err (" SAMPLER_INSTDONE[%d][%d]: 0x%08x\n" , - slice, subslice, instdone->sampler[slice][subslice]); - -for_each_instdone_slice_subslice (dev_priv, slice, subslice) -pr_err (" ROW_INSTDONE[%d][%d]: 0x%08x\n" , - slice, subslice, instdone->row[slice][subslice]); -} -static void i915_clear_error_registers (struct drm_i915_private *dev_priv) {u32 eir;
Signature · 6 lines
2.9.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Tvrtko Ursulin (2017-07-27 09:28:05)
Quoted 4 lines
From: Tvrtko Ursulin <[email protected]>
Somewhere, sometime, in some refactoring it seems to have been left behind with no callers.
commit eaa14c24864ecfc60fb591f3b20747af7c67d446
Author: Chris Wilson <[email protected]> Date: Wed Oct 19 13:52:03 2016 +0100
drm/i915: Stop reporting error details in dmesg as well as the error-state
As we already capture all the information from the registers into the error-state, also dumping that to dmesg just generates noise that upsets CI and users alike (and doesn't provide us with any more information).
Add a citation that killing off pr_err was deliberate.
Quoted 1 line
Signed-off-by Tvrtko Ursulin <[email protected]>
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tvrtko Ursulin
maintainerPATCH v2 1/1 drm/i915: Remove unused i915_err_print_instdone
From: Tvrtko Ursulin <[email protected]>
Just a simple code cleanup, below commit forgot to remove a function which it made unused:
commit eaa14c24864ecfc60fb591f3b20747af7c67d446
Author: Chris Wilson <[email protected]>
Date: Wed Oct 19 13:52:03 2016 +0100
drm/i915: Stop reporting error details in dmesg as well as the error-state
As we already capture all the information from the registers into the error-state, also dumping that to dmesg just generates noise that upsets CI and users alike (and doesn't provide us with any more information).
v2: Chris Wilson dag out the relevant commit. Commit msg updated.
--- drivers/gpu/drm/i915/i915_irq.c | 26 -------------------------- 1 file changed, 26 deletions(-)
drivers/gpu/drm/i915/i915_irq.c +0 -26
@@ -2640,32 +2640,6 @@ static void i915_reset_device(struct drm_i915_private *dev_priv) KOBJ_CHANGE, reset_done_event); } -static inline void -i915_err_print_instdone (struct drm_i915_private *dev_priv, -struct intel_instdone *instdone) -{ -int slice; -int subslice; - -pr_err (" INSTDONE: 0x%08x\n" , instdone->instdone); - -if (INTEL_GEN (dev_priv) <=3 ) -return ; - -pr_err (" SC_INSTDONE: 0x%08x\n" , instdone->slice_common); - -if (INTEL_GEN (dev_priv) <=6 ) -return ; - -for_each_instdone_slice_subslice (dev_priv, slice, subslice) -pr_err (" SAMPLER_INSTDONE[%d][%d]: 0x%08x\n" , - slice, subslice, instdone->sampler[slice][subslice]); - -for_each_instdone_slice_subslice (dev_priv, slice, subslice) -pr_err (" ROW_INSTDONE[%d][%d]: 0x%08x\n" , - slice, subslice, instdone->row[slice][subslice]); -} -static void i915_clear_error_registers (struct drm_i915_private *dev_priv) {u32 eir;
Signature · 6 lines
2.9.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Remove unused i915_err_print_instdone
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Remove unused i915_err_print_instdone
URL : https://patchwork.freedesktop.org/series/27975/
State : success
== Summary ==
Series 27975v1 drm/i915: Remove unused i915_err_print_instdone
https://patchwork.freedesktop.org/api/1.0/series/27975/revisions/1/mbox/
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
fail -> PASS (fi-snb-2600) fdo#100215
Test kms_flip:
Subgroup basic-flip-vs-modeset:
skip -> PASS (fi-skl-x1585l) fdo#101781
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-j1900) fdo#101705fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101781 https://bugs.freedesktop.org/show_bug.cgi?id=101781
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:280 pass:269 dwarn:0 dfail:0 fail:0 skip:11 time:443s fi-blb-e6850 total:280 pass:225 dwarn:1 dfail:0 fail:0 skip:54 time:362s fi-bsw-n3050 total:280 pass:244 dwarn:0 dfail:0 fail:0 skip:36 time:546s fi-bxt-j4205 total:280 pass:261 dwarn:0 dfail:0 fail:0 skip:19 time:515s fi-byt-j1900 total:280 pass:255 dwarn:1 dfail:0 fail:0 skip:24 time:488s fi-byt-n2820 total:280 pass:251 dwarn:1 dfail:0 fail:0 skip:28 time:487s fi-glk-2a total:280 pass:261 dwarn:0 dfail:0 fail:0 skip:19 time:600s fi-hsw-4770 total:280 pass:264 dwarn:0 dfail:0 fail:0 skip:16 time:434s fi-hsw-4770r total:280 pass:264 dwarn:0 dfail:0 fail:0 skip:16 time:417s fi-ilk-650 total:280 pass:230 dwarn:0 dfail:0 fail:0 skip:50 time:427s fi-ivb-3520m total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:496s fi-ivb-3770 total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:474s fi-kbl-7500u total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:469s fi-kbl-7560u total:280 pass:270 dwarn:0 dfail:0 fail:0 skip:10 time:575s fi-kbl-r total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:587s fi-pnv-d510 total:280 pass:223 dwarn:2 dfail:0 fail:0 skip:55 time:568s fi-skl-6260u total:280 pass:270 dwarn:0 dfail:0 fail:0 skip:10 time:462s fi-skl-6700hq total:280 pass:263 dwarn:0 dfail:0 fail:0 skip:17 time:591s fi-skl-6700k total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:470s fi-skl-x1585l total:280 pass:270 dwarn:0 dfail:0 fail:0 skip:10 time:496s fi-snb-2520m total:280 pass:252 dwarn:0 dfail:0 fail:0 skip:28 time:546s fi-snb-2600 total:280 pass:251 dwarn:0 dfail:0 fail:0 skip:29 time:403s
fi-skl-6770hq failed to collect. IGT log at Patchwork_5288/fi-skl-6770hq/igt.log
94853c83714c98a0ade6379eecb4ad06cab04e22 drm-tip: 2017y-07m-27d-08h-06m-43s UTC integration manifest c59db65c71b5 drm/i915: Remove unused i915_err_print_instdone
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5288/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915: Remove unused i915_err_print_instdone (rev2)
In reply to Tvrtko Ursulin== Series Details ==
== Series Details ==
Series: drm/i915: Remove unused i915_err_print_instdone (rev2)
URL : https://patchwork.freedesktop.org/series/27975/
State : success
== Summary ==
Series 27975v2 drm/i915: Remove unused i915_err_print_instdone
https://patchwork.freedesktop.org/api/1.0/series/27975/revisions/2/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
fail -> PASS (fi-snb-2600) fdo#100007
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
pass -> FAIL (fi-snb-2600) fdo#100215fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fi-bdw-5557u total:280 pass:269 dwarn:0 dfail:0 fail:0 skip:11 time:446s fi-bdw-gvtdvm total:280 pass:266 dwarn:0 dfail:0 fail:0 skip:14 time:426s fi-blb-e6850 total:280 pass:225 dwarn:1 dfail:0 fail:0 skip:54 time:352s fi-bsw-n3050 total:280 pass:244 dwarn:0 dfail:0 fail:0 skip:36 time:543s fi-bxt-j4205 total:280 pass:261 dwarn:0 dfail:0 fail:0 skip:19 time:508s fi-byt-j1900 total:280 pass:255 dwarn:1 dfail:0 fail:0 skip:24 time:495s fi-byt-n2820 total:280 pass:251 dwarn:1 dfail:0 fail:0 skip:28 time:490s fi-glk-2a total:280 pass:261 dwarn:0 dfail:0 fail:0 skip:19 time:602s fi-hsw-4770 total:280 pass:264 dwarn:0 dfail:0 fail:0 skip:16 time:438s fi-hsw-4770r total:280 pass:264 dwarn:0 dfail:0 fail:0 skip:16 time:419s fi-ilk-650 total:280 pass:230 dwarn:0 dfail:0 fail:0 skip:50 time:417s fi-ivb-3520m total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:507s fi-ivb-3770 total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:475s fi-kbl-7500u total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:468s fi-kbl-7560u total:280 pass:270 dwarn:0 dfail:0 fail:0 skip:10 time:573s fi-kbl-r total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:583s fi-pnv-d510 total:280 pass:224 dwarn:1 dfail:0 fail:0 skip:55 time:564s fi-skl-6260u total:280 pass:270 dwarn:0 dfail:0 fail:0 skip:10 time:465s fi-skl-6700hq total:280 pass:263 dwarn:0 dfail:0 fail:0 skip:17 time:588s fi-skl-6700k total:280 pass:262 dwarn:0 dfail:0 fail:0 skip:18 time:471s fi-skl-6770hq total:280 pass:270 dwarn:0 dfail:0 fail:0 skip:10 time:477s fi-skl-gvtdvm total:280 pass:267 dwarn:0 dfail:0 fail:0 skip:13 time:439s fi-skl-x1585l total:280 pass:269 dwarn:0 dfail:0 fail:0 skip:11 time:479s fi-snb-2520m total:280 pass:252 dwarn:0 dfail:0 fail:0 skip:28 time:548s fi-snb-2600 total:280 pass:250 dwarn:0 dfail:0 fail:1 skip:29 time:404s
19cffbf93fc4a65b459f6818f733f801a03e91ed drm-tip: 2017y-07m-27d-10h-52m-14s UTC integration manifest 192951ef7776 drm/i915: Remove unused i915_err_print_instdone
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5290/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx