Skip to contentSkip to conversation

efi_loader: add some missing breaks

PATCH Applied Rob Clark 3 participants 3 messages Jul 27, 2017 – Jul 28, 2017

lore
Share & tools
lore

Rob Clark

author
#0 lore raw

PATCH 1/1 efi_loader: add some missing breaks

Signed-off-by Rob Clark <[email protected]>

---
Just noticed that there didn't seem to be quite enough break's. Pretty sure the intention wasn't to fall-thru

 lib/efi_loader/efi_device_path_to_text.c | 2 ++
 1 file changed, 2 insertions(+)
lib/efi_loader/efi_device_path_to_text.c +2 -0
index 612e380617..4b2f43f0c8 100644
@@ -52,6 +52,7 @@ static uint16_t *efi_convert_device_node_to_text(
 			break;
 			}
 		}
+		break;
 	case DEVICE_PATH_TYPE_MEDIA_DEVICE:
 		switch (device_node->sub_type) {
 		case DEVICE_PATH_SUB_TYPE_FILE_PATH:

@@ -63,6 +64,7 @@ static uint16_t *efi_convert_device_node_to_text(
 			memcpy(buffer, device_node->data, buffer_size);
 			break;
 		}
+		break;
 	}
 
 	/*
Signature · 1 line
2.13.0
#1 lore raw

PATCH 1/1 efi_loader: add some missing breaks

Quoted 22 lines · Rob Clark
Signed-off-by Rob Clark <[email protected]>

---
Just noticed that there didn't seem to be quite enough break's. Pretty sure the intention wasn't to fall-thru

 lib/efi_loader/efi_device_path_to_text.c | 2 ++
 1 file changed, 2 insertions(+)
lib/efi_loader/efi_device_path_to_text.c +1 -0
index 612e380617..4b2f43f0c8 100644
@@ -52,6 +52,7 @@ static uint16_t *efi_convert_device_node_to_text(
 			break;
 			}
 		}
+		break;
 	case DEVICE_PATH_TYPE_MEDIA_DEVICE:
 		switch (device_node->sub_type) {
 		case DEVICE_PATH_SUB_TYPE_FILE_PATH:

lib/efi_loader/efi_device_path_to_text.c static uint16_t *efi_convert_device_node_to_text( · line 70

Quoted 7 lines
lib/efi_loader/efi_device_path_to_text.c +1 -0
@@ -63,6 +64,7 @@ static uint16_t *efi_convert_device_node_to_text(
 			memcpy(buffer, device_node->data, buffer_size);
 			break;
 		}
+		break;
 	}
 
 	/*

Thank you for catching this.

Reviewed-by Heinrich Schuchardt <[email protected]>