Skip to contentSkip to conversation

generic/441: whitelist gfs2 for full test

PATCH Superseded Jeff Layton 2 participants 4 messages Jul 28, 2017 – Sep 14, 2017

lore
Share & tools
lore

Jeff Layton

author
#0 lore raw

PATCH 1/1 generic/441: whitelist gfs2 for full test

From: Jeff Layton <[email protected]>

gfs2 passes the full-scale generic/441 test with the patch that converts it to use errseq_t reporting for fsync.

Signed-off-by Jeff Layton <[email protected]>
---
 tests/generic/441 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/441 +1 -1
index 075d87723ca1..b98f709cb6eb 100755
@@ -55,7 +55,7 @@ case $FSTYP in
 	btrfs)
 		_notrun "btrfs has a specialized test for this"
 		;;
-	ext3|ext4|xfs)
+	ext3|ext4|gfs2|xfs)
 		# Do the more thorough test if we have a logdev
 		_has_logdev && sflag=''
 		;;
Signature · 1 line
2.13.3
#1 lore raw

PATCH 1/1 generic/441: whitelist gfs2 for full test

Quoted 15 lines · Jeff Layton

From: Jeff Layton <[email protected]>

gfs2 passes the full-scale generic/441 test with the patch that converts it to use errseq_t reporting for fsync.

Signed-off-by Jeff Layton <[email protected]>
---
 tests/generic/441 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/441 +0 -0
index 075d87723ca1..b98f709cb6eb 100755

tests/generic/441 case $FSTYP in · line 58

Quoted 5 lines
tests/generic/441 +1 -1
@@ -55,7 +55,7 @@ case $FSTYP in
 	btrfs)
 		_notrun "btrfs has a specialized test for this"
 		;;
-	ext3|ext4|xfs)
+	ext3|ext4|gfs2|xfs)

gfs2 has no external log device support yet in _scratch_mkfs, so if test still passes with patched gfs2 in this case, I think we can test gfs2 in full-scale mode unconditionally? e.g.

	ext3|ext4|xfs)
 		# Do the more thorough test if we have a logdev
 		_has_logdev && sflag=''
 		;;
	gfs2)
		# <comments here>
		sflag=''
		;;
	*)
		;;

Thanks,
Eryu

author
#2 lore raw

PATCH RESEND 1/1 generic/441: whitelist gfs2 for full test

In reply to Jeff Layton

From: Jeff Layton <[email protected]>

gfs2 passes the full-scale generic/441 test with the patch that converts it to use errseq_t reporting for fsync.

Signed-off-by Jeff Layton <[email protected]>
---
 tests/generic/441 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/441 +1 -1
index 075d87723ca1..b98f709cb6eb 100755
@@ -55,7 +55,7 @@ case $FSTYP in
 	btrfs)
 		_notrun "btrfs has a specialized test for this"
 		;;
-	ext3|ext4|xfs)
+	ext3|ext4|gfs2|xfs)
 		# Do the more thorough test if we have a logdev
 		_has_logdev && sflag=''
 		;;
Signature · 1 line
2.13.5
#3 lore raw

PATCH RESEND 1/1 generic/441: whitelist gfs2 for full test

Hi Jeff,

Quoted 15 lines · Jeff Layton

From: Jeff Layton <[email protected]>

gfs2 passes the full-scale generic/441 test with the patch that converts it to use errseq_t reporting for fsync.

Signed-off-by Jeff Layton <[email protected]>
---
 tests/generic/441 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/generic/441 +0 -0
index 075d87723ca1..b98f709cb6eb 100755

tests/generic/441 case $FSTYP in · line 58

Quoted 5 lines
tests/generic/441 +1 -1
@@ -55,7 +55,7 @@ case $FSTYP in
 	btrfs)
 		_notrun "btrfs has a specialized test for this"
 		;;
-	ext3|ext4|xfs)
+	ext3|ext4|gfs2|xfs)

Seems you missed my previous reply to this patch on July 31st, or my reply didn't hit the list at all..

Anyway, gfs2 has no external log device support yet in _scratch_mkfs, gfs2 was created with internal log even _has_logdev returned true. So if test still passes with patched gfs2 in this case, I think we can test gfs2 in full-scale mode unconditionally? e.g.

	ext3|ext4|xfs)
		# Do the more thorough test if we have a logdev
		_has_logdev && sflag=''
		;;
	gfs2)
		# <comments here>
		sflag=''
		;;
	*)
		;;

But I pulled & built the latest Linus tree (which contains commit d07a6ac7b6f8 ("gfs2: convert to errseq_t based writeback error reporting for fsync")), and generic/441 still fails on gfs2 in the full-scale test setup, and this doesn't match the commit log. Are there any additional fixes required? Or did I miss anything?

root/workspace/xfstests/results//gfs2/generic/441.out.bad 2017-09-14 13:03:57.280000000 +0800 renamed from generic/441.out 2017-09-05 13:14:52.768000000 +0800 +1 -1
@@ -1,3 +1,3 @@
 QA output created by 441
 Format and mount
-Test passed!
+Third fsync on fd[0] failed: Input/output error

Thanks,
Eryu

Quoted 10 lines
tests/generic/441 +0 -0
 		# Do the more thorough test if we have a logdev
 		_has_logdev && sflag=''
 		;;
Signature · 6 lines
2.13.5

--
To unsubscribe from this list: send the line "unsubscribe fstests" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html