Skip to contentSkip to conversation

staging: vboxvideo: select CONFIG_GENERIC_ALLOCATOR

PATCH In review Arnd Bergmann 2 participants 2 messages Jul 28, 2017 – Jul 29, 2017 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: vboxvideo: select CONFIG_GENERIC_ALLOCATOR

vboxvideo fails to link without genalloc:

drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_alloc':
vbox_hgsmi.c:(.text+0x1e): undefined reference to gen_pool_dma_alloc' drivers/staging/vboxvideo/vbox_hgsmi.o: In function hgsmi_buffer_free':
vbox_hgsmi.c:(.text+0xf2): undefined reference to `gen_pool_free'

This adds a Kconfig select statement, mirroring what all the other users have.

Fixes dd55d44f4084 ("staging: vboxvideo: Add vboxvideo to drivers/staging")
---
 drivers/staging/vboxvideo/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/vboxvideo/Kconfig +1 -0
index a52746f9a670..cfabe3ce4bab 100644
@@ -2,6 +2,7 @@ config DRM_VBOXVIDEO
 	tristate "Virtual Box Graphics Card"
 	depends on DRM && X86 && PCI
 	select DRM_KMS_HELPER
+	select GENERIC_ALLOCATOR
 	help
 	  This is a KMS driver for the virtual Graphics Card used in
 	  Virtual Box virtual machines.
Signature · 1 line
2.9.0
#1 lore raw
Quoted 7 lines · Arnd Bergmann

vboxvideo fails to link without genalloc:

drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_alloc':
vbox_hgsmi.c:(.text+0x1e): undefined reference to gen_pool_dma_alloc' drivers/staging/vboxvideo/vbox_hgsmi.o: In function hgsmi_buffer_free':
vbox_hgsmi.c:(.text+0xf2): undefined reference to `gen_pool_free'

Quoted 8 lines

This adds a Kconfig select statement, mirroring what all the other users have.

Fixes dd55d44f4084 ("staging: vboxvideo: Add vboxvideo to drivers/staging")
---
 drivers/staging/vboxvideo/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Hans sent this same patch 2 days ago, sorry, just applied it now.

greg k-h