Skip to contentSkip to conversation

package_manager: Fix support for NO_RECOMMENDATONS

PATCH Superseded Richard Röjfors 2 participants 2 messages Jul 30, 2017

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package_manager: Fix support for NO_RECOMMENDATONS

When support for dnf was introduced the check of the no NO_RECOMMENDATIONS variable got broken.

This fixes the issue by compairing to the string "1" rather than the number 1.

---

meta/lib/oe/package_manager.py +0 -0
index 72503eb9d3..518cf8dbe3 100644
@@ -585,7 +585,7 @@ class RpmPM(PackageManager):


         output = self._invoke_dnf((["--skip-broken"] if attempt_only else []) +
                          (["-x", ",".join(exclude_pkgs)] if len(exclude_pkgs) > 0 else []) +
-                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == 1 else []) + +                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == "1" else []) + (["--nogpgcheck"] if self.d.getVar('RPM_SIGN_PACKAGES') != '1' else ["--setopt=gpgcheck=True"]) + ["install"] +
                          pkgs)

#1 lore raw

✗ patchtest: failure for package_manager: Fix support for NO_RECOMMENDATONS

== Series Details ==

Series: package_manager: Fix support for NO_RECOMMENDATONS
Revision: 1
URL : https://patchwork.openembedded.org/series/8021/
State : failure

== Summary ==

Thank you for submitting this patch series to OpenEmbedded Core. This is an automated response. Several tests have been executed on the proposed series by patchtest resulting in the following failures:

* Issue Series cannot be parsed correctly due to malformed diff lines [test_mbox_format]
Suggested fix Create the series again using git-format-patch and ensure it can be applied using git am
Diff line

* Issue Series does not apply on top of target branch [test_series_merge_on_head]
Suggested fix Rebase your series on top of targeted branch
Targeted branch master (currently at a2ab288bd0)

If you believe any of these test results are incorrect, please reply to the mailing list ([email protected]) raising your concerns. Otherwise we would appreciate you correcting the issues and submitting a new version of the patchset if applicable. Please ensure you add/increment the version number when sending the new version (i.e. [PATCH] -> [PATCH v2] -> [PATCH v3] -> ...).

---

Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe