pinctrl-st: fix of_irq_to_resource() result check
Subsystems (3)
PATCH 1/1 pinctrl-st: fix of_irq_to_resource() result check
of_irq_to_resource() has recently been fixed to return negative error #'s along with 0 in case of failure, however the ST driver still only regards 0 as failure indication -- fix it up.
--- drivers/pinctrl/pinctrl-st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pinctrl/pinctrl-st.c +1 -1
@@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(stru* [irqN]----> [gpio-bank (n)] */ -if (of_irq_to_resource (np,0 , &irq_res)) { +if (of_irq_to_resource (np,0 , &irq_res) >0 ) { gpio_irq = irq_res.start;gpiochip_set_chained_irqchip (&bank->gpio_chip, &st_gpio_irqchip, gpio_irq, st_gpio_irq_handler);
PATCH 1/1 pinctrl-st: fix of_irq_to_resource() result check
Quoted 6 lines · Sergei Shtylyov
of_irq_to_resource()has recently been fixed to return negative error #'s along with 0 in case of failure, however the ST driver still only regards 0 as failure indication -- fix it up.Fixes 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")Signed-off-by Sergei Shtylyov <[email protected]>
[...]
Forgot to mention that the patch is against the 'fixes' branch of Linus
W.'s 'linux-pinctrl.git' repo.
MBR, Sergei
PATCH 1/1 pinctrl-st: fix of_irq_to_resource() result check
In reply to Sergei ShtylyovQuoted 16 lines · Sergei Shtylyov
of_irq_to_resource()has recently been fixed to return negative error #'s along with 0 in case of failure, however the ST driver still only regards 0 as failure indication -- fix it up.Fixes 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")Signed-off-by Sergei Shtylyov <[email protected]>--- drivers/pinctrl/pinctrl-st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Index:
linux-pinctrl/drivers/pinctrl/pinctrl-st.c
===================================================================
drivers/pinctrl/pinctrl-st.c static int st_gpiolib_register_bank(stru · line 1527
Quoted 8 lines
drivers/pinctrl/pinctrl-st.c +1
-1@@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(stru* [irqN]----> [gpio-bank (n)] */ -if (of_irq_to_resource (np,0 , &irq_res)) { +if (of_irq_to_resource (np,0 , &irq_res) >0 ) { gpio_irq = irq_res.start;gpiochip_set_chained_irqchip (&bank->gpio_chip, &st_gpio_irqchip, gpio_irq, st_gpio_irq_handler);
While at it, maybe turn this into of_irq_get() since you only need the interrupt number in the first place?
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170731/5617fad3/attachment.sig>
PATCH 1/1 pinctrl-st: fix of_irq_to_resource() result check
Hello!
Quoted 19 lines · Thierry Reding
Quoted 19 lines
of_irq_to_resource()has recently been fixed to return negative error #'s along with 0 in case of failure, however the ST driver still only regards 0 as failure indication -- fix it up.Fixes 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")Signed-off-by Sergei Shtylyov <[email protected]>--- drivers/pinctrl/pinctrl-st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Index:
linux-pinctrl/drivers/pinctrl/pinctrl-st.c
===================================================================drivers/pinctrl/pinctrl-st.c +0
-0@@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(stru* [irqN]----> [gpio-bank (n)] */
Quoted 8 lines
drivers/pinctrl/pinctrl-st.c static int st_gpiolib_register_bank(stru · line 1527
Quoted 5 lines
drivers/pinctrl/pinctrl-st.c +1
-1-if (of_irq_to_resource (np,0 , &irq_res)) { +if (of_irq_to_resource (np,0 , &irq_res) >0 ) { gpio_irq = irq_res.start;gpiochip_set_chained_irqchip (&bank->gpio_chip, &st_gpio_irqchip, gpio_irq, st_gpio_irq_handler);While at it, maybe turn this into
of_irq_get()since you only need the interrupt number in the first place?
Yeah, noticed that too. Will look into this (if I won't forget).
Quoted 1 line
Thierry
MBR, Sergei
PATCH 1/1 pinctrl-st: fix of_irq_to_resource() result check
In reply to Sergei ShtylyovQuoted 6 lines · Sergei Shtylyov
of_irq_to_resource()has recently been fixed to return negative error #'s along with 0 in case of failure, however the ST driver still only regards 0 as failure indication -- fix it up.Fixes 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")Signed-off-by Sergei Shtylyov <[email protected]>
Patch applied.
Yours,
Linus Walleij
PATCH 1/1 pinctrl-st: fix of_irq_to_resource() result check
Quoted 8 lines · Linus Walleij
Quoted 6 lines
of_irq_to_resource()has recently been fixed to return negative error #'s along with 0 in case of failure, however the ST driver still only regards 0 as failure indication -- fix it up.Fixes 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()")Signed-off-by Sergei Shtylyov <[email protected]>Patch applied.
Again, not seeing it...
Quoted 2 lines
Yours,
Linus Walleij
MBR, Sergei