Fix ib_addr_lo in BUFFER_CIK/BUFFER_CONST PM4 packets
PATCH 1/1 Fix ib_addr_lo in BUFFER_CIK/BUFFER_CONST PM4 packets
We correctly grabbed the bits but did not shift them back to their correct place.
Signed-off-by Tom St Denis <[email protected]>
--- src/lib/ring_decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
src/lib/ring_decode.c +1 -1
@@ -407,7 +407,7 @@ static void print_decode_pm4_pkt3(struct umr_asic *asic, struct umr_ring_decodercase 0x33 :// INDIRECT_BUFFER_CONST switch (decoder->pm4.cur_word) {case 0 :printf ("IB_BASE_LO: 0x%08lx, SWAP:%lu" ,BITS (ib,2 ,32 ),BITS (ib,0 ,2 )); - decoder->pm4.next_ib_state.ib_addr_lo =BITS (ib,2 ,32 ); + decoder->pm4.next_ib_state.ib_addr_lo =BITS (ib,2 ,32 ) <<2 ;break ;case 1 :printf ("IB_BASE_HI: 0x%08lx" ,BITS (ib,0 ,16 )); decoder->pm4.next_ib_state.ib_addr_hi =BITS (ib,0 ,16 );
Signature · 6 lines
2.12.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Huang Rui
Tested-byQuoted 4 lines · Tom St Denis
We correctly grabbed the bits but did not shift them back to their correct place.
Signed-off-by Tom St Denis <[email protected]>
Tested-by Huang Rui <[email protected]>
Quoted 24 lines
--- src/lib/ring_decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)src/lib/ring_decode.c +1
-1@@ -407,7 +407,7 @@ static void print_decode_pm4_pkt3(struct umr_asic *asic, struct umr_ring_decodercase 0x33 :// INDIRECT_BUFFER_CONST switch (decoder->pm4.cur_word) {case 0 :printf ("IB_BASE_LO: 0x%08lx, SWAP:%lu" ,BITS (ib,2 ,32 ),BITS (ib,0 ,2 )); - decoder->pm4.next_ib_state.ib_addr_lo =BITS (ib,2 ,32 ); + decoder->pm4.next_ib_state.ib_addr_lo =BITS (ib,2 ,32 ) <<2 ;break ;case 1 :printf ("IB_BASE_HI: 0x%08lx" ,BITS (ib,0 ,16 )); decoder->pm4.next_ib_state.ib_addr_hi =BITS (ib,0 ,16 );Signature · 6 lines
2.12.0 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx