Skip to contentSkip to conversation

test_kmod: fix kmod.sh by making it executable

PATCH In review Luis R. Rodriguez 2 participants 4 messages Aug 3, 2017 – Aug 7, 2017

Subsystems (3)
lore
Share & tools
lore

Luis R. Rodriguez

author maintainer
#0 lore raw

PATCH 1/2 test_kmod: fix kmod.sh by making it executable

We had just forgotten to do this. Without this if we run the following we get a permission denied:

sudo make -C tools/testing/selftests/kmod/ run_tests
make: Entering directory '/home/mcgrof/linux-next/tools/testing/selftests/kmod' /bin/sh: ./kmod.sh: Permission denied
selftests: kmod.sh [FAIL] /home/mcgrof/linux-next/tools/testing/selftests/kmod
make: Leaving directory '/home/mcgrof/linux-next/tools/testing/selftests/kmod

Fixes 39258f448d71 ("kmod: add test driver to stress test the module loader")
---
 tools/testing/selftests/kmod/kmod.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/kmod/kmod.sh
tools/testing/selftests/kmod/kmod.sh +0 -0
old mode 100644
new mode 100755
Signature · 1 line
2.11.0
author maintainer
#1 lore raw

PATCH 2/2 test_sysctl: fix sysctl.sh by making it executable

We had just forogtten to do this. Without this the following test fails:

$ sudo make -C tools/testing/selftests/sysctl/ run_tests
make: Entering directory '/home/mcgrof/linux-next/tools/testing/selftests/sysctl'
/bin/sh: ./sysctl.sh: Permission denied
selftests:  sysctl.sh [FAIL]
/home/mcgrof/linux-next/tools/testing/selftests/sysctl
make: Leaving directory '/home/mcgrof/linux-next/tools/testing/selftests/sysctl'
Fixes 64b671204afd71 ("test_sysctl: add generic script to expand on tests")
---
 tools/testing/selftests/sysctl/sysctl.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/sysctl/sysctl.sh
tools/testing/selftests/sysctl/sysctl.sh +0 -0
old mode 100644
new mode 100755
Signature · 1 line
2.11.0
maintainer
#2 lore raw

Re: [PATCH 2/2] test_sysctl: fix sysctl.sh by making it executable

tools/testing/selftests/sysctl/sysctl.sh

Quoted 20 lines · Luis R. Rodriguez

We had just forogtten to do this. Without this the following test fails:

$ sudo make -C tools/testing/selftests/sysctl/ run_tests
make: Entering directory '/home/mcgrof/linux-next/tools/testing/selftests/sysctl'
/bin/sh: ./sysctl.sh: Permission denied
selftests:  sysctl.sh [FAIL]
/home/mcgrof/linux-next/tools/testing/selftests/sysctl
make: Leaving directory '/home/mcgrof/linux-next/tools/testing/selftests/sysctl'
Fixes 64b671204afd71 ("test_sysctl: add generic script to expand on tests")
---
 tools/testing/selftests/sysctl/sysctl.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/sysctl/sysctl.sh
tools/testing/selftests/sysctl/sysctl.sh +0 -0
old mode 100644
new mode 100755

Thanks. Applied to linux-kselftest fixes for 4.13-final.

thanks,
-- Shuah

maintainer
#3 lore raw
In reply to Luis R. Rodriguez

tools/testing/selftests/kmod/kmod.sh

Quoted 21 lines · Luis R. Rodriguez

We had just forgotten to do this. Without this if we run the following we get a permission denied:

sudo make -C tools/testing/selftests/kmod/ run_tests
make: Entering directory '/home/mcgrof/linux-next/tools/testing/selftests/kmod' /bin/sh: ./kmod.sh: Permission denied
selftests: kmod.sh [FAIL] /home/mcgrof/linux-next/tools/testing/selftests/kmod
make: Leaving directory '/home/mcgrof/linux-next/tools/testing/selftests/kmod

Fixes 39258f448d71 ("kmod: add test driver to stress test the module loader")
---
 tools/testing/selftests/kmod/kmod.sh | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 mode change 100644 => 100755 tools/testing/selftests/kmod/kmod.sh
tools/testing/selftests/kmod/kmod.sh +0 -0
old mode 100644
new mode 100755

Thanks. Applied to linux-kselftest fixes for 4.13-final

thanks,
-- Shuah