Skip to contentSkip to conversation

package/qt5/qt5base: examples depend on OpenGL

PATCH New Bernd Kuhls 2 participants 3 messages Aug 7, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/qt5/qt5base: examples depend on OpenGL

Fixes
http://autobuild.buildroot.net/results/001/001bc930014fca8c2a8b7a390350b4e1a15fa375/

---
 package/qt5/qt5base/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/qt5/qt5base/Config.in +4 -0
index f5de27228..f0138a10f 100644
@@ -44,11 +44,15 @@ config BR2_PACKAGE_QT5BASE_CONFIG_FILE
 
 config BR2_PACKAGE_QT5BASE_EXAMPLES
 	bool "Compile and install examples (with code)"
+	depends on BR2_PACKAGE_QT5_GL_AVAILABLE
 	select BR2_PACKAGE_QT5BASE_NETWORK
 	select BR2_PACKAGE_QT5BASE_XML
 	help
 	  If unsure, say N.
 
+comment "Examples need an OpenGL-capable backend"
+	depends on !BR2_PACKAGE_QT5_GL_AVAILABLE
+
 config BR2_PACKAGE_QT5BASE_NETWORK
 	def_bool y
 
Signature · 1 line
2.11.0
#1 lore raw

PATCH 1/1 package/qt5/qt5base: examples depend on OpenGL

Hello Bernd,

Quoted 13 lines · Bernd Kuhls

Fixes
http://autobuild.buildroot.net/results/001/001bc930014fca8c2a8b7a390350b4e1a15fa375/

---
 package/qt5/qt5base/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/qt5/qt5base/Config.in +0 -0
index f5de27228..f0138a10f 100644

package/qt5/qt5base/Config.in config BR2_PACKAGE_QT5BASE_CONFIG_FILE · line 47

Quoted 4 lines
package/qt5/qt5base/Config.in +1 -0
@@ -44,11 +44,15 @@ config BR2_PACKAGE_QT5BASE_CONFIG_FILE
 
 config BR2_PACKAGE_QT5BASE_EXAMPLES
 	bool "Compile and install examples (with code)"
+	depends on BR2_PACKAGE_QT5_GL_AVAILABLE

Did not (yet) look at the details, but disabling all examples (mind that all sub modules use BR2_PACKAGE_QT5BASE_EXAMPLES) because of one failing one seems a bit over-reacted....better solution would be to disable only the failing one, see e.g. package/qt5/qt5declarative/0002-examples-qquickviewcomparison-and-quickwidget-needs-.patch

Regards,
Peter

Quoted 11 lines
package/qt5/qt5base/Config.in +3 -0
 	select BR2_PACKAGE_QT5BASE_NETWORK
 	select BR2_PACKAGE_QT5BASE_XML
 	help
 	  If unsure, say N.
 
+comment "Examples need an OpenGL-capable backend"
+	depends on !BR2_PACKAGE_QT5_GL_AVAILABLE
+
 config BR2_PACKAGE_QT5BASE_NETWORK
 	def_bool y
 
#2 lore raw

PATCH 1/1 package/qt5/qt5base: examples depend on OpenGL

Hello Bernd,

Quoted 18 lines · Peter Seiderer

Hello Bernd,

Quoted 14 lines · Bernd Kuhls

Fixes
http://autobuild.buildroot.net/results/001/001bc930014fca8c2a8b7a390350b4e1a15fa375/

---
 package/qt5/qt5base/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/qt5/qt5base/Config.in +0 -0
index f5de27228..f0138a10f 100644
@@ -44,11 +44,15 @@ config BR2_PACKAGE_QT5BASE_CONFIG_FILE
 
Quoted 9 lines

package/qt5/qt5base/Config.in config BR2_PACKAGE_QT5BASE_CONFIG_FILE · line 47

Quoted 3 lines
package/qt5/qt5base/Config.in +1 -0
 config BR2_PACKAGE_QT5BASE_EXAMPLES
 	bool "Compile and install examples (with code)"
+	depends on BR2_PACKAGE_QT5_GL_AVAILABLE

Did not (yet) look at the details, but disabling all examples (mind that all sub modules use BR2_PACKAGE_QT5BASE_EXAMPLES) because of one failing one seems a bit over-reacted....better solution would be to disable only the failing one, see e.g. package/qt5/qt5declarative/0002-examples-qquickviewcomparison-and-quickwidget-needs-.patch

Alternative patch submitted, see [1]...

Regards,
Peter

[1] https://patchwork.ozlabs.org/patch/798899

Quoted 15 lines

Regards,
Peter

Quoted 11 lines
package/qt5/qt5base/Config.in +3 -0
 	select BR2_PACKAGE_QT5BASE_NETWORK
 	select BR2_PACKAGE_QT5BASE_XML
 	help
 	  If unsure, say N.
 
+comment "Examples need an OpenGL-capable backend"
+	depends on !BR2_PACKAGE_QT5_GL_AVAILABLE
+
 config BR2_PACKAGE_QT5BASE_NETWORK
 	def_bool y