linux-next 2017-08-08 failure on Nokia N900

DISCUSSION Pavel Machek 4 participants 10 messages Aug 8, 2017 – Aug 10, 2017

Subsystems (2)

Multifunction devices (MFD) OMAP2+ support

lore

Share & tools

lore

Pavel Machek

author

2017-08-08 10:17 UTC #0 lore raw

Hi!

I tried today's linux-next. It boots on n900 (up to X), but then my screen locks and I can't get back. Touchscreen worked, so my guess is keyboard does not...? Ssh connection over usb still works.

Best regards,
Pavel

Signature · 9 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170808/87b79610/attachment.sig>

Pavel Machek

author

2017-08-08 10:34 UTC #1 lore raw

Hi!

Quoted 3 lines

I tried today's linux-next. It boots on n900 (up to X), but then my screen locks and I can't get back. Touchscreen worked, so my guess is keyboard does not...? Ssh connection over usb still works.

Confirmed, its the keyboard.

Additionally, battery monitoring fails, because neither

/sys/class/power_supply/{n900-,rx51-}battery/voltage_now

exists.
Pavel

Signature · 9 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170808/fdec8f57/attachment.sig>

Pavel Machek

author

2017-08-08 11:12 UTC #2 lore raw

Re: linux-next 2017-08-08 keyboard failure on Nokia N900

Hi!

Quoted 11 lines

Quoted 3 lines
I tried today's linux-next. It boots on n900 (up to X), but then my screen locks and I can't get back. Touchscreen worked, so my guess is keyboard does not...? Ssh connection over usb still works.
Confirmed, its the keyboard.
Additionally, battery monitoring fails, because neither
/sys/class/power_supply/{n900-,rx51-}battery/voltage_now
exists.

And dmesg is helpful in this case:

[    0.675201] input: twl4030_pwrbutton as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:pwrbutton/input/input1
[    0.676635] input: TWL4030 Keypad as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:keypad/input/input2
[    0.679138] twl4030_keypad 48070000.i2c:twl at 48:keypad: request_irq
failed for irq no=156: -13
[    0.679779] twl4030_keypad: probe of 48070000.i2c:twl at 48:keypad
failed with error -13
[    0.682769] twl4030_madc 48070000.i2c:twl at 48:madc: could not
request irq
[    0.684051] twl4030_madc: probe of 48070000.i2c:twl at 48:madc failed
with error -13
[    0.685852] input: twl4030:vibrator as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:audio/twl4030-vibra/input/input3
[    0.768890] omap_i2c 48070000.i2c: bus 1 rev3.3 at 2200 kHz

Pavel

Signature · 9 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170808/8265f7f0/attachment.sig>

Grygorii Strashko

2017-08-08 19:59 UTC #3 lore raw

Re: linux-next 2017-08-08 keyboard failure on Nokia N900

Quoted 16 lines · Pavel Machek

Hi!
Quoted 11 lines
Quoted 3 lines
I tried today's linux-next. It boots on n900 (up to X), but then my screen locks and I can't get back. Touchscreen worked, so my guess is keyboard does not...? Ssh connection over usb still works.
Confirmed, its the keyboard.
Additionally, battery monitoring fails, because neither
/sys/class/power_supply/{n900-,rx51-}battery/voltage_now
exists.
And dmesg is helpful in this case:

Quoted 16 lines

[    0.675201] input: twl4030_pwrbutton as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:pwrbutton/input/input1
[    0.676635] input: TWL4030 Keypad as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:keypad/input/input2
[    0.679138] twl4030_keypad 48070000.i2c:twl at 48:keypad: request_irq
failed for irq no=156: -13
[    0.679779] twl4030_keypad: probe of 48070000.i2c:twl at 48:keypad
failed with error -13
[    0.682769] twl4030_madc 48070000.i2c:twl at 48:madc: could not
request irq
[    0.684051] twl4030_madc: probe of 48070000.i2c:twl at 48:madc failed
with error -13
[    0.685852] input: twl4030:vibrator as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:audio/twl4030-vibra/input/input3
[    0.768890] omap_i2c 48070000.i2c: bus 1 rev3.3 at 2200 kHz

I've not precisely checked it, but smth is telling me that below patch can cause this:

commit 78daaca78ee57dead0f4aa5ee399f0499e81cd9e

Author: Julia Lawall <[email protected]>
Date:   Thu May 4 22:10:50 2017 +0200

mfd: twl4030-irq: Drop unnecessary static

Drop static on a local variable, when the variable is initialized before any use, on every possible execution path through the function.

drivers/mfd/twl4030-irq.c +1 -1

@@ -685,7 +685,7 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base)
 
 int twl4030_init_irq(struct device *dev, int irq_num)
 {
-       static struct irq_chip  twl4030_irq_chip;
+       struct irq_chip twl4030_irq_chip;

but if we will look at code - it can be seen that this variable is passed by reference to irq_set_chip_and_handler().
Ops. And what will happen when twl4030_init_irq() returns ;)

Signature · 2 lines

regards,
-grygorii

Julia Lawall

2017-08-08 20:09 UTC #4 lore raw

Re: linux-next 2017-08-08 keyboard failure on Nokia N900

Quoted 58 lines · Grygorii Strashko

Quoted 16 lines · Pavel Machek
Hi!
Quoted 11 lines
Quoted 3 lines
I tried today's linux-next. It boots on n900 (up to X), but then my screen locks and I can't get back. Touchscreen worked, so my guess is keyboard does not...? Ssh connection over usb still works.
Confirmed, its the keyboard.
Additionally, battery monitoring fails, because neither
/sys/class/power_supply/{n900-,rx51-}battery/voltage_now
exists.
And dmesg is helpful in this case:
Quoted 16 lines
[    0.675201] input: twl4030_pwrbutton as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:pwrbutton/input/input1
[    0.676635] input: TWL4030 Keypad as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:keypad/input/input2
[    0.679138] twl4030_keypad 48070000.i2c:twl at 48:keypad: request_irq
failed for irq no=156: -13
[    0.679779] twl4030_keypad: probe of 48070000.i2c:twl at 48:keypad
failed with error -13
[    0.682769] twl4030_madc 48070000.i2c:twl at 48:madc: could not
request irq
[    0.684051] twl4030_madc: probe of 48070000.i2c:twl at 48:madc failed
with error -13
[    0.685852] input: twl4030:vibrator as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:audio/twl4030-vibra/input/input3
[    0.768890] omap_i2c 48070000.i2c: bus 1 rev3.3 at 2200 kHz
I've not precisely checked it, but smth is telling me that below patch can cause this:
commit 78daaca78ee57dead0f4aa5ee399f0499e81cd9e
Author: Julia Lawall <[email protected]>
Date:   Thu May 4 22:10:50 2017 +0200
mfd: twl4030-irq: Drop unnecessary static
Drop static on a local variable, when the variable is initialized before any use, on every possible execution path through the function.
drivers/mfd/twl4030-irq.c +1 -1
@@ -685,7 +685,7 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base)
 
 int twl4030_init_irq(struct device *dev, int irq_num)
 {
-       static struct irq_chip  twl4030_irq_chip;
+       struct irq_chip twl4030_irq_chip;
 
 

Quoted 3 lines

but if we will look at code - it can be seen that this variable is passed by reference to irq_set_chip_and_handler().
Ops. And what will happen when twl4030_init_irq() returns ;)

The patch is not correct as was already noted when it was submitted:

https://lkml.org/lkml/2017/7/15/169
https://lkml.org/lkml/2017/7/15/171

Do you need a patch reverting this one?

julia

Grygorii Strashko

2017-08-08 20:15 UTC #5 lore raw

Re: linux-next 2017-08-08 keyboard failure on Nokia N900

Quoted 68 lines · Julia Lawall

Quoted 58 lines · Grygorii Strashko
Quoted 16 lines · Pavel Machek
Hi!
Quoted 11 lines
Quoted 3 lines
I tried today's linux-next. It boots on n900 (up to X), but then my screen locks and I can't get back. Touchscreen worked, so my guess is keyboard does not...? Ssh connection over usb still works.
Confirmed, its the keyboard.
Additionally, battery monitoring fails, because neither
/sys/class/power_supply/{n900-,rx51-}battery/voltage_now
exists.
And dmesg is helpful in this case:
Quoted 16 lines
[    0.675201] input: twl4030_pwrbutton as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:pwrbutton/input/input1
[    0.676635] input: TWL4030 Keypad as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:keypad/input/input2
[    0.679138] twl4030_keypad 48070000.i2c:twl at 48:keypad: request_irq
failed for irq no=156: -13
[    0.679779] twl4030_keypad: probe of 48070000.i2c:twl at 48:keypad
failed with error -13
[    0.682769] twl4030_madc 48070000.i2c:twl at 48:madc: could not
request irq
[    0.684051] twl4030_madc: probe of 48070000.i2c:twl at 48:madc failed
with error -13
[    0.685852] input: twl4030:vibrator as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:audio/twl4030-vibra/input/input3
[    0.768890] omap_i2c 48070000.i2c: bus 1 rev3.3 at 2200 kHz
I've not precisely checked it, but smth is telling me that below patch can cause this:
commit 78daaca78ee57dead0f4aa5ee399f0499e81cd9e
Author: Julia Lawall <[email protected]>
Date:   Thu May 4 22:10:50 2017 +0200
mfd: twl4030-irq: Drop unnecessary static
Drop static on a local variable, when the variable is initialized before any use, on every possible execution path through the function.
drivers/mfd/twl4030-irq.c +1 -1
@@ -685,7 +685,7 @@ int twl4030_sih_setup(struct device *dev, int module, int irq_base)
 
  int twl4030_init_irq(struct device *dev, int irq_num)
  {
-       static struct irq_chip  twl4030_irq_chip;
+       struct irq_chip twl4030_irq_chip;
 
 
Quoted 3 lines
but if we will look at code - it can be seen that this variable is passed by reference to irq_set_chip_and_handler().
Ops. And what will happen when twl4030_init_irq() returns ;)
The patch is not correct as was already noted when it was submitted:

Quoted 4 lines

https://lkml.org/lkml/2017/7/15/169
https://lkml.org/lkml/2017/7/15/171
Do you need a patch reverting this one?

Hm. This one is in linux-next, but shouldn't. Right?

git log --oneline -10 linux-next/master
c0b96db Add linux-next specific files for 20170808

git log --oneline linux-next/master | grep "Drop unnecessary static" 78daaca mfd: twl4030-irq: Drop unnecessary static

Signature · 2 lines

regards,
-grygorii

Julia Lawall

2017-08-08 20:30 UTC #6 lore raw

Re: linux-next 2017-08-08 keyboard failure on Nokia N900

Quoted 80 lines · Grygorii Strashko

Quoted 72 lines · Julia Lawall
Quoted 61 lines · Grygorii Strashko
Quoted 17 lines · Pavel Machek
Hi!
Quoted 5 lines
Quoted 4 lines
I tried today's linux-next. It boots on n900 (up to X), but then my screen locks and I can't get back. Touchscreen worked, so my guess is
keyboard does not...? Ssh connection over usb still works.
Quoted 7 lines
Confirmed, its the keyboard.
Additionally, battery monitoring fails, because neither
/sys/class/power_supply/{n900-,rx51-}battery/voltage_now
exists.
And dmesg is helpful in this case:
Quoted 16 lines
[    0.675201] input: twl4030_pwrbutton as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:pwrbutton/input/input1
[    0.676635] input: TWL4030 Keypad as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:keypad/input/input2
[    0.679138] twl4030_keypad 48070000.i2c:twl at 48:keypad: request_irq
failed for irq no=156: -13
[    0.679779] twl4030_keypad: probe of 48070000.i2c:twl at 48:keypad
failed with error -13
[    0.682769] twl4030_madc 48070000.i2c:twl at 48:madc: could not
request irq
[    0.684051] twl4030_madc: probe of 48070000.i2c:twl at 48:madc failed
with error -13
[    0.685852] input: twl4030:vibrator as
/devices/platform/68000000.ocp/48070000.i2c/i2c-1/1-0048/48070000.i2c:twl at 48:audio/twl4030-vibra/input/input3
[    0.768890] omap_i2c 48070000.i2c: bus 1 rev3.3 at 2200 kHz
I've not precisely checked it, but smth is telling me that below patch can cause this:
commit 78daaca78ee57dead0f4aa5ee399f0499e81cd9e
Author: Julia Lawall <[email protected]>
Date:   Thu May 4 22:10:50 2017 +0200
mfd: twl4030-irq: Drop unnecessary static
Drop static on a local variable, when the variable is initialized
before
any use, on every possible execution path through the function.
drivers/mfd/twl4030-irq.c +1 -1
@@ -685,7 +685,7 @@ int twl4030_sih_setup(struct device *dev, int module,
 int irq_base)
 
  int twl4030_init_irq(struct device *dev, int irq_num)
  {
-       static struct irq_chip  twl4030_irq_chip;
+       struct irq_chip twl4030_irq_chip;
 
 
Quoted 4 lines
but if we will look at code - it can be seen that this variable is passed by reference to
irq_set_chip_and_handler().
Ops. And what will happen when twl4030_init_irq() returns ;)
The patch is not correct as was already noted when it was submitted:
Quoted 4 lines
https://lkml.org/lkml/2017/7/15/169
https://lkml.org/lkml/2017/7/15/171
Do you need a patch reverting this one?

Quoted 7 lines

Hm. This one is in linux-next, but shouldn't. Right?
git log --oneline -10 linux-next/master
c0b96db Add linux-next specific files for 20170808
git log --oneline linux-next/master | grep "Drop unnecessary static" 78daaca mfd: twl4030-irq: Drop unnecessary static

OK, it seems like the patch was made twice, the second one was commented on and the first one was applied. 78daaca should not be there.

julia

Pavel Machek

author

2017-08-08 21:44 UTC #7 lore raw

Re: linux-next 2017-08-08 keyboard failure on Nokia N900

Hi!

Quoted 4 lines

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
I've not precisely checked it, but smth is telling me that below patch can cause this:
commit 78daaca78ee57dead0f4aa5ee399f0499e81cd9e

...

Quoted 8 lines

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
mfd: twl4030-irq: Drop unnecessary static
Drop static on a local variable, when the variable is initialized
before
any use, on every possible execution path through the function.
drivers/mfd/twl4030-irq.c +0 -0

...

Quoted 12 lines

Quoted 12 lines
Quoted 12 lines
Quoted 10 lines
  int twl4030_init_irq(struct device *dev, int irq_num)
  {
drivers/mfd/twl4030-irq.c +1 -1
-       static struct irq_chip  twl4030_irq_chip;
+       struct irq_chip twl4030_irq_chip;
but if we will look at code - it can be seen that this variable is passed by reference to
irq_set_chip_and_handler().
Ops. And what will happen when twl4030_init_irq() returns ;)
The patch is not correct as was already noted when it was submitted:

Quoted 10 lines

Quoted 7 lines
Hm. This one is in linux-next, but shouldn't. Right?
git log --oneline -10 linux-next/master
c0b96db Add linux-next specific files for 20170808
git log --oneline linux-next/master | grep "Drop unnecessary static" 78daaca mfd: twl4030-irq: Drop unnecessary static
OK, it seems like the patch was made twice, the second one was commented on and the first one was applied. 78daaca should not be there.

Lee, it has your sign-off, can you drop the patch from your tree? It is known bad.

Thanks,
Pavel

Signature · 9 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170808/bff17b2d/attachment.sig>

Lee Jones

2017-08-09 12:45 UTC #8 lore raw

Re: linux-next 2017-08-08 keyboard failure on Nokia N900

Quoted 34 lines · Pavel Machek

Hi!
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
I've not precisely checked it, but smth is telling me that below patch can cause this:
commit 78daaca78ee57dead0f4aa5ee399f0499e81cd9e
...
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
mfd: twl4030-irq: Drop unnecessary static
Drop static on a local variable, when the variable is initialized
before
any use, on every possible execution path through the function.
drivers/mfd/twl4030-irq.c +0 -0
...
Quoted 12 lines
Quoted 12 lines
Quoted 12 lines
Quoted 10 lines
  int twl4030_init_irq(struct device *dev, int irq_num)
  {
drivers/mfd/twl4030-irq.c +1 -1
-       static struct irq_chip  twl4030_irq_chip;
+       struct irq_chip twl4030_irq_chip;
but if we will look at code - it can be seen that this variable is passed by reference to
irq_set_chip_and_handler().
Ops. And what will happen when twl4030_init_irq() returns ;)
The patch is not correct as was already noted when it was submitted:
..
Quoted 5 lines
Quoted 5 lines
Hm. This one is in linux-next, but shouldn't. Right?
git log --oneline -10 linux-next/master
c0b96db Add linux-next specific files for 20170808

Quoted 8 lines

Quoted 5 lines
Quoted 2 lines
git log --oneline linux-next/master | grep "Drop unnecessary static" 78daaca mfd: twl4030-irq: Drop unnecessary static
OK, it seems like the patch was made twice, the second one was commented on and the first one was applied. 78daaca should not be there.
Lee, it has your sign-off, can you drop the patch from your tree? It is known bad.

Done, thanks.

Signature · 4 lines

Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Pavel Machek

author

2017-08-10 17:10 UTC #9 lore raw

Re: linux-next 2017-08-08 keyboard failure on Nokia N900

In reply to Grygorii Strashko

Hi!

Quoted 6 lines

Quoted 6 lines
Quoted 6 lines
Quoted 3 lines
I tried today's linux-next. It boots on n900 (up to X), but then my screen locks and I can't get back. Touchscreen worked, so my guess is keyboard does not...? Ssh connection over usb still works.
Confirmed, its the keyboard.

...

Quoted 8 lines

Quoted 3 lines
[    0.682769] twl4030_madc 48070000.i2c:twl at 48:madc: could not
request irq
[    0.684051] twl4030_madc: probe of 48070000.i2c:twl at 48:madc failed
I've not precisely checked it, but smth is telling me that below patch can cause this:
commit 78daaca78ee57dead0f4aa5ee399f0499e81cd9e

...

Quoted 9 lines

int twl4030_init_irq(struct device *dev, int irq_num) {
drivers/mfd/twl4030-irq.c +1 -1
-       static struct irq_chip  twl4030_irq_chip;
+       struct irq_chip twl4030_irq_chip;
but if we will look at code - it can be seen that this variable is passed by reference to irq_set_chip_and_handler().
Ops. And what will happen when twl4030_init_irq() returns ;)

Thanks, this would take me a while to figure out. I'm testing next-..-08-10, which should have this fixed... and yes, it does.

Best regards,
Pavel

Signature · 9 lines

(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170810/ebae63d6/attachment.sig>