Skip to contentSkip to conversation

random: fix warning message on ia64 and parisc

PATCH New Helge Deller 1 participant 1 message Aug 8, 2017 Random number driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 random: fix warning message on ia64 and parisc

Fix the warning message on the parisc and IA64 architectures to show the correct function name of the caller by using %pS instead of %pF. The message is printed with the value of _RET_IP_ which calls __builtin_return_address(0) and as such returns the IP address caller instead of pointer to a function descriptor of the caller.

The effect of this patch is visible on the parisc and ia64 architectures only since those are the ones which use function descriptors while on all others %pS and %pF will behave the same.

Cc Theodore Ts'o <[email protected]>
Cc Jason A. Donenfeld <[email protected]>
Fixes eecabf567422 ("random: suppress spammy warnings about unseeded randomness")
Fixes d06bfd1989fe ("random: warn when kernel uses unseeded randomness")
drivers/char/random.c +1 -1
index afa3ce7..8ad9270 100644
@@ -1492,7 +1492,7 @@ static void _warn_unseeded_randomness(const char *func_name, void *caller,
 #ifndef CONFIG_WARN_ALL_UNSEEDED_RANDOM
 	print_once = true;
 #endif
-	pr_notice("random: %s called from %pF with crng_init=%d\n",
+	pr_notice("random: %s called from %pS with crng_init=%d\n",
 		  func_name, caller, crng_init);
 }