usb: gadget: udc: renesas_usb3: fix error return code in renesas_usb3_probe()

PATCH In review Gustavo A. R. Silva 2 participants 3 messages Aug 8, 2017 – Aug 10, 2017 USB

Share & tools

Gustavo A. R. Silva

author

2017-08-08 22:34 UTC #0 lore raw

PATCH 1/1 usb: gadget: udc: renesas_usb3: fix error return code in renesas_usb3_probe()

platform_get_irq() returns an error code, but the renesas_usb3 driver ignores it and always returns -ENODEV. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.

Also, notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af

Print error message and propagate the return value of platform_get_irq on failure.

This issue was detected with the help of Coccinelle.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/usb/gadget/udc/renesas_usb3.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

drivers/usb/gadget/udc/renesas_usb3.c +4 -2

index e1de8fe..616d053 100644
@@ -2468,8 +2468,10 @@ static int renesas_usb3_probe(struct platform_device *pdev)
 	priv = match->data;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0)
-		return -ENODEV;
+	if (irq < 0) {
+		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
+		return irq;
+	}
 
 	usb3 = devm_kzalloc(&pdev->dev, sizeof(*usb3), GFP_KERNEL);
 	if (!usb3)

Signature · 1 line

2.5.0

Yoshihiro Shimoda

Acked-by on v1 1/1

2017-08-09 11:44 UTC #1 lore raw

Hi Gustavo,

Thank you for the patch!

Quoted 7 lines

-----Original Message-----
From: Gustavo A. R. Silva
Sent: Wednesday, August 9, 2017 7:35 AM
platform_get_irq() returns an error code, but the renesas_usb3 driver ignores it and always returns -ENODEV. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.

Thank you for the point. I got it.

Quoted 3 lines

Also, notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92
af

I don't think this explanation needs.
After this is removed,

Acked-by Yoshihiro Shimoda <[email protected]>

Best regards,
Yoshihiro Shimoda

Quoted 34 lines

Print error message and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/usb/gadget/udc/renesas_usb3.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/usb/gadget/udc/renesas_usb3.c +4 -3
index e1de8fe..616d053 100644
@@ -2468,8 +2468,10 @@ static int renesas_usb3_probe(struct platform_device *pdev)
 	priv = match->data;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0)
-		return -ENODEV;
+	if (irq < 0) {
+		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
+		return irq;
+	}
 
 	usb3 = devm_kzalloc(&pdev->dev, sizeof(*usb3), GFP_KERNEL);
 	if (!usb3)
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Gustavo A. R. Silva

author

2017-08-10 03:10 UTC #2 lore raw

Hi Yoshihiro,

Quoted 4 lines · Yoshihiro Shimoda

Hi Gustavo,
Thank you for the patch!

I'm glad to help :)

Quoted 10 lines

Quoted 7 lines
-----Original Message-----
From: Gustavo A. R. Silva
Sent: Wednesday, August 9, 2017 7:35 AM
platform_get_irq() returns an error code, but the renesas_usb3 driver ignores it and always returns -ENODEV. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.
Thank you for the point. I got it.

Quoted 9 lines

Quoted 3 lines
Also, notice that platform_get_irq() no longer returns 0 on error:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92
af
I don't think this explanation needs.
After this is removed,
Acked-by Yoshihiro Shimoda <[email protected]>

Thank you
--
Gustavo A. R. Silva

Quoted 37 lines

Best regards,
Yoshihiro Shimoda
Quoted 34 lines
Print error message and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/usb/gadget/udc/renesas_usb3.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/usb/gadget/udc/renesas_usb3.c +4 -3
index e1de8fe..616d053 100644
@@ -2468,8 +2468,10 @@ static int renesas_usb3_probe(struct platform_device *pdev)
 	priv = match->data;
 
 	irq = platform_get_irq(pdev, 0);
-	if (irq < 0)
-		return -ENODEV;
+	if (irq < 0) {
+		dev_err(&pdev->dev, "Failed to get IRQ: %d\n", irq);
+		return irq;
+	}
 
 	usb3 = devm_kzalloc(&pdev->dev, sizeof(*usb3), GFP_KERNEL);
 	if (!usb3)
--
2.5.0
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html