rtc: at91rm9200: fix error return code in at91_rtc_probe()
Subsystems (2)
PATCH 1/1 rtc: at91rm9200: fix error return code in at91_rtc_probe()
platform_get_irq() returns an error code, but the at91rm9200 driver ignores it and always returns -ENXIO. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.
Print and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
--- drivers/rtc/rtc-at91rm9200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/rtc/rtc-at91rm9200.c +2 -2
@@ -398,8 +398,8 @@ static int __init at91_rtc_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (&pdev->dev,"no irq resource defined\n" ); -return -ENXIO ; +dev_err (&pdev->dev,"no irq resource defined: %d\n" , irq); +return irq; } at91_rtc_regs = devm_ioremap(&pdev->dev, regs->start,
Signature · 1 line
2.5.0
Quoted 8 lines · Gustavo A. R. Silva
platform_get_irq()returns an error code, but the at91rm9200 driver ignores it and always returns-ENXIO. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.Print and propagate the return value of
platform_get_irqon failure.This issue was detected with the help of Coccinelle.
This will never happen and is not an actual issue. I will not take such a patch until you
1/ prove there is an issue
2/ test your patch on real hardware
Quoted 23 lines
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/rtc/rtc-at91rm9200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/rtc/rtc-at91rm9200.c +2
-2@@ -398,8 +398,8 @@ static int __init at91_rtc_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (&pdev->dev,"no irq resource defined\n" ); -return -ENXIO ; +dev_err (&pdev->dev,"no irq resource defined: %d\n" , irq); +return irq; } at91_rtc_regs = devm_ioremap(&pdev->dev, regs->start,Signature · 1 line
2.5.0
Signature · 3 lines
Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com