mtd: nand: fix error return code in flctl_probe()
Subsystems (2)
PATCH 1/1 mtd: nand: fix error return code in flctl_probe()
platform_get_irq() returns an error code, but the sh_flctl driver ignores it and always returns -ENXIO. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.
Print and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
Signed-off-by Gustavo A. R. Silva <[email protected]>
--- drivers/mtd/nand/sh_flctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mtd/nand/sh_flctl.c +2 -2
@@ -1141,8 +1141,8 @@ static int flctl_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (&pdev->dev,"failed to get flste irq data\n" ); -return -ENXIO ; +dev_err (&pdev->dev,"failed to get flste irq data: %d\n" , irq); +return irq; } ret = devm_request_irq(&pdev->dev, irq, flctl_handle_flste, IRQF_SHARED,
Signature · 1 line
2.5.0
Boris Brezillon
AppliedQuoted 7 lines · Gustavo A. R. Silva
platform_get_irq()returns an error code, but thesh_flctldriver ignores it and always returns-ENXIO. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.Print and propagate the return value of
platform_get_irqon failure.This issue was detected with the help of Coccinelle.
Applied.
Thanks,
Boris
Quoted 21 lines
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/mtd/nand/sh_flctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/mtd/nand/sh_flctl.c +2
-2@@ -1141,8 +1141,8 @@ static int flctl_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (&pdev->dev,"failed to get flste irq data\n" ); -return -ENXIO ; +dev_err (&pdev->dev,"failed to get flste irq data: %d\n" , irq); +return irq; } ret = devm_request_irq(&pdev->dev, irq, flctl_handle_flste, IRQF_SHARED,