mtd: nand: mtk: fix error return code in mtk_ecc_probe()
Subsystems (3)
PATCH 1/1 mtd: nand: mtk: fix error return code in mtk_ecc_probe()
platform_get_irq() returns an error code, but the mtk_ecc driver ignores it and always returns -EINVAL. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.
Print and propagate the return value of platform_get_irq on failure.
This issue was detected with the help of Coccinelle.
--- drivers/mtd/nand/mtk_ecc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mtd/nand/mtk_ecc.c +2 -2
@@ -464,8 +464,8 @@ static int mtk_ecc_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (dev,"failed to get irq\n" ); -return -EINVAL ; +dev_err (dev,"failed to get irq: %d\n" , irq); +return irq; } ret =dma_set_mask (dev,DMA_BIT_MASK (32 ));
Signature · 1 line
2.5.0
Boris Brezillon
AppliedLe Wed, 9 Aug 2017 11:35:21 -0500,
"Gustavo A. R. Silva" <[email protected]> a ?crit :
Quoted 7 lines
platform_get_irq()returns an error code, but themtk_eccdriver ignores it and always returns-EINVAL. This is not correct and, prevents -EPROBE_DEFER from being propagated properly.Print and propagate the return value of
platform_get_irqon failure.This issue was detected with the help of Coccinelle.
Applied.
Thanks,
Boris
Quoted 21 lines
Signed-off-by Gustavo A. R. Silva <[email protected]>--- drivers/mtd/nand/mtk_ecc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/mtd/nand/mtk_ecc.c +2
-2@@ -464,8 +464,8 @@ static int mtk_ecc_probe(struct platform_device *pdev) irq =platform_get_irq (pdev,0 );if (irq <0 ) { -dev_err (dev,"failed to get irq\n" ); -return -EINVAL ; +dev_err (dev,"failed to get irq: %d\n" , irq); +return irq; } ret =dma_set_mask (dev,DMA_BIT_MASK (32 ));