Skip to contentSkip to conversation

net: core: fix compile error inside flow_dissector due to new dsa callback

PATCH Applied John Crispin 2 participants 2 messages Aug 10, 2017

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

John Crispin

author
#0 lore raw

PATCH 1/1 net: core: fix compile error inside flow_dissector due to new dsa callback

The following error was introduced by
commit 43e665287f93 ("net-next: dsa: fix flow dissection") due to a missing #if guard

net/core/flow_dissector.c: In function '__skb_flow_dissect':
net/core/flow_dissector.c:448:18: error: 'struct net_device' has no member named 'dsa_ptr'

ops = skb->dev->dsa_ptr->tag_ops;
                ^

make[3]: *** [net/core/flow_dissector.o] Error 1

Signed-off-by John Crispin <[email protected]>
---
 net/core/flow_dissector.c | 2 ++
 1 file changed, 2 insertions(+)
net/core/flow_dissector.c +2 -0
index 5b5be9577257..79b9c06c83ad 100644
@@ -441,6 +441,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
 			 skb->vlan_proto : skb->protocol;
 		nhoff = skb_network_offset(skb);
 		hlen = skb_headlen(skb);
+#if IS_ENABLED(CONFIG_NET_DSA)
 		if (unlikely(netdev_uses_dsa(skb->dev))) {
 			const struct dsa_device_ops *ops;
 			int offset;

@@ -452,6 +453,7 @@ bool __skb_flow_dissect(const struct sk_buff *skb,
 				nhoff += offset;
 			}
 		}
+#endif
 	}
 
 	/* It is ensured by skb_flow_dissector_init() that control key will
Signature · 1 line
2.11.0
maintainer Applied
#1 lore raw

From: John Crispin <[email protected]>
Date: Thu, 10 Aug 2017 10:09:03 +0200

Quoted 11 lines

The following error was introduced by
commit 43e665287f93 ("net-next: dsa: fix flow dissection") due to a missing #if guard

net/core/flow_dissector.c: In function '__skb_flow_dissect':
net/core/flow_dissector.c:448:18: error: 'struct net_device' has no member named 'dsa_ptr'

ops = skb->dev->dsa_ptr->tag_ops;
                ^

make[3]: *** [net/core/flow_dissector.o] Error 1

Signed-off-by John Crispin <[email protected]>

Applied, thanks.