minnowboard_max_defconfig: grub2 needs WCHAR
PATCH 1/1 minnowboard_max_defconfig: grub2 needs WCHAR
Since commit 5ffafd2353f5d67 (grub2: bump up version), grub2 needs a toolchain with WCHAR support. However, the defconfigs that use grub2 were not updated at the time.
Add BR2_TOOLCHAIN_BUILDROOT_WCHAR=y to minnowboard_max_defconfig.
---
The following other defconfigs also use grub2.
galileo_defconfig: Needs to be updated, but is anyway failing to build
the kernel and I expect it will be removed.
minnowboard_max-graphical_defconfig: Already selects LOCALE which
implies WCHAR.
pc_x86_64_bios_defconfig, pc_x86_64_efi_defconfig: already select
WCHAR because it is needed for eudev.
--- configs/minnowboard_max_defconfig | 3 +++ 1 file changed, 3 insertions(+)
configs/minnowboard_max_defconfig +3 -0
@@ -9,6 +9,9 @@ BR2_ROOTFS_POST_IMAGE_SCRIPT="board/minnowboard/post-image.sh" # Linux headers same as kernel, a 4.12 series BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_12=y +# Needed for grub2 +BR2_TOOLCHAIN_BUILDROOT_WCHAR=y + BR2_PACKAGE_HOST_DOSFSTOOLS=y BR2_PACKAGE_HOST_GENIMAGE=y BR2_PACKAGE_HOST_MTOOLS=y
Signature · 1 line
2.13.3
PATCH 1/1 minnowboard_max_defconfig: grub2 needs WCHAR
Hello,
Quoted 6 lines · Arnout Vandecappelle (Essensium/Mind)
Since commit
5ffafd2353f5d67(grub2: bump up version), grub2 needs a toolchain with WCHAR support. However, the defconfigs that use grub2 were not updated at the time.Add BR2_TOOLCHAIN_BUILDROOT_WCHAR=y to
minnowboard_max_defconfig.
Quoted 7 lines
Cc Erico Nunes <[email protected]>Cc Peter Korsgaard <[email protected]>Cc Ezequiel Garcia <[email protected]>Cc Vincent Stehl? <[email protected]>---
The following other defconfigs also use grub2.
I've applied to master. However, I'm not entirely happy with the fact that grub2 requires wchar, but it's maybe a dependency that can be removed once we introduce grub2-tools
(http://patchwork.ozlabs.org/patch/755651/).
Anyway for now, adding the wchar option in the minnowboard defconfig is the only option we have.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com