Skip to contentSkip to conversation

au0828: fix unbalanced lock/unlock in au0828_usb_probe

PATCH New Gustavo A. R. Silva 1 participant 1 message Aug 12, 2017 Media (V4L/DVB)

lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 au0828: fix unbalanced lock/unlock in au0828_usb_probe

Call mutex_unlock and free dev on failure.

Reported-by Julia Lawall <[email protected]>
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/media/usb/au0828/au0828-core.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/media/usb/au0828/au0828-core.c +2 -0
index 739df61..cd363a2 100644
@@ -628,6 +628,8 @@ static int au0828_usb_probe(struct usb_interface *interface,
 	if (retval) {
 		pr_err("%s() au0282_dev_register failed to register on V4L2\n",
 			__func__);
+		mutex_unlock(&dev->lock);
+		kfree(dev);
 		goto done;
 	}
Signature · 1 line
2.5.0