scsi: pmcraid: fix duplicated code for different branches

PATCH New Gustavo A. R. Silva 1 participant 1 message Aug 13, 2017

Subsystems (2)

SCSI PMC sierra MaxRAID driver

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-08-13 01:26 UTC #0 lore raw

PATCH 1/1 scsi: pmcraid: fix duplicated code for different branches

Refactor code in order to avoid identical code for different branches.

This issue was detected with the help of Coccinelle.

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
This code was tested by compilation only.

 drivers/scsi/pmcraid.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

drivers/scsi/pmcraid.c +1 -6

index 1f8b153..b4d6cd8 100644
@@ -1595,12 +1595,7 @@ static void pmcraid_handle_config_change(struct pmcraid_instance *pinstance)
 	if (pinstance->ccn.hcam->notification_type ==
 	    NOTIFICATION_TYPE_ENTRY_CHANGED &&
 	    cfg_entry->resource_type == RES_TYPE_VSET) {
-
-		if (fw_version <= PMCRAID_FW_VERSION_1)
-			hidden_entry = (cfg_entry->unique_flags1 & 0x80) != 0;
-		else
-			hidden_entry = (cfg_entry->unique_flags1 & 0x80) != 0;
-
+		hidden_entry = (cfg_entry->unique_flags1 & 0x80) != 0;
 	} else if (!pmcraid_expose_resource(fw_version, cfg_entry)) {
 		goto out_notify_apps;
 	}

Signature · 1 line

2.5.0