Revert "syslinux: drop patch 0003, not needed after gnu-efi update"

PATCH New Arnout Vandecappelle (Essensium/Mind) 2 participants 4 messages Aug 13, 2017 – Aug 15, 2017

lore

Share & tools

lore

Arnout Vandecappelle (Essensium/Mind)

author

2017-08-13 23:28 UTC #0 lore raw

PATCH 1/1 Revert "syslinux: drop patch 0003, not needed after gnu-efi update"

It turns out that this patch is still needed, since with some versions of binutils the error still occurs.

Partially fixes: https://gitlab.com/arnout/buildroot/-/jobs/28979377

This reverts commit 644c024edeb7e20bd96ce4426aeca2cbcd74d9b9.

Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

Cc Beno?t Allard <[email protected]>

---
The failing ts5x00_defconfig also requires a kernel bump

---
 ....elf-Not-enough-room-for-program-headers-.patch | 35 ++++++++++++++++++++++
 1 file changed, 35 insertions(+)
 create mode 100644 boot/syslinux/0003-Fix-ldlinux.elf-Not-enough-room-for-program-headers-.patch

boot/syslinux/0003-Fix-ldlinux.elf-Not-enough-room-for-program-headers-.patch new file +35 -0

new file mode 100644
index 0000000000..83a87ee071
@@ -0,0 +1,35 @@
+From 61de7762389d460da7ffdd644f50c60175cce23b Mon Sep 17 00:00:00 2001
+From: Steve McIntyre <[email protected]>
+Date: Wed, 5 Apr 2017 22:09:37 +0200
+Subject: [PATCH] Fix 'ldlinux.elf: Not enough room for program headers, try
+ linking with -N'
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fix for https://bugs.debian.org/846679: syslinux: FTBFS: ld:
+ldlinux.elf: Not enough room for program headers, try linking with -N
+
+https://bugs.debian.org/cgi-bin/bugreport.cgi?att=1;bug=846679;filename=syslinux_6.03%2Bdfsg-14.1.debdiff;msg=10
+
+Signed-off-by: Beno?t Allard <[email protected]>
+---
+ core/Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/core/Makefile b/core/Makefile
+index ad0acb5..58a3545 100644
+--- a/core/Makefile
++++ b/core/Makefile
+@@ -165,7 +165,7 @@ LDSCRIPT = $(SRC)/$(ARCH)/syslinux.ld
+ 
+ %.elf: %.o $(LIBDEP) $(LDSCRIPT) $(AUXLIBS)
+ 	$(LD) $(LDFLAGS) -Bsymbolic $(LD_PIE) -E --hash-style=gnu -T $(LDSCRIPT) -M -o $@ $< \
+-		--start-group $(LIBS) $(subst $(*F).elf,lib$(*F).a,$@) --end-group \
++		--start-group $(LIBS) $(subst $(*F).elf,lib$(*F).a,$@) --end-group --no-dynamic-linker \
+ 		> $(@:.elf=.map)
+ 	$(OBJDUMP) -h $@ > $(@:.elf=.sec)
+ 	$(PERL) $(SRC)/lstadjust.pl $(@:.elf=.lsr) $(@:.elf=.sec) $(@:.elf=.lst)
+-- 
+2.7.4
+

Signature · 1 line

2.13.3

Thomas Petazzoni

2017-08-14 20:09 UTC #1 lore raw

PATCH 1/1 Revert "syslinux: drop patch 0003, not needed after gnu-efi update"

Hello,

Quoted 11 lines · Arnout Vandecappelle (Essensium/Mind)

It turns out that this patch is still needed, since with some versions of binutils the error still occurs.
Partially fixes: https://gitlab.com/arnout/buildroot/-/jobs/28979377
This reverts commit 644c024edeb7e20bd96ce4426aeca2cbcd74d9b9.
Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Cc Beno?t Allard <[email protected]>
---
The failing ts5x00_defconfig also requires a kernel bump

The problem with this is that you are going to run into the problem I reported at:
http://lists.busybox.net/pipermail/buildroot/2017-July/195927.html, i.e the --no-dynamic-linker option doesn't exist in old binutils versions, and will therefore cause a build failure.

BTW Arnout, you should not expect any feedback from Beno?t, he has left his previous employer, and explicitly removed himself from the syslinux developer:
https://git.buildroot.org/buildroot/commit/DEVELOPERS?id=74a1e8f9f220c8fb95abe1de67ee5441b7c449e7.
He will most likely not even receive your e-mail.

Therefore, we are on our own to figure out this one :)

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Arnout Vandecappelle

author

2017-08-15 14:53 UTC #2 lore raw

PATCH 1/1 Revert "syslinux: drop patch 0003, not needed after gnu-efi update"

Quoted 16 lines · Thomas Petazzoni

Hello,
Quoted 11 lines · Arnout Vandecappelle (Essensium/Mind)
It turns out that this patch is still needed, since with some versions of binutils the error still occurs.
Partially fixes: https://gitlab.com/arnout/buildroot/-/jobs/28979377
This reverts commit 644c024edeb7e20bd96ce4426aeca2cbcd74d9b9.
Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Cc Beno?t Allard <[email protected]>
---
The failing ts5x00_defconfig also requires a kernel bump

Quoted 5 lines

The problem with this is that you are going to run into the problem I reported at:
http://lists.busybox.net/pipermail/buildroot/2017-July/195927.html, i.e the --no-dynamic-linker option doesn't exist in old binutils versions, and will therefore cause a build failure.

Indeed, TestIso9660Syslinux{Ex,Int}ternal fail on it.

I'm now trying with --omagic --no-omagic instead. If I read the man page
correctly, this should have more or less the same effect. It feels like a huge hack though...

Regards,
Arnout

Signature · 6 lines

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

Arnout Vandecappelle

author

2017-08-15 21:25 UTC #3 lore raw

PATCH 1/1 Revert "syslinux: drop patch 0003, not needed after gnu-efi update"

Quoted 22 lines · Arnout Vandecappelle

Quoted 15 lines · Thomas Petazzoni
Hello,
Quoted 11 lines · Arnout Vandecappelle (Essensium/Mind)
It turns out that this patch is still needed, since with some versions of binutils the error still occurs.
Partially fixes: https://gitlab.com/arnout/buildroot/-/jobs/28979377
This reverts commit 644c024edeb7e20bd96ce4426aeca2cbcd74d9b9.
Signed-off-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Cc Beno?t Allard <[email protected]>
---
The failing ts5x00_defconfig also requires a kernel bump
Quoted 5 lines
The problem with this is that you are going to run into the problem I reported at:
http://lists.busybox.net/pipermail/buildroot/2017-July/195927.html, i.e the --no-dynamic-linker option doesn't exist in old binutils versions, and will therefore cause a build failure.

Quoted 5 lines

Indeed, TestIso9660Syslinux{Ex,Int}ternal fail on it.
I'm now trying with --omagic --no-omagic instead. If I read the man page
correctly, this should have more or less the same effect. It feels like a huge hack though...

That didn't work...

But I tried with latest master and that did work (after applying our
cross-compilation patches). Bisecting now...

Regards,
Arnout

Signature · 6 lines

Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF