drm/i915/cnl: Fix LSPCON support.
Subsystems (2)
Rodrigo Vivi
maintainerPATCH 1/1 drm/i915/cnl: Fix LSPCON support.
When LSPCON support was extended to CNL
one part was missed on lspcon_init.
So, instead of adding check per platform on lspcon_init let's use HAS_LSPCON that is already there for that purpose.
--- drivers/gpu/drm/i915/intel_lspcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_lspcon.c +2 -2
@@ -210,8 +210,8 @@ bool lspcon_init(struct intel_digital_port *intel_dig_port)struct drm_device *dev = intel_dig_port->base.base.dev;struct drm_i915_private *dev_priv =to_i915 (dev); -if (!IS_GEN9 (dev_priv)) { -DRM_ERROR ("LSPCON is supported on GEN9 only\n" ); +if (!HAS_LSPCON (dev_priv)) { +DRM_ERROR ("LSPCON is not supported on this platform\n" );return false; }
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/i915/cnl: Fix LSPCON support.
== Series Details ==
== Series Details ==
Series: drm/i915/cnl: Fix LSPCON support.
URL : https://patchwork.freedesktop.org/series/28844/
State : success
== Summary ==
Series 28844v1 drm/i915/cnl: Fix LSPCON support.
https://patchwork.freedesktop.org/api/1.0/series/28844/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> FAIL (fi-snb-2600) fdo#100007
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-atomic:
pass -> FAIL (fi-snb-2600) fdo#100215
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705fdo#100007 https://bugs.freedesktop.org/show_bug.cgi?id=100007
fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:450s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:434s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:355s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:548s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:510s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:517s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:509s fi-glk-2a total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:604s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:437s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:418s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:421s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:503s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:478s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:468s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:590s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:597s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:529s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:460s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:471s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:481s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:437s fi-skl-x1585l total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:498s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:547s fi-snb-2600 total:279 pass:248 dwarn:0 dfail:0 fail:2 skip:29 time:404s
5118c7fa9c878351d1ed17a36b97966f68da72df drm-tip: 2017y-08m-15d-23h-58m-24s UTC integration manifest dc2dc74e844c drm/i915/cnl: Fix LSPCON support.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5411/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 6 lines · Rodrigo Vivi
When LSPCON support was extended to CNL
one part was missed onlspcon_init.So, instead of adding check per platform on
lspcon_initlet's useHAS_LSPCONthat is already there for that purpose.
I think HAS_LSPCON will require tweaking going forward, but this is good for now.
Quoted 23 lines
Fixes ff15947e0f02 ("drm/i915/cnl: LSPCON support is gen9+")Cc Shashank Sharma <[email protected]>Cc Paulo Zanoni <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_lspcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_lspcon.c +2
-2@@ -210,8 +210,8 @@ bool lspcon_init(struct intel_digital_port *intel_dig_port)struct drm_device *dev = intel_dig_port->base.base.dev;struct drm_i915_private *dev_priv =to_i915 (dev); -if (!IS_GEN9 (dev_priv)) { -DRM_ERROR ("LSPCON is supported on GEN9 only\n" ); +if (!HAS_LSPCON (dev_priv)) { +DRM_ERROR ("LSPCON is not supported on this platform\n" );return false; }
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
There is probably one more place where we want this change, but I will try to cover that in my 4:2:0 for lspcon patch set.
Meanwhile, please feel free to use:
Regards
Shashank
Quoted 20 lines · Rodrigo Vivi
When LSPCON support was extended to CNL
one part was missed onlspcon_init.So, instead of adding check per platform on
lspcon_initlet's useHAS_LSPCONthat is already there for that purpose.Fixes ff15947e0f02 ("drm/i915/cnl: LSPCON support is gen9+")Cc Shashank Sharma <[email protected]>Cc Paulo Zanoni <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_lspcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_lspcon.c +0
-0
drivers/gpu/drm/i915/intel_lspcon.c bool lspcon_init(struct intel_digital_port *intel_dig_port) · line 217
Quoted 10 lines
drivers/gpu/drm/i915/intel_lspcon.c +2
-2@@ -210,8 +210,8 @@ bool lspcon_init(struct intel_digital_port *intel_dig_port)struct drm_device *dev = intel_dig_port->base.base.dev;struct drm_i915_private *dev_priv =to_i915 (dev); -if (!IS_GEN9 (dev_priv)) { -DRM_ERROR ("LSPCON is supported on GEN9 only\n" ); +if (!HAS_LSPCON (dev_priv)) { +DRM_ERROR ("LSPCON is not supported on this platform\n" );return false; }
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
Appliedmerged to dinq. thanks for the reviews.
Quoted 50 lines · Shashank
There is probably one more place where we want this change, but I will try to cover that in my 4:2:0 for lspcon patch set.
Meanwhile, please feel free to use:
Reviewed-by Shashank Sharma <[email protected]>Regards
ShashankQuoted 23 lines · Rodrigo Vivi
When LSPCON support was extended to CNL
one part was missed onlspcon_init.So, instead of adding check per platform on
lspcon_initlet's useHAS_LSPCONthat is already there for that purpose.Fixes ff15947e0f02 ("drm/i915/cnl: LSPCON support is gen9+")Cc Shashank Sharma <[email protected]>Cc Paulo Zanoni <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_lspcon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/intel_lspcon.c +0
-0drivers/gpu/drm/i915/intel_lspcon.c bool lspcon_init(struct intel_digital_port · line 217
Quoted 9 lines
drivers/gpu/drm/i915/intel_lspcon.c +2
-1@@ -210,8 +210,8 @@ bool lspcon_init(struct intel_digital_port *intel_dig_port)struct drm_device *dev = intel_dig_port->base.base.dev;struct drm_i915_private *dev_priv =to_i915 (dev); - if (!IS_GEN9(dev_priv)) { -DRM_ERROR ("LSPCON is supported on GEN9 only\n" ); +if (!HAS_LSPCON (dev_priv)) { +DRM_ERROR ("LSPCON is not supported on this platform\n" );return false; }_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx