Skip to contentSkip to conversation

nvme-4.14 rebased

DISCUSSION Christoph Hellwig 3 participants 3 messages Aug 11, 2017 – Aug 16, 2017 NVMe

lore
Share & tools
lore

Christoph Hellwig

author maintainer
#0 lore raw

Hi all,

I've rebased the nvme-4.14 branch on top of the nvme-4.13 branch to avoid conflicts. As part of that I made the timestamp set features return an error similar to the other reset fixes.

Jon: can you double check the change is correct?

#1 lore raw
Quoted 8 lines · Christoph Hellwig

Hi all,

I've rebased the nvme-4.14 branch on top of the nvme-4.13 branch to avoid conflicts. As part of that I made the timestamp set features return an error similar to the other reset fixes.

Jon: can you double check the change is correct?

Hi Christoph,

The only thing I'd suggest is not letting a failure to set the timestamp be a failure to initialize the controller.

Regards,
Jon

#2 lore raw
Quoted 7 lines · Jon Derrick
Quoted 6 lines · Christoph Hellwig

Hi all,

I've rebased the nvme-4.14 branch on top of the nvme-4.13 branch to avoid conflicts. As part of that I made the timestamp set features return an error similar to the other reset fixes.

Quoted 7 lines
Quoted 2 lines

Jon: can you double check the change is correct?

Hi Christoph,

The only thing I'd suggest is not letting a failure to set the timestamp be a failure to initialize the controller.

It looks like Christoph just has it fail initialization if the timestamp feature command never gets a controller response. We actually do need to abandon controller init in that case since the controller is disabled in the timeout handler.