Fixed16.16 wrapper cleanup & wm optimization
Subsystems (2)
cover Fixed16.16 wrapper cleanup & wm optimization
This is a Trybot Version of series.
This series Include patches for:
clean fixed16.16 wrappers
optimize wm calculation code
enable/Implement trans wm calculation
create a DebugFS entry for IPC status
Kumar, Mahesh (8):
drm/i915: Fixed point fixed16 wrapper cleanup drm/i915/skl+: Optimize WM calculation drm/i915/gen10: Calculate and enable transition WM drm/i915/glk: IPC linetime watermark workaround for GLK drm/i915/cnl: Extend WM workaround with IPC for CNL drm/i915/gen9+: Add has_ipc flag in device info structure drm/i915/bxt+: Enable IPC support
drm/i915/skl+: debugfs entry to control IPC
drivers/gpu/drm/i915/i915_debugfs.c | 54 ++++++- drivers/gpu/drm/i915/i915_drv.c | 4 +- drivers/gpu/drm/i915/i915_drv.h | 33 ++++- drivers/gpu/drm/i915/i915_pci.c | 4 + drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 2 + drivers/gpu/drm/i915/intel_pm.c | 274 +++++++++++++++++++++++------------ 8 files changed, 273 insertions(+), 100 deletions(-)
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/8 drm/i915: Fixed point fixed16 wrapper cleanup
From: "Kumar, Mahesh" <[email protected]>
As per suggestion from Jani, cleanup the code. Cleanup includes
- Instead of left shifting & check, compare with U32/16_MAX
- Use typecast instead of clamp_t
--- drivers/gpu/drm/i915/i915_drv.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +7 -7
@@ -126,7 +126,7 @@ static inline uint_fixed_16_16_t u32_to_fixed16(uint32_t val) {uint_fixed_16_16_t fp; -WARN_ON (val >>16 ); +WARN_ON (val >U16_MAX ); fp.val = val <<16 ;return fp;
@@ -163,8 +163,8 @@ static inline uint_fixed_16_16_t max_fixed16(uint_fixed_16_16_t max1,static inline uint_fixed_16_16_t clamp_u64_to_fixed16 (uint64_t val) {uint_fixed_16_16_t fp; -WARN_ON (val >>32 ); - fp.val =clamp_t (uint32_t, val,0 , ~0 ); +WARN_ON (val >U32_MAX ); + fp.val = (uint32_t ) val;return fp; }
@@ -181,8 +181,8 @@ static inline uint32_t mul_round_up_u32_fixed16(uint32_t val, intermediate_val = (uint64_t ) val * mul.val; intermediate_val =DIV_ROUND_UP_ULL (intermediate_val,1 <<16 ); -WARN_ON (intermediate_val >>32 ); -return clamp_t (uint32_t, intermediate_val,0 , ~0 ); +WARN_ON (intermediate_val >U32_MAX ); +return (uint32_t ) intermediate_val; } static inline uint_fixed_16_16_t mul_fixed16(uint_fixed_16_16_t val,
@@ -211,8 +211,8 @@ static inline uint32_t div_round_up_u32_fixed16(uint32_t val, interm_val = (uint64_t )val <<16 ; interm_val =DIV_ROUND_UP_ULL (interm_val, d.val); -WARN_ON (interm_val >>32 ); -return clamp_t (uint32_t, interm_val,0 , ~0 ); +WARN_ON (interm_val >U32_MAX ); +return (uint32_t ) interm_val; } static inline uint_fixed_16_16_t mul_u32_fixed16(uint32_t val,
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/8 drm/i915/skl+: Optimize WM calculation
In reply to Mahesh KumarFrom: "Kumar, Mahesh" <[email protected]>
Plane configuration parameters doesn't change for each WM-level calculation. Currently we compute same parameters 8 times for each wm-level.
This patch optimizes it by calculating these parameters in beginning & reuse during each level-wm calculation.
Changes since V1:
- rebase on top of Rodrigo's series for CNL
--- drivers/gpu/drm/i915/i915_drv.h | 14 +++ drivers/gpu/drm/i915/intel_pm.c | 190 ++++++++++++++++++++++------------------ 2 files changed, 119 insertions(+), 85 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +14 -0
@@ -1811,6 +1811,20 @@ struct skl_wm_level {uint8_t plane_res_l; }; +/* Stores plane specific WM parameters */ +struct skl_wm_params { +bool x_tiled, y_tiled; +bool rc_surface; +uint32_t width; +uint8_t cpp; +uint32_t plane_pixel_rate; +uint32_t y_min_scanlines; +uint32_t plane_bytes_per_line; +uint_fixed_16_16_t plane_blocks_per_line; +uint_fixed_16_16_t y_tile_minimum; +uint32_t linetime_us; +}; +/* * This struct helps tracking the state needed for runtime PM, which puts the * device in PCI D3 state. Notice that when this happens, nothing on the
drivers/gpu/drm/i915/intel_pm.c +105 -85
281 lines not on this page · raw message
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/8 drm/i915/gen10: Calculate and enable transition WM
In reply to Mahesh KumarFrom: "Kumar, Mahesh" <[email protected]>
GEN > 9 require transition WM to be programmed if IPC is enabled. This patch calculates & enable transition WM for supported platforms. If transition WM is enabled, Plane read requests are sent at high priority until filling above the transition watermark, then the requests are sent at lower priority until dropping below the level-0 WM. The lower priority requests allow other memory clients to have better memory access.
transition minimum is the minimum amount needed for trans_wm to work to ensure the demote does not happen before enough data has been read to meet the level 0 watermark requirements.
transition amount is configurable value. Higher values will tend to cause longer periods of high priority reads followed by longer periods of lower priority reads. Tuning to lower values will tend to cause shorter periods of high and lower priority reads.
Keeping transition amount to 10 in this patch, as suggested by HW team.
Changes since V1:
- Address review comments from Maarten
--- drivers/gpu/drm/i915/intel_pm.c | 52 +++++++++++++++++++++++++++++++++++++++-- 1 file changed, 50 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +50 -2
@@ -4624,12 +4624,56 @@ skl_compute_linetime_wm(struct intel_crtc_state *cstate) }static void skl_compute_transition_wm (struct intel_crtc_state *cstate, +struct skl_wm_params *wp, +struct skl_wm_level *wm_l0, +uint16_t ddb_allocation,struct skl_wm_level *trans_wm/* out */ ) { +struct drm_device *dev = cstate->base.crtc->dev; +const struct drm_i915_private *dev_priv =to_i915 (dev); +uint16_t trans_min, trans_y_tile_min; +const uint16_t trans_amount =10 ;/* This is configurable amount */ +uint16_t trans_offset_b, res_blocks; +if (!cstate->base.active) + goto exit; + +/* Transition WM are not recommended by HW team for GEN9 */ +if (INTEL_GEN (dev_priv) <=9 ) + goto exit; + +/* Transition WM don't make any sense if ipc is disabled */ +if (!dev_priv->ipc_enabled) + goto exit; + +if (INTEL_GEN (dev_priv) >=10 ) + trans_min =4 ; + + trans_offset_b = trans_min + trans_amount; + +if (wp->y_tiled) { + trans_y_tile_min = (uint16_t )mul_round_up_u32_fixed16 (2 , + wp->y_tile_minimum); + res_blocks =max (wm_l0->plane_res_b, trans_y_tile_min) + + trans_offset_b; + }else { + res_blocks = wm_l0->plane_res_b + trans_offset_b; + +/* WA BUG:1938466 add one block for non y-tile planes */ +if (IS_CNL_REVID (dev_priv,CNL_REVID_A0 ,CNL_REVID_A0 )) + res_blocks +=1 ; + + } + + res_blocks +=1 ; + +if (res_blocks < ddb_allocation) { + trans_wm->plane_res_b = res_blocks; + trans_wm->plane_en = true;return ; + } -/* Until we know more, just disable transition WMs */ +exit: trans_wm->plane_en = false; }
@@ -4656,8 +4700,11 @@ static int skl_build_pipe_wm(struct intel_crtc_state *cstate,to_intel_plane_state (pstate);enum plane_id plane_id =to_intel_plane (plane)->id;struct skl_wm_params wm_params; +enum pipe pipe =to_intel_crtc (cstate->base.crtc)->pipe; +uint16_t ddb_blocks; wm = &pipe_wm->planes[plane_id]; + ddb_blocks =skl_ddb_entry_size (&ddb->plane[pipe][plane_id]);memset (&wm_params,0 ,sizeof (struct skl_wm_params )); ret = skl_compute_plane_wm_params(dev_priv, cstate,
@@ -4669,7 +4716,8 @@ static int skl_build_pipe_wm(struct intel_crtc_state *cstate, intel_pstate, &wm_params, wm);if (ret)return ret; -skl_compute_transition_wm (cstate, &wm->trans_wm); +skl_compute_transition_wm (cstate, &wm_params, &wm->wm[0 ], + ddb_blocks, &wm->trans_wm); } pipe_wm->linetime =skl_compute_linetime_wm (cstate);
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/8 drm/i915/glk: IPC linetime watermark workaround for GLK
In reply to Mahesh KumarFrom: "Kumar, Mahesh" <[email protected]>
IF IPC is enabled LINETIME_WM value should be half of calculated value
line time = ROUNDDOWN(1/2 * Calculated Line Time)
Earlier code was rounding-up the value, But updated Bspec says we should take the ROUNDDOWN. This patch corrects that as well.
--- drivers/gpu/drm/i915/intel_pm.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +4 -3
@@ -4616,9 +4616,10 @@ skl_compute_linetime_wm(struct intel_crtc_state *cstate) linetime_wm =fixed16_to_u32_round_up (mul_u32_fixed16 (8 , linetime_us)); -/* Display WA #1135: bxt. */ -if (IS_BROXTON (dev_priv) && dev_priv->ipc_enabled) - linetime_wm =DIV_ROUND_UP (linetime_wm,2 ); +/* Display WA #1135: bxt:ALL GLK:ALL */ +if ((IS_BROXTON (dev_priv) ||IS_GEMINILAKE (dev_priv)) && + dev_priv->ipc_enabled) + linetime_wm /=2 ;return linetime_wm; }
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/8 drm/i915/cnl: Extend WM workaround with IPC for CNL
In reply to Mahesh KumarFrom: "Kumar, Mahesh" <[email protected]>
CNL:A & CNL:B have same workaround as KBL to increase wm level latency by 4us if IPC is enabled.
--- drivers/gpu/drm/i915/intel_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_pm.c +2 -1
@@ -4486,7 +4486,8 @@ static int skl_compute_plane_wm(const struct drm_i915_private *dev_priv, }/* Display WA #1141: kbl,cfl */ -if ((IS_KABYLAKE (dev_priv) ||IS_COFFEELAKE (dev_priv)) && +if ((IS_KABYLAKE (dev_priv) ||IS_COFFEELAKE (dev_priv) || +IS_CNL_REVID (dev_priv,CNL_REVID_A0 ,CNL_REVID_B0 )) && dev_priv->ipc_enabled) latency +=4 ;
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/8 drm/i915/gen9+: Add has_ipc flag in device info structure
In reply to Mahesh KumarFrom: "Kumar, Mahesh" <[email protected]>
New Isochronous Priority Control (IPC) capability is introduced in newer GEN platforms. This patch adds a device info flag to indicate if platform supports IPC. Patch also sets this flag in supported platforms.
--- drivers/gpu/drm/i915/i915_drv.h | 5 ++++- drivers/gpu/drm/i915/i915_pci.c | 4 ++++ 2 files changed, 8 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.h +4 -1
@@ -779,7 +779,8 @@ struct intel_csr {func (cursor_needs_physical); \func (hws_needs_physical); \func (overlay_needs_physical); \ -func (supports_tv); +func (supports_tv); \ +func (has_ipc);struct sseu_dev_info {u8 slice_mask;
@@ -3077,6 +3078,8 @@ intel_info(const struct drm_i915_private *dev_priv)#define HAS_RUNTIME_PM (dev_priv) ((dev_priv)->info.has_runtime_pm)#define HAS_64BIT_RELOC (dev_priv) ((dev_priv)->info.has_64bit_reloc) +#define HAS_IPC (dev_priv) ((dev_priv)->info.has_ipc) +/* * For now, anything with a GuC requires uCode loading, and then supports * command submission once loaded. But these are logically independent
drivers/gpu/drm/i915/i915_pci.c +4 -0
@@ -390,6 +390,7 @@ static const struct intel_device_info intel_skylake_gt3_info = { .has_full_ppgtt = 1, \ .has_full_48bit_ppgtt = 1, \ .has_reset_engine = 1, \ + .has_ipc =1 , \GEN_DEFAULT_PIPEOFFSETS , \IVB_CURSOR_OFFSETS , \BDW_COLORS
@@ -414,6 +415,7 @@ static const struct intel_device_info intel_geminilake_info = { .platform = INTEL_KABYLAKE, \ .has_csr = 1, \ .has_guc = 1, \ + .has_ipc = 1, \ .ddb_size = 896 static const struct intel_device_info intel_kabylake_info = {
@@ -432,6 +434,7 @@ static const struct intel_device_info intel_kabylake_gt3_info = { .platform = INTEL_COFFEELAKE, \ .has_csr = 1, \ .has_guc = 1, \ + .has_ipc = 1, \ .ddb_size = 896 static const struct intel_device_info intel_coffeelake_info = {
@@ -450,6 +453,7 @@ static const struct intel_device_info intel_cannonlake_info = { .gen = 10, .ddb_size = 1024, .has_csr = 1, + .has_ipc = 1, .color = { .degamma_lut_size = 0, .gamma_lut_size = 1024 } };
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/8 drm/i915/bxt+: Enable IPC support
In reply to Mahesh KumarFrom: "Kumar, Mahesh" <[email protected]>
This patch adds IPC support. This patch also enables IPC in all supported platforms based on has_ipc flag.
IPC (Isochronous Priority Control) is the hardware feature, which dynamically controls the memory read priority of Display.
When IPC is enabled, plane read requests are sent at high priority until filling above the transition watermark, then the requests are sent at lower priority until dropping below the level 0 watermark. The lower priority requests allow other memory clients to have better memory access. When IPC is disabled, all plane read requests are sent at high priority.
Changes since V1:
- Remove commandline parameter to disable ipc
- Address Paulo's comments
Changes since V2:
- Address review comments
- Set ipc_enabled flag
Changes since V3:
- move ipc_enabled flag assignment inside intel_ipc_enable function
Changes since V4:
- Re-enable IPC after suspend/resume
Changes since V5:
- Enable IPC for all gen >=9 except SKL
Changes since V6:
- fix commit msg
- after resume program IPC based on SW state.
Changes since V7:
- Modify IPC support check based on HAS_IPC macro (suggested by Chris)
--- drivers/gpu/drm/i915/i915_drv.c | 4 +++- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_display.c | 1 + drivers/gpu/drm/i915/intel_drv.h | 2 ++ drivers/gpu/drm/i915/intel_pm.c | 24 ++++++++++++++++++++++++ 5 files changed, 31 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.c +3 -1
@@ -1340,7 +1340,7 @@ int i915_driver_load(struct pci_dev *pdev, const struct pci_device_id *ent)intel_runtime_pm_enable (dev_priv); - dev_priv->ipc_enabled = false; +intel_init_ipc (dev_priv);if (IS_ENABLED (CONFIG_DRM_I915_DEBUG ))DRM_INFO ("DRM_I915_DEBUG enabled\n" );
@@ -2602,6 +2602,8 @@ static int intel_runtime_resume(struct device *kdev)if (!IS_VALLEYVIEW (dev_priv) && !IS_CHERRYVIEW (dev_priv))intel_hpd_init (dev_priv); +intel_enable_ipc (dev_priv); +enable_rpm_wakeref_asserts (dev_priv);if (ret)
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -6934,6 +6934,7 @@ enum {#define DISP_FBC_WM_DIS (1<<15)#define DISP_ARB_CTL2 _MMIO(0x45004)#define DISP_DATA_PARTITION_5_6 (1<<6) +#define DISP_IPC_ENABLE (1<<3)#define DBUF_CTL _MMIO(0x45008)#define DBUF_POWER_REQUEST (1<<31)#define DBUF_POWER_STATE (1<<30)
drivers/gpu/drm/i915/intel_display.c +1 -0
@@ -15164,6 +15164,7 @@ void intel_display_resume(struct drm_device *dev)if (!ret) ret =__intel_display_resume (dev, state, &ctx); +intel_enable_ipc (dev_priv);drm_modeset_drop_locks (&ctx);drm_modeset_acquire_fini (&ctx);
drivers/gpu/drm/i915/intel_drv.h +2 -0
@@ -1867,6 +1867,8 @@ bool ilk_disable_lp_wm(struct drm_device *dev);int sanitize_rc6_option (struct drm_i915_private *dev_priv,int enable_rc6);int skl_check_pipe_max_pixel_rate (struct intel_crtc *intel_crtc,struct intel_crtc_state *cstate); +void intel_init_ipc (struct drm_i915_private *dev_priv); +void intel_enable_ipc (struct drm_i915_private *dev_priv);static inline int intel_enable_rc6 (void ) {return i915.enable_rc6;
drivers/gpu/drm/i915/intel_pm.c +24 -0
@@ -5818,6 +5818,30 @@ void intel_update_watermarks(struct intel_crtc *crtc) dev_priv->display.update_wm (crtc); } +void intel_enable_ipc (struct drm_i915_private *dev_priv) +{ +u32 val; + + val =I915_READ (DISP_ARB_CTL2 ); + +if (dev_priv->ipc_enabled) + val |=DISP_IPC_ENABLE ; +else + val &= ~DISP_IPC_ENABLE ; + +I915_WRITE (DISP_ARB_CTL2 , val); +} + +void intel_init_ipc (struct drm_i915_private *dev_priv) +{ + dev_priv->ipc_enabled = false; +if (!HAS_IPC (dev_priv)) +return ; + + dev_priv->ipc_enabled = true; +intel_enable_ipc (dev_priv); +} +/* * Lock protecting IPS related data structures */
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 8/8 drm/i915/skl+: debugfs entry to control IPC
In reply to Mahesh KumarFrom: "Kumar, Mahesh" <[email protected]>
This patch creates an entry in debugfs to check the status of IPC. This can also be used to enable/disable IPC in supported platforms.
Changes since V1:
- fix use of HAS_IPC
- use kstrtobool_from_user (Maarten)
- drm_info log, while enabling IPC (Maarten)
--- drivers/gpu/drm/i915/i915_debugfs.c | 54 ++++++++++++++++++++++++++++++++++++- 1 file changed, 53 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_debugfs.c +53 -1
@@ -3528,6 +3528,57 @@ static int i915_wa_registers(struct seq_file *m, void *unused)return 0 ; } +static int i915_ipc_status_show (struct seq_file *m,void *data) +{ +struct drm_i915_private *dev_priv = m->private; + +seq_printf (m,"Isochronous Priority Control: %s\n" , +enableddisabled (dev_priv->ipc_enabled)); +return 0 ; +} + +static int i915_ipc_status_open (struct inode *inode,struct file *file) +{ +struct drm_i915_private *dev_priv = inode->i_private; + +if (!HAS_IPC (dev_priv)) +return -ENODEV ; + +return single_open (file, i915_ipc_status_show, dev_priv); +} + +static ssize_t i915_ipc_status_write (struct file *file,const char __user *ubuf, +size_t len,loff_t *offp) +{ +struct seq_file *m = file->private_data; +struct drm_i915_private *dev_priv = m->private; +int ret; +bool enable; + + ret =kstrtobool_from_user (ubuf, len, &enable); +if (ret <0 ) +return ret; + +intel_runtime_pm_get (dev_priv); +if (!dev_priv->ipc_enabled && enable) +DRM_INFO ("Enabling IPC: WM will be proper only after next commit\n" ); + dev_priv->wm.distrust_bios_wm = true; + dev_priv->ipc_enabled = enable; +intel_enable_ipc (dev_priv); +intel_runtime_pm_put (dev_priv); + +return len; +} + +static const struct file_operations i915_ipc_status_fops = { + .owner =THIS_MODULE , + .open = i915_ipc_status_open, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, + .write = i915_ipc_status_write +}; +static int i915_ddb_info (struct seq_file *m,void *unused) {struct drm_i915_private *dev_priv =node_to_i915 (m->private);
@@ -4864,7 +4915,8 @@ static const struct i915_debugfs_files { {"i915_dp_test_type", &i915_displayport_test_type_fops}, {"i915_dp_test_active", &i915_displayport_test_active_fops}, {"i915_guc_log_control", &i915_guc_log_control_fops}, - {"i915_hpd_storm_ctl", &i915_hpd_storm_ctl_fops} + {"i915_hpd_storm_ctl", &i915_hpd_storm_ctl_fops}, + {"i915_ipc_status", &i915_ipc_status_fops} };int i915_debugfs_register (struct drm_i915_private *dev_priv)
Signature · 6 lines
2.13.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: warning for Fixed16.16 wrapper cleanup & wm optimization (rev7)
In reply to Mahesh Kumar== Series Details ==
== Series Details ==
Series: Fixed16.16 wrapper cleanup & wm optimization (rev7)
URL : https://patchwork.freedesktop.org/series/25692/
State : warning
== Summary ==
Series 25692v7 Fixed16.16 wrapper cleanup & wm optimization
https://patchwork.freedesktop.org/api/1.0/series/25692/revisions/7/mbox/
Test kms_cursor_legacy:
Subgroup basic-flip-before-cursor-legacy:
pass -> DMESG-WARN (fi-glk-2a)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
pass -> DMESG-WARN (fi-byt-n2820) fdo#101705fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:453s fi-bdw-gvtdvm total:279 pass:265 dwarn:0 dfail:0 fail:0 skip:14 time:433s fi-blb-e6850 total:279 pass:224 dwarn:1 dfail:0 fail:0 skip:54 time:357s fi-bsw-n3050 total:279 pass:243 dwarn:0 dfail:0 fail:0 skip:36 time:549s fi-bxt-j4205 total:279 pass:260 dwarn:0 dfail:0 fail:0 skip:19 time:516s fi-byt-j1900 total:279 pass:254 dwarn:1 dfail:0 fail:0 skip:24 time:525s fi-byt-n2820 total:279 pass:250 dwarn:1 dfail:0 fail:0 skip:28 time:514s fi-glk-2a total:279 pass:259 dwarn:1 dfail:0 fail:0 skip:19 time:603s fi-hsw-4770 total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:443s fi-hsw-4770r total:279 pass:263 dwarn:0 dfail:0 fail:0 skip:16 time:421s fi-ilk-650 total:279 pass:229 dwarn:0 dfail:0 fail:0 skip:50 time:426s fi-ivb-3520m total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:504s fi-ivb-3770 total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:478s fi-kbl-7500u total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:477s fi-kbl-7560u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:595s fi-kbl-r total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:604s fi-pnv-d510 total:279 pass:223 dwarn:1 dfail:0 fail:0 skip:55 time:524s fi-skl-6260u total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:470s fi-skl-6700k total:279 pass:261 dwarn:0 dfail:0 fail:0 skip:18 time:477s fi-skl-6770hq total:279 pass:269 dwarn:0 dfail:0 fail:0 skip:10 time:488s fi-skl-gvtdvm total:279 pass:266 dwarn:0 dfail:0 fail:0 skip:13 time:438s fi-skl-x1585l total:279 pass:268 dwarn:0 dfail:0 fail:0 skip:11 time:500s fi-snb-2520m total:279 pass:251 dwarn:0 dfail:0 fail:0 skip:28 time:550s fi-snb-2600 total:279 pass:250 dwarn:0 dfail:0 fail:0 skip:29 time:408s
ada53b43f81fe618f3f0f1dfbd3dd776bb277323 drm-tip: 2017y-08m-16d-15h-18m-56s UTC integration manifest e0e32e4ac1e2 drm/i915/skl+: debugfs entry to control IPC12f5253026e1 drm/i915/bxt+: Enable IPC support3e79e9613276 drm/i915/gen9+: Add has_ipc flag in device info structure410b43002f50 drm/i915/cnl: Extend WM workaround with IPC for CNL2a11f5bc0617 drm/i915/glk: IPC linetime watermark workaround for GLK0a852b3adca3 drm/i915/gen10: Calculate and enable transition WMcf509cd38a16 drm/i915/skl+: Optimize WM calculation930e260ada22 drm/i915: Fixed point fixed16 wrapper cleanup
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5428/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 1 line · Mahesh Kumar
This is a Trybot Version of series.
What do you mean? Is this for upstream consideration or not?
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Hi,
My bad, I forgot to modify cover-letter before sending series to intel-gfx.
yes this is for upstream consideration.
-Mahesh
Quoted 8 lines · Jani Nikula
Quoted 1 line · Mahesh Kumar
This is a Trybot Version of series.
What do you mean? Is this for upstream consideration or not?
BR,
Jani.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Maarten Lankhorst
AppliedOp 17-08-17 om 17:16 schreef Mahesh Kumar:
Quoted 5 lines
Hi,
My bad, I forgot to modify cover-letter before sending series to intel-gfx.
yes this is for upstream consideration.
Thanks, applied. I changed the enableddisabled in the debugfs patch to yesno, so if you want to write to it you can use yes or no, enabled or disabled isn't accepted by kstrtobool.
For future patches could you fix your git.name? It's using "Lastname, Firstname" but you sign off with Firstname Lastname. This confuses the maintainer tools slightly :)
Either way is fine, as long as you do it consistently.
Kind regards,
Maarten
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for Fixed16.16 wrapper cleanup & wm optimization (rev7)
In reply to Mahesh Kumar== Series Details ==
== Series Details ==
Series: Fixed16.16 wrapper cleanup & wm optimization (rev7)
URL : https://patchwork.freedesktop.org/series/25692/
State : success
== Summary ==
Series 25692v7 Fixed16.16 wrapper cleanup & wm optimization
https://patchwork.freedesktop.org/api/1.0/series/25692/revisions/7/mbox/
Test kms_cursor_legacy:
Subgroup basic-busy-flip-before-cursor-legacy:
fail -> PASS (fi-snb-2600) fdo#100215fdo#100215 https://bugs.freedesktop.org/show_bug.cgi?id=100215
fi-bdw-5557u total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:455s fi-bdw-gvtdvm total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:443s fi-blb-e6850 total:288 pass:224 dwarn:1 dfail:0 fail:0 skip:63 time:364s fi-bsw-n3050 total:288 pass:243 dwarn:0 dfail:0 fail:0 skip:45 time:553s fi-bwr-2160 total:288 pass:184 dwarn:0 dfail:0 fail:0 skip:104 time:253s fi-bxt-j4205 total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:523s fi-byt-j1900 total:288 pass:254 dwarn:1 dfail:0 fail:0 skip:33 time:527s fi-byt-n2820 total:288 pass:250 dwarn:1 dfail:0 fail:0 skip:37 time:519s fi-cfl-s total:288 pass:250 dwarn:4 dfail:0 fail:0 skip:34 time:475s fi-elk-e7500 total:288 pass:230 dwarn:0 dfail:0 fail:0 skip:58 time:444s fi-glk-2a total:288 pass:260 dwarn:0 dfail:0 fail:0 skip:28 time:609s fi-hsw-4770 total:288 pass:263 dwarn:0 dfail:0 fail:0 skip:25 time:444s fi-hsw-4770r total:288 pass:263 dwarn:0 dfail:0 fail:0 skip:25 time:428s fi-ilk-650 total:288 pass:229 dwarn:0 dfail:0 fail:0 skip:59 time:429s fi-ivb-3520m total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:512s fi-ivb-3770 total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:475s fi-kbl-7500u total:288 pass:264 dwarn:1 dfail:0 fail:0 skip:23 time:513s fi-kbl-7560u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:599s fi-kbl-r total:288 pass:261 dwarn:0 dfail:0 fail:0 skip:27 time:593s fi-pnv-d510 total:288 pass:223 dwarn:1 dfail:0 fail:0 skip:64 time:529s fi-skl-6260u total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:471s fi-skl-6700k total:288 pass:265 dwarn:0 dfail:0 fail:0 skip:23 time:543s fi-skl-6770hq total:288 pass:269 dwarn:0 dfail:0 fail:0 skip:19 time:519s fi-skl-gvtdvm total:288 pass:266 dwarn:0 dfail:0 fail:0 skip:22 time:445s fi-skl-x1585l total:288 pass:268 dwarn:0 dfail:0 fail:0 skip:20 time:488s fi-snb-2520m total:288 pass:251 dwarn:0 dfail:0 fail:0 skip:37 time:552s fi-snb-2600 total:288 pass:250 dwarn:0 dfail:0 fail:0 skip:38 time:414s
9dd459ef87a90495aac4cee73831f4cd694048ca drm-tip: 2017y-09m-04d-19h-10m-24s UTC integration manifest 2ada4271845d drm/i915/skl+: debugfs entry to control IPCe5f7eb82afae drm/i915/bxt+: Enable IPC supportd00d34749ef1 drm/i915/gen9+: Add has_ipc flag in device info structurea5c7fdb09e75 drm/i915/cnl: Extend WM workaround with IPC for CNL0d826d158d21 drm/i915/glk: IPC linetime watermark workaround for GLK5cd332faa41d drm/i915/gen10: Calculate and enable transition WM3dfced37c27b drm/i915/skl+: Optimize WM calculation1836ce27ff03 drm/i915: Fixed point fixed16 wrapper cleanup
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5578/
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for Fixed16.16 wrapper cleanup & wm optimization (rev7)
In reply to Mahesh Kumar== Series Details ==
== Series Details ==
Series: Fixed16.16 wrapper cleanup & wm optimization (rev7)
URL : https://patchwork.freedesktop.org/series/25692/
State : success
== Summary ==
Test perf:
Subgroup blocking:
fail -> PASS (shard-hsw) fdo#102252 +1
Test kms_setmode:
Subgroup basic:
fail -> PASS (shard-hsw) fdo#99912
Test tools_test:
Subgroup tools_test:
pass -> DMESG-WARN (shard-hsw) fdo#102543fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
fdo#102543 https://bugs.freedesktop.org/show_bug.cgi?id=102543
shard-hsw total:2265 pass:1233 dwarn:1 dfail:0 fail:15 skip:1016 time:9604s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5578/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx