vmci: fix duplicated code for different branches

PATCH New Gustavo A. R. Silva 1 participant 1 message Aug 18, 2017

Subsystems (2)

Char and misc drivers VMware VMCI driver

lore

Share & tools

lore

Gustavo A. R. Silva

author

2017-08-18 01:43 UTC #0 lore raw

PATCH 1/1 vmci: fix duplicated code for different branches

Refactor code in order to avoid identical code for different branches.

This issue was detected with the help of Coccinelle.

Addresses-Coverity-ID: 1226762

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
This issue was reported by Coverity and it was tested by compilation only.

 drivers/misc/vmw_vmci/vmci_queue_pair.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

drivers/misc/vmw_vmci/vmci_queue_pair.c +2 -8

index 06c4974..8af5c26 100644
@@ -2235,14 +2235,8 @@ int vmci_qp_broker_detach(struct vmci_handle handle, struct vmci_ctx *context)
 					handle.context, handle.resource,
 					result);
 
-			if (entry->vmci_page_files)
-				qp_host_unregister_user_memory(entry->produce_q,
-							       entry->
-							       consume_q);
-			else
-				qp_host_unregister_user_memory(entry->produce_q,
-							       entry->
-							       consume_q);
+			qp_host_unregister_user_memory(entry->produce_q,
+						       entry->consume_q);
 
 		}

Signature · 1 line

2.5.0