Skip to contentSkip to conversation

scsi: sd: remove duplicated setting of gd->minors

PATCH Applied weiping zhang 2 participants 3 messages Aug 18, 2017 – Aug 25, 2017 SCSI

lore
Share & tools
lore

weiping zhang

author
#0 lore raw

PATCH 1/1 scsi: sd: remove duplicated setting of gd->minors

gd->minors has been set when call alloc_disk() in sd_probe.

Signed-off-by weiping zhang <[email protected]>
---
 drivers/scsi/sd.c | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/sd.c +0 -1
index bea36ad..c18ca7a 100644
@@ -3223,7 +3223,6 @@ static void sd_probe_async(void *data, async_cookie_t cookie)
 
 	gd->major = sd_major((index & 0xf0) >> 4);
 	gd->first_minor = ((index & 0xf) << 4) | (index & 0xfff00);
-	gd->minors = SD_MINORS;
 
 	gd->fops = &sd_fops;
 	gd->private_data = &sdkp->driver;
Signature · 1 line
2.9.4
author
#1 lore raw
Quoted 22 lines · weiping zhang

gd->minors has been set when call alloc_disk() in sd_probe.

Signed-off-by weiping zhang <[email protected]>
---
 drivers/scsi/sd.c | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/sd.c +0 -1
index bea36ad..c18ca7a 100644
@@ -3223,7 +3223,6 @@ static void sd_probe_async(void *data, async_cookie_t cookie)
 
 	gd->major = sd_major((index & 0xf0) >> 4);
 	gd->first_minor = ((index & 0xf) << 4) | (index & 0xfff00);
-	gd->minors = SD_MINORS;
 
 	gd->fops = &sd_fops;
 	gd->private_data = &sdkp->driver;
Signature · 1 line
2.9.4

Hi Martin,

would you please look into this misc patch ?

Thanks

Applied
#2 lore raw
In reply to weiping zhang

weiping,

Quoted 1 line

gd->minors has been set when call alloc_disk() in sd_probe.

Applied to 4.14/scsi-queue. Thank you!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering