Skip to contentSkip to conversation

drm/panel: simple: Add missing panel_simple_unprepare calls

PATCH Applied Jonathan Liu 2 participants 2 messages Aug 7, 2017 – Aug 18, 2017

Subsystems (3)
DRM drivers DRM misc DRM panel drivers
lore
Share & tools
lore

Jonathan Liu

author
#0 lore raw

PATCH 1/1 drm/panel: simple: Add missing panel_simple_unprepare calls

During panel removal or system shutdown panel_simple_disable is called which disables the panel backlight but the panel is still powered due to missing calls to panel_simple_unprepare.

Fixes d02fd93e2cd8 ("drm/panel: simple - Disable panel on shutdown")
Cc [email protected] # v3.16+
Signed-off-by Jonathan Liu <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/gpu/drm/panel/panel-simple.c +2 -0
index 474fa759e06e..234af81fb3d0 100644
@@ -369,6 +369,7 @@ static int panel_simple_remove(struct device *dev)
 	drm_panel_remove(&panel->base);
 
 	panel_simple_disable(&panel->base);
+	panel_simple_unprepare(&panel->base);
 
 	if (panel->ddc)
 		put_device(&panel->ddc->dev);

@@ -384,6 +385,7 @@ static void panel_simple_shutdown(struct device *dev)
 	struct panel_simple *panel = dev_get_drvdata(dev);
 
 	panel_simple_disable(&panel->base);
+	panel_simple_unprepare(&panel->base);
 }
 
 static const struct drm_display_mode ampire_am_480272h3tmqw_t01h_mode = {
Signature · 1 line
2.13.2
Applied
#1 lore raw
Quoted 10 lines · Jonathan Liu

During panel removal or system shutdown panel_simple_disable is called which disables the panel backlight but the panel is still powered due to missing calls to panel_simple_unprepare.

Fixes d02fd93e2cd8 ("drm/panel: simple - Disable panel on shutdown")
Cc [email protected] # v3.16+
Signed-off-by Jonathan Liu <[email protected]>
---
 drivers/gpu/drm/panel/panel-simple.c | 2 ++
 1 file changed, 2 insertions(+)

Applied to drm-misc-next, thanks.

Thierry