Skip to contentSkip to conversation

board/boundarydevices: add mac parameter for BD-SDMAC in bootscript

PATCH New Gary Bisson 2 participants 3 messages Aug 18, 2017 – Aug 19, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board/boundarydevices: add mac parameter for BD-SDMAC in bootscript

Our new WiFi 802.11ac BT4.1 module (BD-SDMAC [1]) driver allows to override the wlan MAC address using a module parameter.

Since its driver is now included in our external repository [2], update the bootscript so it sets the parameter for that driver too.

As a FYI, $wlmac is based on Ethernet MAC address located in fuses.

[1] https://boundarydevices.com/product/bd_sdmac_wifi/
[2] https://github.com/boundarydevices/buildroot-external-boundary

---
 board/boundarydevices/common/6x_bootscript.txt | 1 +
 1 file changed, 1 insertion(+)
board/boundarydevices/common/6x_bootscript.txt +1 -0
index 2fc687aff4..af5822a88b 100644
@@ -106,6 +106,7 @@ fi
 
 if itest.s "x" != "x${wlmac}" ; then
 	setenv bootargs ${bootargs} wlcore.mac=${wlmac}
+	setenv bootargs ${bootargs} wlan.mac=${wlmac}
 fi
 
 if itest.s "x" != "x${gpumem}" ; then
Signature · 1 line
2.14.1
#1 lore raw

PATCH 1/1 board/boundarydevices: add mac parameter for BD-SDMAC in bootscript

Hello,

Quoted 8 lines · Gary Bisson

Our new WiFi 802.11ac BT4.1 module (BD-SDMAC [1]) driver allows to override the wlan MAC address using a module parameter.

Since its driver is now included in our external repository [2], update the bootscript so it sets the parameter for that driver too.

As a FYI, $wlmac is based on Ethernet MAC address located in fuses.

Quoted 7 lines

[1] https://boundarydevices.com/product/bd_sdmac_wifi/
[2] https://github.com/boundarydevices/buildroot-external-boundary

---
 board/boundarydevices/common/6x_bootscript.txt | 1 +
 1 file changed, 1 insertion(+)

Applied to master, thanks. However, I'm wondering why all this BD-SDMAC WiFi support packages remain out of tree in your BR2_EXTERNAL. Would it make sense to upstream them in Buildroot ?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 board/boundarydevices: add mac parameter for BD-SDMAC in bootscript

Hi Thomas,

Quoted 14 lines · Thomas Petazzoni

Hello,

Quoted 11 lines · Gary Bisson

Our new WiFi 802.11ac BT4.1 module (BD-SDMAC [1]) driver allows to override the wlan MAC address using a module parameter.

Since its driver is now included in our external repository [2], update the bootscript so it sets the parameter for that driver too.

As a FYI, $wlmac is based on Ethernet MAC address located in fuses.

[1] https://boundarydevices.com/product/bd_sdmac_wifi/
[2] https://github.com/boundarydevices/buildroot-external-boundary

Quoted 8 lines
Quoted 4 lines
---
 board/boundarydevices/common/6x_bootscript.txt | 1 +
 1 file changed, 1 insertion(+)

Applied to master, thanks. However, I'm wondering why all this BD-SDMAC WiFi support packages remain out of tree in your BR2_EXTERNAL. Would it make sense to upstream them in Buildroot ?

My main issue is that we've been asked, for dubious reasons, to hide the firmware files on a private git repo which requires to register to our website to get access to.

Moreover this driver is based on qcacld-2.0 repository [1] whose build breaks easily depending on the kernel you build against.

Finally it has only been tested on BD-SDMAC module so I'm not sure that many people are interested (except for our customers).

Let me know your thoughts.

Regards,
Gary

[1] https://source.codeaurora.org/quic/la/platform/vendor/qcom-opensource/wlan/qcacld-2.0/