Skip to contentSkip to conversation

mmc: renesas_sdhi: Add r8a7743/5 support

PATCH New Biju Das 6 participants 13 messages Aug 14, 2017 – Aug 22, 2017

Subsystems (2)
lore
Share & tools
lore

Biju Das

author
#0 lore raw

PATCH 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family.

---
This patch is compiled and tested againt linux next tag next-20170811. This patch depend on the driver change [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
https://patchwork.kernel.org/patch/9898611/

 Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/mmc/tmio_mmc.txt +4 -2
index 4fd8b7a..0d507ec 100644
@@ -15,6 +15,8 @@ Required properties:
 		"renesas,sdhi-r7s72100" - SDHI IP on R7S72100 SoC
 		"renesas,sdhi-r8a73a4" - SDHI IP on R8A73A4 SoC
 		"renesas,sdhi-r8a7740" - SDHI IP on R8A7740 SoC
+		"renesas,sdhi-r8a7743" - SDHI IP on R8A7743 SoC
+		"renesas,sdhi-r8a7745" - SDHI IP on R8A7745 SoC
 		"renesas,sdhi-r8a7778" - SDHI IP on R8A7778 SoC
 		"renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
 		"renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC
@@ -34,8 +36,8 @@ Required properties:
 	  "core" and "cd". If the controller only has 1 clock, naming is not
 	  required.
 	  Below is the number clocks for each supported SoC:
-	   1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
-	      R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
+	   1: SH73A0, R8A73A4, R8A7740, R8A7743, R8A7745, R8A7778, R8A7779,
+	      R8A7790, R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
 	   2: R7S72100
 
 Optional properties:
Signature · 1 line
1.9.1
maintainer
#1 lore raw

PATCH 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

Quoted 11 lines · Biju Das

Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family.

---
This patch is compiled and tested againt linux next tag next-20170811. This patch depend on the driver change [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support
https://patchwork.kernel.org/patch/9898611/

Quoted 2 lines
 Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
#2 lore raw

PATCH 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

In reply to Biju Das

Documentation/devicetree/bindings/mmc/tmio_mmc.txt Required properties: · line 41

Quoted 7 lines
Documentation/devicetree/bindings/mmc/tmio_mmc.txt +2 -2
 	  Below is the number clocks for each supported SoC:
-	   1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
-	      R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
+	   1: SH73A0, R8A73A4, R8A7740, R8A7743, R8A7745, R8A7778, R8A7779,
+	      R8A7790, R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
 	   2: R7S72100

Hmm, maybe we should convert this to only listing SoCs with two clocks? That will be easier to maintaine since the majority seems to have one.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170821/024ba7bd/attachment.sig>

author
#3 lore raw

PATCH 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

Quoted 20 lines

-----Original Message-----
From: Wolfram Sang [mailto:wsa at the-dreams.de]
Sent: 21 August 2017 09:25
To: Biju Das <[email protected]>
Cc: Ulf Hansson <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Simon Horman <[email protected]>; Magnus Damm <[email protected]>; Chris Paterson <[email protected]>; Wolfram Sang <[email protected]>; devicetree at vger.kernel.org; linux- renesas-soc at vger.kernel.org; linux-arm-kernel at lists.infradead.org; linux- mmc at vger.kernel.org
Subject: Re: [PATCH ] mmc: renesas_sdhi: Add r8a7743/5 support

Documentation/devicetree/bindings/mmc/tmio_mmc.txt Required properties:

Quoted 4 lines

Below is the number clocks for each supported SoC:

Documentation/devicetree/bindings/mmc/tmio_mmc.txt +1 -2
-   1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
-      R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
+   1: SH73A0, R8A73A4, R8A7740, R8A7743, R8A7745, R8A7778,
Quoted 7 lines

R8A7779,

Quoted 1 line

+ R8A7790, R8A7791, R8A7792, R8A7793, R8A7794, R8A7795,

R8A7796

Quoted 1 line
    2: R7S72100

Hmm, maybe we should convert this to only listing SoCs with two clocks? That will be easier to maintaine since the majority seems to have one.

Ok. I will send v2 with the suggested changes.

Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

author
#4 lore raw

PATCH v2 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

In reply to Biju Das

Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family.

---
v1->v2
-Modified the listing SoC's description related to SoC
with 1 Clock and 2 Clocks

This patch is compiled and tested against linux next tag next-20170817.

 Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/mmc/tmio_mmc.txt +5 -4
index 4fd8b7a..1e3106e 100644
@@ -15,6 +15,8 @@ Required properties:
 		"renesas,sdhi-r7s72100" - SDHI IP on R7S72100 SoC
 		"renesas,sdhi-r8a73a4" - SDHI IP on R8A73A4 SoC
 		"renesas,sdhi-r8a7740" - SDHI IP on R8A7740 SoC
+		"renesas,sdhi-r8a7743" - SDHI IP on R8A7743 SoC
+		"renesas,sdhi-r8a7745" - SDHI IP on R8A7745 SoC
 		"renesas,sdhi-r8a7778" - SDHI IP on R8A7778 SoC
 		"renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
 		"renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC
@@ -33,10 +35,9 @@ Required properties:
 	  If 2 clocks are specified by the hardware, you must name them as
 	  "core" and "cd". If the controller only has 1 clock, naming is not
 	  required.
-	  Below is the number clocks for each supported SoC:
-	   1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
-	      R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
-	   2: R7S72100
+	  Most supported SoCs only have 1 clock. Devices which have more
+	  than 1 clock are listed below:
+	  2: R7S72100"
 
 Optional properties:
 - toshiba,mmc-wrprotect-disable: write-protect detection is unavailable
Signature · 1 line
1.9.1
#5 lore raw

PATCH v2 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

Hi Biju,

Quoted 29 lines · Biju Das

Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family.

---
v1->v2
-Modified the listing SoC's description related to SoC
with 1 Clock and 2 Clocks

This patch is compiled and tested against linux next tag next-20170817.

 Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/mmc/tmio_mmc.txt +2 -0
index 4fd8b7a..1e3106e 100644
@@ -15,6 +15,8 @@ Required properties:
                "renesas,sdhi-r7s72100" - SDHI IP on R7S72100 SoC
                "renesas,sdhi-r8a73a4" - SDHI IP on R8A73A4 SoC
                "renesas,sdhi-r8a7740" - SDHI IP on R8A7740 SoC
+               "renesas,sdhi-r8a7743" - SDHI IP on R8A7743 SoC
+               "renesas,sdhi-r8a7745" - SDHI IP on R8A7745 SoC
                "renesas,sdhi-r8a7778" - SDHI IP on R8A7778 SoC
                "renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
                "renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC

Documentation/devicetree/bindings/mmc/tmio_mmc.txt Required properties: · line 38

Quoted 8 lines
Documentation/devicetree/bindings/mmc/tmio_mmc.txt +1 -4
@@ -33,10 +35,9 @@ Required properties:
          If 2 clocks are specified by the hardware, you must name them as
          "core" and "cd". If the controller only has 1 clock, naming is not
          required.
-         Below is the number clocks for each supported SoC:
-          1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
-             R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
-          2: R7S72100
+         Most supported SoCs only have 1 clock. Devices which have more

That is actually mentioned in the paragraph above:

- clocks: Most controllers only have 1 clock source per channel. However, on some variations of this controller, the internal card detection logic that exists in this controller is sectioned off to be run by a separate second clock source to allow the main core clock to be turned off to save power.

so I suggest just integrating the (short) list in that paragraph.

Documentation/devicetree/bindings/mmc/tmio_mmc.txt Required properties: · line 40

Quoted 2 lines
Documentation/devicetree/bindings/mmc/tmio_mmc.txt +2 -0
+         than 1 clock are listed below:
+         2: R7S72100"

Bogus trailing double quote.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

author
#6 lore raw

PATCH v2 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

Quoted 68 lines

-----Original Message-----
From: devicetree-owner at vger.kernel.org [mailto:devicetree- owner at vger.kernel.org] On Behalf Of Geert Uytterhoeven
Sent: 21 August 2017 12:30
To: Biju Das <[email protected]>
Cc: Ulf Hansson <[email protected]>; Rob Herring <[email protected]>; Mark Rutland <[email protected]>; Wolfram Sang <wsa@the- dreams.de>; Simon Horman <[email protected]>; Magnus Damm <[email protected]>; Chris Paterson <[email protected]>; devicetree at vger.kernel.org; Linux-Renesas <[email protected]>; linux-arm-kernel at lists.infradead.org; Linux MMC List <[email protected]>
Subject: Re: [PATCH v2] mmc: renesas_sdhi: Add r8a7743/5 support

Hi Biju,

Quoted 29 lines · Biju Das

Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family.

---
v1->v2
-Modified the listing SoC's description related to SoC
with 1 Clock and 2 Clocks

This patch is compiled and tested against linux next tag next-20170817.

 Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/mmc/tmio_mmc.txt +2 -0
index 4fd8b7a..1e3106e 100644
@@ -15,6 +15,8 @@ Required properties:
                "renesas,sdhi-r7s72100" - SDHI IP on R7S72100 SoC
                "renesas,sdhi-r8a73a4" - SDHI IP on R8A73A4 SoC
                "renesas,sdhi-r8a7740" - SDHI IP on R8A7740 SoC
+               "renesas,sdhi-r8a7743" - SDHI IP on R8A7743 SoC
+               "renesas,sdhi-r8a7745" - SDHI IP on R8A7745 SoC
                "renesas,sdhi-r8a7778" - SDHI IP on R8A7778 SoC
                "renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
                "renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC @@

Documentation/devicetree/bindings/mmc/tmio_mmc.txt Required properties:

Quoted 10 lines
Documentation/devicetree/bindings/mmc/tmio_mmc.txt +2 -5
-33,10 +35,9 @@ Required properties:
          If 2 clocks are specified by the hardware, you must name them as
          "core" and "cd". If the controller only has 1 clock, naming is not
          required.
-         Below is the number clocks for each supported SoC:
-          1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
-             R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
-          2: R7S72100
+         Most supported SoCs only have 1 clock. Devices which have
+ more

That is actually mentioned in the paragraph above:

- clocks: Most controllers only have 1 clock source per channel. However, on some variations of this controller, the internal card detection logic that exists in this controller is sectioned off to be run by a separate second clock source to allow the main core clock to be turned off to save power.

Quoted 6 lines

so I suggest just integrating the (short) list in that paragraph.

Documentation/devicetree/bindings/mmc/tmio_mmc.txt Required properties: · line 40

Quoted 2 lines
Documentation/devicetree/bindings/mmc/tmio_mmc.txt +2 -0
+         than 1 clock are listed below:
+         2: R7S72100"

Bogus trailing double quote.

Thanks. I will send v3 with above changes.

Quoted 8 lines

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux- m68k.org

Quoted 7 lines

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo at vger.kernel.org More majordomo info at
http://vger.kernel.org/majordomo-info.html

Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

author
#7 lore raw

PATCH v3 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

In reply to Geert Uytterhoeven

Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family.

---
v1->v2
- Modified the listing SoC's description related to SoC with 1 Clock and 2 Clocks
v2->v3
- Fixed the trailing double quote.
- Updated listing SoC's description.

This patch is compiled and tested against linux next tag next-20170817.

 Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/mmc/tmio_mmc.txt +4 -4
index 4fd8b7a..54ef642 100644
@@ -15,6 +15,8 @@ Required properties:
 		"renesas,sdhi-r7s72100" - SDHI IP on R7S72100 SoC
 		"renesas,sdhi-r8a73a4" - SDHI IP on R8A73A4 SoC
 		"renesas,sdhi-r8a7740" - SDHI IP on R8A7740 SoC
+		"renesas,sdhi-r8a7743" - SDHI IP on R8A7743 SoC
+		"renesas,sdhi-r8a7745" - SDHI IP on R8A7745 SoC
 		"renesas,sdhi-r8a7778" - SDHI IP on R8A7778 SoC
 		"renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
 		"renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC
@@ -33,10 +35,8 @@ Required properties:
 	  If 2 clocks are specified by the hardware, you must name them as
 	  "core" and "cd". If the controller only has 1 clock, naming is not
 	  required.
-	  Below is the number clocks for each supported SoC:
-	   1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
-	      R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
-	   2: R7S72100
+	  Devices which have more than 1 clock are listed below:
+	  2: R7S72100
 
 Optional properties:
 - toshiba,mmc-wrprotect-disable: write-protect detection is unavailable
Signature · 1 line
1.9.1
#8 lore raw

PATCH v3 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

Quoted 4 lines · Biju Das

Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170821/ce9d0c85/attachment.sig>

#9 lore raw

PATCH v3 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

Quoted 7 lines · Wolfram Sang
Quoted 4 lines · Biju Das

Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family.

Its probably time for some fallback compatibility strings but I think that should be done as follow-up (likely by me) in a considered way. So this patch is fine in my books.

Applied
#10 lore raw

PATCH v3 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

In reply to Biju Das
Quoted 4 lines · Biju Das

Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family.

Thanks, applied for next!

Kind regards
Uffe

Quoted 43 lines

---
v1->v2
- Modified the listing SoC's description related to SoC with 1 Clock and 2 Clocks
v2->v3
- Fixed the trailing double quote.
- Updated listing SoC's description.

This patch is compiled and tested against linux next tag next-20170817.

 Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/mmc/tmio_mmc.txt +4 -5
index 4fd8b7a..54ef642 100644
@@ -15,6 +15,8 @@ Required properties:
                "renesas,sdhi-r7s72100" - SDHI IP on R7S72100 SoC
                "renesas,sdhi-r8a73a4" - SDHI IP on R8A73A4 SoC
                "renesas,sdhi-r8a7740" - SDHI IP on R8A7740 SoC
+               "renesas,sdhi-r8a7743" - SDHI IP on R8A7743 SoC
+               "renesas,sdhi-r8a7745" - SDHI IP on R8A7745 SoC
                "renesas,sdhi-r8a7778" - SDHI IP on R8A7778 SoC
                "renesas,sdhi-r8a7779" - SDHI IP on R8A7779 SoC
                "renesas,sdhi-r8a7790" - SDHI IP on R8A7790 SoC
@@ -33,10 +35,8 @@ Required properties:
          If 2 clocks are specified by the hardware, you must name them as
          "core" and "cd". If the controller only has 1 clock, naming is not
          required.
-         Below is the number clocks for each supported SoC:
-          1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
-             R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
-          2: R7S72100
+         Devices which have more than 1 clock are listed below:
+         2: R7S72100
 
 Optional properties:
 - toshiba,mmc-wrprotect-disable: write-protect detection is unavailable
--

1.9.1

#11 lore raw

PATCH v2 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

In reply to Biju Das

Documentation/devicetree/bindings/mmc/tmio_mmc.txt Required properties: · line 40

Quoted 8 lines
Documentation/devicetree/bindings/mmc/tmio_mmc.txt +3 -4
-	  Below is the number clocks for each supported SoC:
-	   1: SH73A0, R8A73A4, R8A7740, R8A7778, R8A7779, R8A7790
-	      R8A7791, R8A7792, R8A7793, R8A7794, R8A7795, R8A7796
-	   2: R7S72100
+	  Most supported SoCs only have 1 clock. Devices which have more
+	  than 1 clock are listed below:
+	  2: R7S72100"

I like this, but stray " at the end of the line?

With that fixed:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170821/c86ac8bf/attachment.sig>

maintainer
#12 lore raw

PATCH v2 1/1 mmc: renesas_sdhi: Add r8a7743/5 support

In reply to Biju Das
Quoted 9 lines · Biju Das

Add support for r8a7743/5 SoC. Renesas RZ/G1[ME] (R8A7743/5) SDHI is identical to the R-Car Gen2 family.

---
v1->v2
-Modified the listing SoC's description related to SoC
with 1 Clock and 2 Clocks

Quoted 5 lines

This patch is compiled and tested against linux next tag next-20170817.

 Documentation/devicetree/bindings/mmc/tmio_mmc.txt | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)