Skip to contentSkip to conversation

usb: Add device quirk for Logitech HD Pro Webcam C920-C

PATCH Superseded Dmitry Fleytman 2 participants 3 messages Aug 21, 2017 – Aug 25, 2017 USB

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: Add device quirk for Logitech HD Pro Webcam C920-C

Commit e0429362ab15
("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") introduced quirk to workaround an issue with some Logitech webcams.

Apparently model C920-C has the same issue so applying the same quirk as well.

See aforementioned commit message for detailed explanation of the problem.

---
 drivers/usb/core/quirks.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/core/quirks.c +1 -0
index 574da2b..36d4841 100644
@@ -59,6 +59,7 @@ static const struct usb_device_id usb_quirk_list[] = {
 
 	/* Logitech HD Pro Webcams C920 and C930e */
 	{ USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
+	{ USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
 	{ USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
 
 	/* Logitech ConferenceCam CC3000e */
Signature · 1 line
2.7.4
#1 lore raw
Quoted 6 lines · Dmitry Fleytman

Commit e0429362ab15
("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") introduced quirk to workaround an issue with some Logitech webcams.

Apparently model C920-C has the same issue so applying the same quirk as well.

I think it's better to also mention "C920-C" in the comment section.

Quoted 23 lines

See aforementioned commit message for detailed explanation of the problem.

---
 drivers/usb/core/quirks.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/core/quirks.c +1 -1
index 574da2b..36d4841 100644
@@ -59,6 +59,7 @@ static const struct usb_device_id usb_quirk_list[] = {
 
        /* Logitech HD Pro Webcams C920 and C930e */
        { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
+       { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
        { USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
 
        /* Logitech ConferenceCam CC3000e */
--

2.7.4

#2 lore raw
Quoted 12 lines · Kai-Heng Feng
Quoted 6 lines · Dmitry Fleytman

Commit e0429362ab15
("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e") introduced quirk to workaround an issue with some Logitech webcams.

Apparently model C920-C has the same issue so applying the same quirk as well.

I think it's better to also mention "C920-C" in the comment section.

I agree. See v2 (just sent).

Thanks,
Dmitry

Quoted 24 lines
Quoted 24 lines

See aforementioned commit message for detailed explanation of the problem.

---
drivers/usb/core/quirks.c | 1 +

1 file changed, 1 insertion(+)
drivers/usb/core/quirks.c +1 -1
index 574da2b..36d4841 100644
@@ -59,6 +59,7 @@ static const struct usb_device_id usb_quirk_list[] = {
 
       /* Logitech HD Pro Webcams C920 and C930e */
       { USB_DEVICE(0x046d, 0x082d), .driver_info = USB_QUIRK_DELAY_INIT },
+       { USB_DEVICE(0x046d, 0x0841), .driver_info = USB_QUIRK_DELAY_INIT },
       { USB_DEVICE(0x046d, 0x0843), .driver_info = USB_QUIRK_DELAY_INIT },
 
       /* Logitech ConferenceCam CC3000e */
--

2.7.4