qf: Deprecate the use of qf without any subcommand.
PATCH 1/30 qf: Deprecate the use of qf without any subcommand.
These sequences here are already covered by qf git subcommand. I double checked and confirmed that our continuously rebasing bot does not use this qf directly here and I'm not aware of anyone else using it. So let's remove it so we can start handling everything with subcommands (dim style).
--- qf | 7 +------ qf.rst | 7 ------- 2 files changed, 1 insertion(+), 13 deletions(-)
qf +1 -6
@@ -480,12 +480,7 @@ case "$1" in shift gitk "$@" ;; - help) - qf_help - ;; *) - cd_toplevel - cd patches - git "$@" + qf_help ;; esac
qf.rst +0 -7
@@ -233,13 +233,6 @@ help ---- This help text here -all other subcommands - IMPORTANT ---------------------------------- -Any other subcommands are executed directly in the quilt patches -directory as git commans. When using quilt flow in scripts it is -import to use the explicit forwarding to avoid clashes with -furture extensions. - CONTRIBUTING ============
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/30 qf: Introduce subcommand and aliases
Let's start refreshing qf a bit by introducing subcommand and aliases like dim.
The goal is to have an standardized qf and dim where both have same style, documentation and also that is in a format that we can easily introduce to make check.
Actually all new code here is a simple copy from dim directly with s/dim/qf.
This patch also introduce qf_usage, qf_list_commands qf_list_aliases and already
move qf_help from the case parse $1 to a
subcommand.
--- Makefile | 5 ++++ qf | 102 +++++++++++++++++++++++++++++++++++++++++++++++---------------- qf.rst | 14 +++++++++ 3 files changed, 96 insertions(+), 25 deletions(-)
Makefile +5 -0
@@ -51,6 +51,11 @@ mancheck: echo "$@: $$cmd not documented"; \ fi \ done + @for cmd in $$(./qf list-commands); do \ + if ! grep -q "^$$cmd" qf.rst; then \ + echo "$@: $$cmd not documented"; \ + fi \ + done rst2man --strict --no-raw dim.rst >/dev/null rst2man --strict --no-raw qf.rst >/dev/null
qf +77 -25
112 lines not on this page · raw message
qf.rst +14 -0
@@ -95,6 +95,16 @@ $ qf git bisect new|old COMMANDS ======== +list-aliases +------------ +List all aliases for the subcommand names. + +See \$qf_alias_<alias> under ENVIRONMENT below on how to define aliases. + +list-commands +------------- +List all subcommand names, including aliases. + setup [*branch-name*] --------------------- Sets up a git repository for this quilt worflow script by
@@ -233,6 +243,10 @@ help ---- This help text here +usage +----- +Short form usage help listing all subcommands. + CONTRIBUTING ============
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/30 qf: Move "setup" from case to new subcommand.
In reply to Rodrigo ViviNo functional change, only moving from the
case to its own function, with the arguments now shifted.
It seems that the argument for branch_init is useles, but I will keep it for now to avoid any change that is not related to the new subcommand scheme.
--- qf | 61 +++++++++++++++++++++++++++++++------------------------------ 1 file changed, 31 insertions(+), 30 deletions(-)
qf +31 -30
@@ -170,36 +170,6 @@ function quilt_clean_check } case "$1" in - setup) - cd `git rev-parse --show-toplevel` - - if [[ -d patches ]] ; then - if [[ ! -d patches/.git ]] ; then - echo patches/ directory exists, but not initialized. - echo Please fix manually. - exit 11 - fi - - echo Quilt repo already set up. - else - repo_init - fi - - - if [[ -n $2 ]] ; then - if ! git branch | grep $2 &> /dev/null ; then - echo $2 is not a branch in the main repo, aborting. - exit 13 - fi - - branch=$2 - quilt_branch=$QUILT_PREFIX$branch - baseline=`git rev-parse $2` - remote=`git config branch.$branch.remote` - - branch_init $3 - fi - ;; checkout|co) cd_toplevel
@@ -470,6 +440,37 @@ else shift fi +function qf_setup +{ + cd `git rev-parse --show-toplevel` + + if [[ -d patches ]] ; then + if [[ ! -d patches/.git ]] ; then + echo patches/ directory exists, but not initialized. + echo Please fix manually. + exit 11 + fi + + echo Quilt repo already set up. + else + repo_init + fi + + if [[ -n $1 ]] ; then + if ! git branch | grep $1 &> /dev/null ; then + echo $1 is not a branch in the main repo, aborting. + exit 13 + fi + + branch=$1 + quilt_branch=$QUILT_PREFIX$branch + baseline=`git rev-parse $1` + remote=`git config branch.$branch.remote` + + branch_init $2 + fi +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/30 qf: Move "checkout" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the
case to its own function, with the arguments now shifted.
--- qf | 47 +++++++++++++++++++++++++---------------------- 1 file changed, 25 insertions(+), 22 deletions(-)
qf +25 -22
@@ -170,28 +170,6 @@ function quilt_clean_check } case "$1" in - checkout|co) - cd_toplevel - - cd patches - # -q to avoid status checks - the strange remote situation - # confuses git and takes forever to analyze - if git rev-parse $2 &> /dev/null ; then - # raw mode - quilt_branch=$2 - else - # quilt branch mode - quilt_branch=$QUILT_PREFIX$2 - fi - git checkout $quilt_branch -q - cd .. - # error code 2 means no patches removed, which is ok - quiet_pop_all -f - baseline=`source patches/config ; echo $BASELINE` - checkout_baseline - quilt push -a -q > /dev/null - echo Now at `quilt top` - ;; rebase) cd_toplevel repo_check 0
@@ -471,6 +449,31 @@ function qf_setup fi } +qf_alias_co=checkout +function qf_checkout +{ + cd_toplevel + + cd patches + # -q to avoid status checks - the strange remote situation + # confuses git and takes forever to analyze + if git rev-parse $1 &> /dev/null ; then + # raw mode + quilt_branch=$1 + else + # quilt branch mode + quilt_branch=$QUILT_PREFIX$1 + fi + git checkout $quilt_branch -q + cd .. + # error code 2 means no patches removed, which is ok + quiet_pop_all -f + baseline=`source patches/config ; echo $BASELINE` + checkout_baseline + quilt push -a -q > /dev/null + echo Now at `quilt top` +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/30 qf: Move "rebase" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function, with the arguments now shifted.
--- qf | 43 ++++++++++++++++++++++--------------------- 1 file changed, 22 insertions(+), 21 deletions(-)
qf +22 -21
@@ -170,27 +170,6 @@ function quilt_clean_check } case "$1" in - rebase) - cd_toplevel - repo_check 0 - - if [[ -z $2 ]] ; then - echo No commit given - exit 4 - fi - - new_baseline=`git rev-parse $2` - - current_top=`quilt top` - quiet_pop_all - echo Resetting baseline to $new_baseline - git reset --hard $new_baseline - sed -e "s/BASELINE=.*$/BASELINE=$new_baseline/" -i patches/config - git update-ref refs/baselines/$branch/$new_baseline $new_baseline - - quilt push $current_top -q - - ;; refresh) cd_toplevel repo_check 0
@@ -474,6 +453,28 @@ function qf_checkout echo Now at `quilt top` } +function qf_rebase +{ + cd_toplevel + repo_check 0 + + if [[ -z $1 ]] ; then + echo No commit given + exit 4 + fi + + new_baseline=`git rev-parse $1` + + current_top=`quilt top` + quiet_pop_all + echo Resetting baseline to $new_baseline + git reset --hard $new_baseline + sed -e "s/BASELINE=.*$/BASELINE=$new_baseline/" -i patches/config + git update-ref refs/baselines/$branch/$new_baseline $new_baseline + + quilt push $current_top -q +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 6/30 qf: Move "refresh" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function.
--- qf | 42 ++++++++++++++++++++++-------------------- 1 file changed, 22 insertions(+), 20 deletions(-)
qf +22 -20
@@ -170,26 +170,6 @@ function quilt_clean_check } case "$1" in - refresh) - cd_toplevel - repo_check 0 - - changed_files=`qf git status --porcelain | wc -l` - - if [[ $changed_files -gt 0 ]] ; then - echo Quilt patch dir not clean, aborting - exit - fi - - quiet_pop_all - - while quilt push ; do - quilt refresh - done - - # ignore "nothing to commit" - qf git commit -a -m "Refreshing all patches." || true - ;; clean-patches) cd_toplevel repo_check 0
@@ -475,6 +455,28 @@ function qf_rebase quilt push $current_top -q } +function qf_refresh +{ + cd_toplevel + repo_check 0 + + changed_files=`qf git status --porcelain | wc -l` + + if [[ $changed_files -gt 0 ]] ; then + echo Quilt patch dir not clean, aborting + exit + fi + + quiet_pop_all + + while quilt push ; do + quilt refresh + done + + # ignore "nothing to commit" + qf git commit -a -m "Refreshing all patches." || true +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 7/30 qf: Move "export" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function.
--- qf | 111 +++++++++++++++++++++++++++++++++++---------------------------------- 1 file changed, 57 insertions(+), 54 deletions(-)
qf +57 -54
@@ -170,60 +170,6 @@ function quilt_clean_check } case "$1" in - clean-patches) - cd_toplevel - repo_check 0 - - for patch in patches/*.patch ; do - if grep "^${patch##patches/}$" patches/series &> /dev/null ; then - continue - fi - echo No reference to $patch, deleting it. - rm $patch - done - ;; - export) - cd_toplevel - repo_check 0 - quilt_clean_check - - username=$GIT_COMMMITTER_NAME - username=${username:-`git config user.name || true`} - username=${username:-`getent passwd $USER | cut -d: -f 5 | cut -d, -f 1 || true`} - useremail=$GIT_COMMMITTER_EMAIL - useremail=${useremail:-`git config user.email || true`} - useremail=${useremail:-$EMAIL} - - if [[ -z $useremail || -z $username ]] ; then - echo User name/email not found, please fix your config - exit 17 - fi - - echo Exporting quilt pile $branch - - quiet_pop_all - - git reset --hard - if [[ $quilt_branch = HEAD ]] ; then - git checkout --detach - else - git checkout -B $branch - fi - - git quiltimport --author "$username <$useremail>" - - quilt_ref=`cd patches ; git rev-parse --abbrev-ref HEAD` - quilt_sha_abbrev=`cd patches ; git rev-parse --short HEAD` - quilt_sha=`cd patches ; git rev-parse HEAD` - - git update-ref -m "export $quilt_ref:$quilt_sha_abbrev to $branch" refs/QUILT_EXPORT `git rev-parse HEAD` - git notes --ref quilt add -m "Quilt-Commit: $quilt_sha" $branch - - checkout_baseline - - quilt push -a -q - - ;; export-visualize|ev) cd_toplevel repo_check 1
@@ -477,6 +423,63 @@ function qf_refresh qf git commit -a -m "Refreshing all patches." || true } +function qf_clean_patches +{ + cd_toplevel + repo_check 0 + + for patch in patches/*.patch ; do + if grep "^${patch##patches/}$" patches/series &> /dev/null ; then + continue + fi + echo No reference to $patch, deleting it. + rm $patch + done +} + +function qf_export +{ + cd_toplevel + repo_check 0 + quilt_clean_check + + username=$GIT_COMMMITTER_NAME + username=${username:-`git config user.name || true`} + username=${username:-`getent passwd $USER | cut -d: -f 5 | cut -d, -f 1 || true`} + useremail=$GIT_COMMMITTER_EMAIL + useremail=${useremail:-`git config user.email || true`} + useremail=${useremail:-$EMAIL} + + if [[ -z $useremail || -z $username ]] ; then + echo User name/email not found, please fix your config + exit 17 + fi + + echo Exporting quilt pile $branch + + quiet_pop_all + + git reset --hard + if [[ $quilt_branch = HEAD ]] ; then + git checkout --detach + else + git checkout -B $branch + fi + + git quiltimport --author "$username <$useremail>" + + quilt_ref=`cd patches ; git rev-parse --abbrev-ref HEAD` + quilt_sha_abbrev=`cd patches ; git rev-parse --short HEAD` + quilt_sha=`cd patches ; git rev-parse HEAD` + + git update-ref -m "export $quilt_ref:$quilt_sha_abbrev to $branch" refs/QUILT_EXPORT `git rev-parse HEAD` + git notes --ref quilt add -m "Quilt-Commit: $quilt_sha" $branch + + checkout_baseline + + quilt push -a -q +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 8/30 qf: Move "export-visualize" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function.
--- qf | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
qf +9 -6
@@ -170,12 +170,6 @@ function quilt_clean_check } case "$1" in - export-visualize|ev) - cd_toplevel - repo_check 1 - - gitk QUILT_EXPORT ^$baseline - ;; push) cd_toplevel repo_check 0
@@ -480,6 +474,15 @@ function qf_export quilt push -a -q } +qf_alias_ev=export-visualize +function qf_export_visualize +{ + cd_toplevel + repo_check 1 + + gitk QUILT_EXPORT ^$baseline +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 9/30 qf: Move "push" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function.
--- qf | 56 +++++++++++++++++++++++++++++--------------------------- 1 file changed, 29 insertions(+), 27 deletions(-)
qf +29 -27
@@ -170,33 +170,6 @@ function quilt_clean_check } case "$1" in - push) - cd_toplevel - repo_check 0 - quilt_clean_check - - remote=`git config branch.$branch.remote` - - export_quilt_sha=`git notes --ref=quilt show $branch | grep Quilt-Commit | cut -d ' ' -f 2` - quilt_sha=`cd patches ; git rev-parse $quilt_branch` - - if [[ $export_quilt_sha != $quilt_sha ]] ; then - echo Quilt export is out of date, aborting - echo $export_quilt_sha - echo $quilt_sha - exit 18 - fi - - cd patches - git push $remote $quilt_branch:refs/quilts/$branch - cd .. - - # The exported branch is a rebasing one, so force the push. - # Everything else shouldn't ever need a force-push. - git push $remote $branch -f - - git push $remote refs/baselines/$branch/*:refs/baselines/$branch/* - ;; fetch) cd_toplevel repo_check 0
@@ -483,6 +456,35 @@ function qf_export_visualize gitk QUILT_EXPORT ^$baseline } +function qf_push +{ + cd_toplevel + repo_check 0 + quilt_clean_check + + remote=`git config branch.$branch.remote` + + export_quilt_sha=`git notes --ref=quilt show $branch | grep Quilt-Commit | cut -d ' ' -f 2` + quilt_sha=`cd patches ; git rev-parse $quilt_branch` + + if [[ $export_quilt_sha != $quilt_sha ]] ; then + echo Quilt export is out of date, aborting + echo $export_quilt_sha + echo $quilt_sha + exit 18 + fi + + cd patches + git push $remote $quilt_branch:refs/quilts/$branch + cd .. + + # The exported branch is a rebasing one, so force the push. + # Everything else shouldn't ever need a force-push. + git push $remote $branch -f + + git push $remote refs/baselines/$branch/*:refs/baselines/$branch/* +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 10/30 qf: Move "fetch" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function.
--- qf | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-)
qf +16 -14
@@ -170,20 +170,6 @@ function quilt_clean_check } case "$1" in - fetch) - cd_toplevel - repo_check 0 - - remote=`git config branch.$branch.remote` - - cd patches - git fetch $remote - cd .. - - git fetch $remote - - git fetch $remote - ;; pull) cd_toplevel repo_check 0
@@ -485,6 +471,22 @@ function qf_push git push $remote refs/baselines/$branch/*:refs/baselines/$branch/* } +function qf_fetch +{ + cd_toplevel + repo_check 0 + + remote=`git config branch.$branch.remote` + + cd patches + git fetch $remote + cd .. + + git fetch $remote + + git fetch $remote +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 11/30 qf: Move "pull" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function, with the arguments now shifted.
--- qf | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-)
qf +17 -15
@@ -170,21 +170,6 @@ function quilt_clean_check } case "$1" in - pull) - cd_toplevel - repo_check 0 - - qf fetch - cd patches - - if [[ $2 == "--rebase" ]] ; then - git rebase @{upstream} - else - git merge @{upstream} - fi - - qf co - ;; stage) cd_toplevel repo_check 1
@@ -487,6 +472,23 @@ function qf_fetch git fetch $remote } +function qf_pull +{ + cd_toplevel + repo_check 0 + + qf fetch + cd patches + + if [[ $1 == "--rebase" ]] ; then + git rebase @{upstream} + else + git merge @{upstream} + fi + + qf co +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 12/30 qf: Move "stage" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function.
--- qf | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-)
qf +10 -8
@@ -170,14 +170,6 @@ function quilt_clean_check } case "$1" in - stage) - cd_toplevel - repo_check 1 - - git reset --mixed &> /dev/null - quilt applied 2> /dev/null | xargs git apply --cached - echo All applied patches successfully staged - ;; wiggle-push|wp) cd_toplevel repo_check 1
@@ -489,6 +481,16 @@ function qf_pull qf co } +function qf_stage +{ + cd_toplevel + repo_check 1 + + git reset --mixed &> /dev/null + quilt applied 2> /dev/null | xargs git apply --cached + echo All applied patches successfully staged +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 13/30 qf: Move "wiggle-push" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function.
--- qf | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-)
qf +20 -17
@@ -170,23 +170,6 @@ function quilt_clean_check } case "$1" in - wiggle-push|wp) - cd_toplevel - repo_check 1 - - conflict_files=`quilt push -f | grep "saving rejects" | sed -e "s/.*saving rejects to file \(.*\)/\1/"` - - if [[ $conflict_files != "" ]] ; then - echo conflicts found! - fi - - for file in $conflict_files ; do - echo wiggling in ${file%.rej}: - #cat $file - rm -f ${file%.rej}.porig - wiggle -r ${file%.rej} $file || true - done - ;; resolved) quilt refresh quilt header -e
@@ -491,6 +474,26 @@ function qf_stage echo All applied patches successfully staged } +qf_alias_wp=wiggle_push +function qf_wiggle_push +{ + cd_toplevel + repo_check 1 + + conflict_files=`quilt push -f | grep "saving rejects" | sed -e "s/.*saving rejects to file \(.*\)/\1/"` + + if [[ $conflict_files != "" ]] ; then + echo conflicts found! + fi + + for file in $conflict_files ; do + echo wiggling in ${file%.rej}: + #cat $file + rm -f ${file%.rej}.porig + wiggle -r ${file%.rej} $file || true + done +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 14/30 qf: Move "resolved" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function.
--- qf | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
qf +6 -4
@@ -170,10 +170,6 @@ function quilt_clean_check } case "$1" in - resolved) - quilt refresh - quilt header -e - ;; apply) if [[ "$2" == "" ]] ; then echo No patch name given, aborting.
@@ -494,6 +490,12 @@ function qf_wiggle_push done } +function qf_resolved +{ + quilt refresh + quilt header -e +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 15/30 qf: Move "apply" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function, with the arguments now shifted.
--- qf | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-)
qf +13 -11
@@ -170,17 +170,6 @@ function quilt_clean_check } case "$1" in - apply) - if [[ "$2" == "" ]] ; then - echo No patch name given, aborting. - exit - fi - patch_name=$2.patch - quilt import -P $patch_name /proc/self/fd/0 - quilt push - qf git add $patch_name - qf patch-amend - ;; patch-amend|pa) cd_toplevel repo_check 1
@@ -496,6 +485,19 @@ function qf_resolved quilt header -e } +function qf_apply +{ + if [[ "$1" == "" ]] ; then + echo No patch name given, aborting. + exit + fi + patch_name=$1.patch + quilt import -P $patch_name /proc/self/fd/0 + quilt push + qf git add $patch_name + qf patch-amend +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 16/30 qf: Move "patch-amend" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function.
--- qf | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
qf +9 -6
@@ -170,12 +170,6 @@ function quilt_clean_check } case "$1" in - patch-amend|pa) - cd_toplevel - repo_check 1 - - gvim `quilt top` - ;; list-unused-patches) cd_toplevel repo_check 1
@@ -498,6 +492,15 @@ function qf_apply qf patch-amend } +qf_alias_pa=patch_amend +function qf_patch_amend +{ + cd_toplevel + repo_check 1 + + gvim `quilt top` +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 17/30 qf: Move "list-unused-patches" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function, with the arguments now shifted.
--- qf | 32 +++++++++++++++++--------------- 1 file changed, 17 insertions(+), 15 deletions(-)
qf +17 -15
@@ -170,21 +170,6 @@ function quilt_clean_check } case "$1" in - list-unused-patches) - cd_toplevel - repo_check 1 - - for patch in patches/*.patch ; do - if ! grep "^${patch#patches/}$" patches/series > /dev/null ; then - if [[ "$2" != --purge ]] ; then - echo $patch - else - echo deleting $patch - rm $patch - fi - fi - done - ;; baseline) cd_toplevel repo_check 1
@@ -501,6 +486,23 @@ function qf_patch_amend gvim `quilt top` } +function qf_list_unused_patches +{ + cd_toplevel + repo_check 1 + + for patch in patches/*.patch ; do + if ! grep "^${patch#patches/}$" patches/series > /dev/null ; then + if [[ "$1" != --purge ]] ; then + echo $patch + else + echo deleting $patch + rm $patch + fi + fi + done +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 18/30 qf: Move "baseline" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function.
--- qf | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
qf +8 -6
@@ -170,12 +170,6 @@ function quilt_clean_check } case "$1" in - baseline) - cd_toplevel - repo_check 1 - - echo $baseline - ;; git|g) cd_toplevel cd patches
@@ -503,6 +497,14 @@ function qf_list_unused_patches done } +function qf_baseline +{ + cd_toplevel + repo_check 1 + + echo $baseline +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 19/30 qf: Move "git" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function.
Notice that "shift" is not needed anymore since it is getting shifted by default for all subcommands.
--- qf | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-)
qf +8 -6
@@ -170,12 +170,6 @@ function quilt_clean_check } case "$1" in - git|g) - cd_toplevel - cd patches - shift - git "$@" - ;; gitk|k) cd_toplevel cd patches
@@ -505,6 +499,14 @@ function qf_baseline echo $baseline } +qf_alias_g=git +function qf_git +{ + cd_toplevel + cd patches + git "$@" +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 20/30 qf: Move "gitk" from case to new subcommand.
In reply to Rodrigo ViviNo functional change. Only moving from the case to its own function, with the arguments now shifted.
Notice that "shift" is not needed anymore since it is getting shifted by default for all subcommands.
Also this is the last command to move from the case block to its own function. So case block is not entirely removed.
--- qf | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)
qf +8 -9
@@ -169,15 +169,6 @@ function quilt_clean_check fi } -case "$1" in - gitk|k) - cd_toplevel - cd patches - shift - gitk "$@" - ;; -esac - qf=$(basename $0) # first positional argument is the subcommand
@@ -507,6 +498,14 @@ function qf_git git "$@" } +qf_alias_k=gitk +function qf_gitk +{ + cd_toplevel + cd patches + gitk "$@" +} + function qf_help { manpage=$DIM_PREFIX/maintainer-tools/qf.rst
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 21/30 qf: SC2006 - Fix one of shellcheck complains on qf.
In reply to Rodrigo Vivi^-- SC2006: Use $(..) instead of legacy ...
--- qf | 60 ++++++++++++++++++++++++++++++------------------------------ 1 file changed, 30 insertions(+), 30 deletions(-)
qf +30 -30
@@ -34,19 +34,19 @@ set -e function cd_toplevel { - cd `git rev-parse --show-toplevel` + cd $(git rev-parse --show-toplevel) if [ -f series ] ; then cd .. - if [[ $PWD != `git rev-parse --show-toplevel` ]] ; then + if [[ $PWD != $(git rev-parse --show-toplevel) ]] ; then echo No git repo in parent directory of series file exit 1 fi fi if [[ -f patches/series ]] ; then - if [[ $PWD/patches != `cd patches ; git rev-parse --show-toplevel` ]] ; then + if [[ $PWD/patches != $(cd patches ; git rev-parse --show-toplevel) ]] ; then echo No git repo found in quilt series directory exit 2 fi
@@ -65,7 +65,7 @@ function quiet_pop_all function repo_check # allow-detached { cd patches - quilt_branch=`git rev-parse --abbrev-ref HEAD` + quilt_branch=$(git rev-parse --abbrev-ref HEAD) branch=${quilt_branch#$QUILT_PREFIX} if [[ ! $1 ]] ; then
@@ -84,9 +84,9 @@ function repo_check # allow-detached cd .. fi - baseline=`source patches/config ; echo $BASELINE` + baseline=$(source patches/config ; echo $BASELINE) - if [[ `git rev-parse HEAD` != $baseline ]] ; then + if [[ $(git rev-parse HEAD) != $baseline ]] ; then echo Baseline commit doesn\'t match with quilt config exit 7 fi
@@ -154,14 +154,14 @@ function branch_init function quilt_clean_check { - local current_top=`quilt top` + local current_top=$(quilt top) - if [[ -n `quilt unapplied $current_top` ]] ; then + if [[ -n $(quilt unapplied $current_top) ]] ; then echo Unapplied quilt patches, aborting. exit 9 fi - local quilt_changes=`cd patches ; git status --porcelain` + local quilt_changes=$(cd patches ; git status --porcelain) if [[ -n $quilt_changes ]] ; then echo Uncommitted changes in the quilt patch repo, aborting.
@@ -181,7 +181,7 @@ fi function qf_setup { - cd `git rev-parse --show-toplevel` + cd $(git rev-parse --show-toplevel) if [[ -d patches ]] ; then if [[ ! -d patches/.git ]] ; then
@@ -203,8 +203,8 @@ function qf_setup branch=$1 quilt_branch=$QUILT_PREFIX$branch - baseline=`git rev-parse $1` - remote=`git config branch.$branch.remote` + baseline=$(git rev-parse $1) + remote=$(git config branch.$branch.remote) branch_init $2 fi
@@ -229,10 +229,10 @@ function qf_checkout cd .. # error code 2 means no patches removed, which is ok quiet_pop_all -f - baseline=`source patches/config ; echo $BASELINE` + baseline=$(source patches/config ; echo $BASELINE) checkout_baseline quilt push -a -q > /dev/null - echo Now at `quilt top` + echo Now at $(quilt top) } function qf_rebase
@@ -245,9 +245,9 @@ function qf_rebase exit 4 fi - new_baseline=`git rev-parse $1` + new_baseline=$(git rev-parse $1) - current_top=`quilt top` + current_top=$(quilt top) quiet_pop_all echo Resetting baseline to $new_baseline git reset --hard $new_baseline
@@ -262,7 +262,7 @@ function qf_refresh cd_toplevel repo_check 0 - changed_files=`qf git status --porcelain | wc -l` + changed_files=$(qf git status --porcelain | wc -l) if [[ $changed_files -gt 0 ]] ; then echo Quilt patch dir not clean, aborting
@@ -300,10 +300,10 @@ function qf_export quilt_clean_check username=$GIT_COMMMITTER_NAME - username=${username:-`git config user.name || true`} - username=${username:-`getent passwd $USER | cut -d: -f 5 | cut -d, -f 1 || true`} + username=${username:-$(git config user.name || true)} + username=${username:-$(getent passwd $USER | cut -d: -f 5 | cut -d, -f 1 || true)} useremail=$GIT_COMMMITTER_EMAIL - useremail=${useremail:-`git config user.email || true`} + useremail=${useremail:-$(git config user.email || true)} useremail=${useremail:-$EMAIL} if [[ -z $useremail || -z $username ]] ; then
@@ -324,11 +324,11 @@ function qf_export git quiltimport --author "$username <$useremail>" - quilt_ref=`cd patches ; git rev-parse --abbrev-ref HEAD` - quilt_sha_abbrev=`cd patches ; git rev-parse --short HEAD` - quilt_sha=`cd patches ; git rev-parse HEAD` + quilt_ref=$(cd patches ; git rev-parse --abbrev-ref HEAD) + quilt_sha_abbrev=$(cd patches ; git rev-parse --short HEAD) + quilt_sha=$(cd patches ; git rev-parse HEAD) - git update-ref -m "export $quilt_ref:$quilt_sha_abbrev to $branch" refs/QUILT_EXPORT `git rev-parse HEAD` + git update-ref -m "export $quilt_ref:$quilt_sha_abbrev to $branch" refs/QUILT_EXPORT $(git rev-parse HEAD) git notes --ref quilt add -m "Quilt-Commit: $quilt_sha" $branch checkout_baseline
@@ -351,10 +351,10 @@ function qf_push repo_check 0 quilt_clean_check - remote=`git config branch.$branch.remote` + remote=$(git config branch.$branch.remote) - export_quilt_sha=`git notes --ref=quilt show $branch | grep Quilt-Commit | cut -d ' ' -f 2` - quilt_sha=`cd patches ; git rev-parse $quilt_branch` + export_quilt_sha=$(git notes --ref=quilt show $branch | grep Quilt-Commit | cut -d ' ' -f 2) + quilt_sha=$(cd patches ; git rev-parse $quilt_branch) if [[ $export_quilt_sha != $quilt_sha ]] ; then echo Quilt export is out of date, aborting
@@ -379,7 +379,7 @@ function qf_fetch cd_toplevel repo_check 0 - remote=`git config branch.$branch.remote` + remote=$(git config branch.$branch.remote) cd patches git fetch $remote
@@ -423,7 +423,7 @@ function qf_wiggle_push cd_toplevel repo_check 1 - conflict_files=`quilt push -f | grep "saving rejects" | sed -e "s/.*saving rejects to file \(.*\)/\1/"` + conflict_files=$(quilt push -f | grep "saving rejects" | sed -e "s/.*saving rejects to file \(.*\)/\1/") if [[ $conflict_files != "" ]] ; then echo conflicts found!
@@ -462,7 +462,7 @@ function qf_patch_amend cd_toplevel repo_check 1 - gvim `quilt top` + gvim $(quilt top) } function qf_list_unused_patches
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 22/30 qf: SC2068 - Fix another shellcheck complain.
In reply to Rodrigo Vivi^-- SC2068: Double quote array expansions to avoid re-splitting elements.
--- qf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
qf +1 -1
@@ -59,7 +59,7 @@ function cd_toplevel function quiet_pop_all { echo Popping patches ... - quilt pop -a -q $@ > /dev/null || test $? = 2 + quilt pop -a -q "$@" > /dev/null || test $? = 2 } function repo_check # allow-detached
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 23/30 qf: SC2053 - Fix another shellcheck complain:
In reply to Rodrigo Vivi^-- SC2053: Quote the rhs of != in [[ ]] to prevent glob matching.
--- qf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
qf +2 -2
@@ -86,7 +86,7 @@ function repo_check # allow-detached baseline=$(source patches/config ; echo $BASELINE) - if [[ $(git rev-parse HEAD) != $baseline ]] ; then + if [[ $(git rev-parse HEAD) != "$baseline" ]] ; then echo Baseline commit doesn\'t match with quilt config exit 7 fi
@@ -356,7 +356,7 @@ function qf_push export_quilt_sha=$(git notes --ref=quilt show $branch | grep Quilt-Commit | cut -d ' ' -f 2) quilt_sha=$(cd patches ; git rev-parse $quilt_branch) - if [[ $export_quilt_sha != $quilt_sha ]] ; then + if [[ $export_quilt_sha != "$quilt_sha" ]] ; then echo Quilt export is out of date, aborting echo $export_quilt_sha echo $quilt_sha
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 24/30 qf: SC2155 - Fix another shellcheck complain
In reply to Rodrigo Vivi^-- SC2155: Declare and assign separately to avoid masking return values.
--- qf | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
qf +4 -2
@@ -154,14 +154,16 @@ function branch_init function quilt_clean_check { - local current_top=$(quilt top) + local current_top quilt_changes + + current_top=$(quilt top) if [[ -n $(quilt unapplied $current_top) ]] ; then echo Unapplied quilt patches, aborting. exit 9 fi - local quilt_changes=$(cd patches ; git status --porcelain) + quilt_changes=$(cd patches ; git status --porcelain) if [[ -n $quilt_changes ]] ; then echo Uncommitted changes in the quilt patch repo, aborting.
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 25/30 qf: SC2035 - Fix another shellcheck complain
In reply to Rodrigo Vivi^-- SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options.
--- qf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
qf +1 -1
@@ -135,7 +135,7 @@ function branch_init echo Creating new quilt branch $quilt_branch # big trickery to get an empty commit git checkout -q --orphan $quilt_branch > /dev/null - git rm -rf * > /dev/null + git rm -rf ./* > /dev/null git ls-files | xargs git rm -rf > /dev/null touch series echo BASELINE=$baseline > config
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 26/30 qf: SC1091 - Fix another shellcheck complain
In reply to Rodrigo Vivi^-- SC1091: Not following: patches/config was not specified as input (see shellcheck -x).
It is expected this path doesn't exist yet.
--- qf | 2 ++ 1 file changed, 2 insertions(+)
qf +2 -0
@@ -84,6 +84,7 @@ function repo_check # allow-detached cd .. fi + # shellcheck source=/dev/null baseline=$(source patches/config ; echo $BASELINE) if [[ $(git rev-parse HEAD) != "$baseline" ]] ; then
@@ -231,6 +232,7 @@ function qf_checkout cd .. # error code 2 means no patches removed, which is ok quiet_pop_all -f + # shellcheck source=/dev/null baseline=$(source patches/config ; echo $BASELINE) checkout_baseline quilt push -a -q > /dev/null
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 27/30 qf: SC2153 - Fix another shellcheck complain.
In reply to Rodrigo Vivi^-- SC2153: Possible misspelling: BASELINE may not be assigned, but baseline is.
BASELINE is defined inside patches/config, but this confuses shellcheck. According to https://github.com/koalaman/shellcheck/wiki/SC2153
the message doesn't appear for guarded references where if variable is defined a default is used.
Maybe we should pick a better default like the git HEAD ?!
--- qf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
qf +2 -2
@@ -85,7 +85,7 @@ function repo_check # allow-detached fi # shellcheck source=/dev/null - baseline=$(source patches/config ; echo $BASELINE) + baseline=$(source patches/config ; echo ${BASELINE:-}) if [[ $(git rev-parse HEAD) != "$baseline" ]] ; then echo Baseline commit doesn\'t match with quilt config
@@ -233,7 +233,7 @@ function qf_checkout # error code 2 means no patches removed, which is ok quiet_pop_all -f # shellcheck source=/dev/null - baseline=$(source patches/config ; echo $BASELINE) + baseline=$(source patches/config ; echo ${BASELINE:-}) checkout_baseline quilt push -a -q > /dev/null echo Now at $(quilt top)
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 28/30 qf: SC1083 - Fix another shellcheck complain.
In reply to Rodrigo Vivi^-- SC1083: This { is literal. Check expression (missing ;/\n?) or quote it.^
--- qf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
qf +2 -2
@@ -403,9 +403,9 @@ function qf_pull cd patches if [[ $1 == "--rebase" ]] ; then - git rebase @{upstream} + git rebase "@{upstream}" else - git merge @{upstream} + git merge "@{upstream}" fi qf co
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 29/30 qf: Add it to shellcheck part of make check.
In reply to Rodrigo ViviNow that all of our issues caught by shellcheck are fixed let's add qf to shellcheck part of make check so any further change is protected by this cool shell scan tool.
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
@@ -43,7 +43,7 @@ SC_EXCLUDE := \ -e SC2143 shellcheck: - shellcheck $(SC_EXCLUDE) dim bash_completion + shellcheck $(SC_EXCLUDE) dim bash_completion qf mancheck: @for cmd in $$(./dim list-commands); do \
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 30/30 qf: Use .dimrc to config and extend qf.
In reply to Rodrigo ViviSoon we will need to extend qf for very specific usages of our internal maintenance and rebase bot.
So instead of creating yet another config file let's use the existent one.
--- dimrc.sample | 9 ++++++++- qf | 18 +++++++++++++++--- 2 files changed, 23 insertions(+), 4 deletions(-)
dimrc.sample +8 -1
@@ -1,4 +1,4 @@ -# Sample configuration file for dim. Place this at $HOME/.dimrc or point +# Sample configuration file for dim and qf. Place this at $HOME/.dimrc or point # DIM_CONFIG environment variable to it. # # Defaults are in the comments below.
@@ -20,3 +20,10 @@ # Command to run after dim apply #DIM_POST_APPLY_ACTION= + +# +# qf +# + +# Quilt branch prefix +#QUILT_PREFIX=
qf +15 -3
@@ -26,12 +26,24 @@ # quilt git flow script -# config -QUILT_PREFIX=quilt/ - # fail on any goof-up set -e +# +# User configuration. Set in environment or configuration file. See +# dimrc.sample for an example. +# + +# dim configuration file +DIM_CONFIG=${DIM_CONFIG:-$HOME/.dimrc} +if [ -r $DIM_CONFIG ]; then + # shellcheck source=/dev/null + . $DIM_CONFIG +fi + +# prefix for quilt branch +QUILT_PREFIX=${QUILT_PREFIX:-quilt/} + function cd_toplevel { cd $(git rev-parse --show-toplevel)
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [maintainer-tools PATCH 30/30] qf: Use .dimrc to config and extend qf.
Quoted 10 lines · Rodrigo Vivi
Soon we will need to extend qf for very specific usages of our internal maintenance and rebase bot.
So instead of creating yet another config file let's use the existent one.
Cc Daniel Vetter <[email protected]>Cc Jani Nikula <[email protected]>Cc Joonas Lahtinen <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>
Now that qf list-aliases/cmds works, can we perhaps also rework the bash completion to use that, like for dim?
-Daniel
Quoted 66 lines
--- dimrc.sample | 9 ++++++++- qf | 18 +++++++++++++++--- 2 files changed, 23 insertions(+), 4 deletions(-)dimrc.sample +8
-1@@ -1,4 +1,4 @@ -# Sample configuration file for dim. Place this at $HOME/.dimrc or point +# Sample configuration file for dim and qf. Place this at $HOME/.dimrc or point # DIM_CONFIG environment variable to it. # # Defaults are in the comments below.@@ -20,3 +20,10 @@ # Command to run after dim apply #DIM_POST_APPLY_ACTION= + +# +# qf +# + +# Quilt branch prefix +#QUILT_PREFIX=qf +15
-3@@ -26,12 +26,24 @@ # quilt git flow script -# config -QUILT_PREFIX=quilt/ - # fail on any goof-up set -e +# +# User configuration. Set in environment or configuration file. See +# dimrc.sample for an example. +# + +# dim configuration file +DIM_CONFIG=${DIM_CONFIG:-$HOME/.dimrc} +if [ -r $DIM_CONFIG ]; then + # shellcheck source=/dev/null + . $DIM_CONFIG +fi + +# prefix for quilt branch +QUILT_PREFIX=${QUILT_PREFIX:-quilt/} + function cd_toplevel { cd $(git rev-parse --show-toplevel)Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [maintainer-tools PATCH 30/30] qf: Use .dimrc to config and extend qf.
Quoted 7 lines · Daniel Vetter
Quoted 6 lines · Rodrigo Vivi
Soon we will need to extend qf for very specific usages of our internal maintenance and rebase bot.
So instead of creating yet another config file let's use the existent one.
Quoted 7 lines
Quoted 4 lines
Cc Daniel Vetter <[email protected]>Cc Jani Nikula <[email protected]>Cc Joonas Lahtinen <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>Now that qf list-aliases/cmds works, can we perhaps also rework the bash completion to use that, like for dim?
Another follow-up task would be to extract the qf help into qf.rst and add it to the sphinx build. For even more qf/dim consistency. -Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [maintainer-tools PATCH 30/30] qf: Use .dimrc to config and extend qf.
Quoted 13 lines · Daniel Vetter
Quoted 12 lines · Daniel Vetter
Quoted 10 lines · Rodrigo Vivi
Soon we will need to extend qf for very specific usages of our internal maintenance and rebase bot.
So instead of creating yet another config file let's use the existent one.
Cc Daniel Vetter <[email protected]>Cc Jani Nikula <[email protected]>Cc Joonas Lahtinen <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>
Quoted 5 lines
Quoted 2 lines
Now that qf list-aliases/cmds works, can we perhaps also rework the bash completion to use that, like for dim?
Another follow-up task would be to extract the qf help into
qf.rstand add it to the sphinx build. For even more qf/dim consistency.
That's already done and pushed.
BR,
Jani.
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [maintainer-tools PATCH 30/30] qf: Use .dimrc to config and extend qf.
In reply to Rodrigo ViviQuoted 5 lines · Rodrigo Vivi
Soon we will need to extend qf for very specific usages of our internal maintenance and rebase bot.
So instead of creating yet another config file let's use the existent one.
I think I'd prefer a separate config file for qf.
BR,
Jani.
Quoted 64 lines
Cc Daniel Vetter <[email protected]>Cc Jani Nikula <[email protected]>Cc Joonas Lahtinen <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- dimrc.sample | 9 ++++++++- qf | 18 +++++++++++++++--- 2 files changed, 23 insertions(+), 4 deletions(-)dimrc.sample +8
-1@@ -1,4 +1,4 @@ -# Sample configuration file for dim. Place this at $HOME/.dimrc or point +# Sample configuration file for dim and qf. Place this at $HOME/.dimrc or point # DIM_CONFIG environment variable to it. # # Defaults are in the comments below.@@ -20,3 +20,10 @@ # Command to run after dim apply #DIM_POST_APPLY_ACTION= + +# +# qf +# + +# Quilt branch prefix +#QUILT_PREFIX=qf +15
-3@@ -26,12 +26,24 @@ # quilt git flow script -# config -QUILT_PREFIX=quilt/ - # fail on any goof-up set -e +# +# User configuration. Set in environment or configuration file. See +# dimrc.sample for an example. +# + +# dim configuration file +DIM_CONFIG=${DIM_CONFIG:-$HOME/.dimrc} +if [ -r $DIM_CONFIG ]; then + # shellcheck source=/dev/null + . $DIM_CONFIG +fi + +# prefix for quilt branch +QUILT_PREFIX=${QUILT_PREFIX:-quilt/} + function cd_toplevel { cd $(git rev-parse --show-toplevel)
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [maintainer-tools PATCH 30/30] qf: Use .dimrc to config and extend qf.
Quoted 8 lines · Jani Nikula
Quoted 5 lines · Rodrigo Vivi
Soon we will need to extend qf for very specific usages of our internal maintenance and rebase bot.
So instead of creating yet another config file let's use the existent one.
I think I'd prefer a separate config file for qf.
hm.. I was here accepting this suggestion, but then I noticed our qf_help already referrence $DIM_PREFIX
so, if we change to .qfrc we will have to redefine this prefix while re-using dimrc we don't need any duplication.
what do you think?
Quoted 75 lines
BR,
Jani.Quoted 54 lines
Cc Daniel Vetter <[email protected]>Cc Jani Nikula <[email protected]>Cc Joonas Lahtinen <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- dimrc.sample | 9 ++++++++- qf | 18 +++++++++++++++--- 2 files changed, 23 insertions(+), 4 deletions(-)dimrc.sample +8
-1@@ -1,4 +1,4 @@ -# Sample configuration file for dim. Place this at $HOME/.dimrc or point +# Sample configuration file for dim and qf. Place this at $HOME/.dimrc or point # DIM_CONFIG environment variable to it. # # Defaults are in the comments below.@@ -20,3 +20,10 @@ # Command to run after dim apply #DIM_POST_APPLY_ACTION= + +# +# qf +# + +# Quilt branch prefix +#QUILT_PREFIX=qf +8
-3@@ -26,12 +26,24 @@ # quilt git flow script -# config -QUILT_PREFIX=quilt/ - # fail on any goof-up set -e +# +# User configuration. Set in environment or configuration file. See +# dimrc.sample for an example. +# + +# dim configuration file +DIM_CONFIG=${DIM_CONFIG:-$HOME/.dimrc} +if [ -r $DIM_CONFIG ]; thenqf line 49
Quoted 10 lines
qf +7
-0+ # shellcheck source=/dev/null + . $DIM_CONFIG +fi + +# prefix for quilt branch +QUILT_PREFIX=${QUILT_PREFIX:-quilt/} + function cd_toplevel { cd $(git rev-parse --show-toplevel)--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [maintainer-tools PATCH 30/30] qf: Use .dimrc to config and extend qf.
Quoted 10 lines · Rodrigo Vivi
Quoted 8 lines · Jani Nikula
Quoted 5 lines · Rodrigo Vivi
Soon we will need to extend qf for very specific usages of our internal maintenance and rebase bot.
So instead of creating yet another config file let's use the existent one.
I think I'd prefer a separate config file for qf.
Quoted 7 lines
hm.. I was here accepting this suggestion, but then I noticed our
qf_helpalready referrence $DIM_PREFIXso, if we change to .qfrc we will have to redefine this prefix while re-using dimrc we don't need any duplication.
what do you think?
I think encouraging people to have entirely separate public/internal trees would be good. Maybe even add a warning if QF_PREFIX matches DIM_PREFIX.
The risk is that the rerere magic in dim could accidentally leak internal stuff.
So +1 from me for going with .qfrc, and maybe for paranoia on top insist that QF_PREFIX != DIM_PREFIX. I'm one of those idiots who does this wrong, and it's not good :-)
Cheers, Daniel
Quoted 82 lines
Quoted 76 lines
BR,
Jani.Quoted 54 lines
Cc Daniel Vetter <[email protected]>Cc Jani Nikula <[email protected]>Cc Joonas Lahtinen <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- dimrc.sample | 9 ++++++++- qf | 18 +++++++++++++++--- 2 files changed, 23 insertions(+), 4 deletions(-)dimrc.sample +8
-1@@ -1,4 +1,4 @@ -# Sample configuration file for dim. Place this at $HOME/.dimrc or point +# Sample configuration file for dim and qf. Place this at $HOME/.dimrc or point # DIM_CONFIG environment variable to it. # # Defaults are in the comments below.@@ -20,3 +20,10 @@ # Command to run after dim apply #DIM_POST_APPLY_ACTION= + +# +# qf +# + +# Quilt branch prefix +#QUILT_PREFIX=qf +8
-3@@ -26,12 +26,24 @@ # quilt git flow script -# config -QUILT_PREFIX=quilt/ - # fail on any goof-up set -e +# +# User configuration. Set in environment or configuration file. See +# dimrc.sample for an example. +# + +# dim configuration file +DIM_CONFIG=${DIM_CONFIG:-$HOME/.dimrc} +if [ -r $DIM_CONFIG ]; thenqf line 49
Quoted 10 lines
qf +7
-0+ # shellcheck source=/dev/null + . $DIM_CONFIG +fi + +# prefix for quilt branch +QUILT_PREFIX=${QUILT_PREFIX:-quilt/} + function cd_toplevel { cd $(git rev-parse --show-toplevel)--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 2 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/1 qf: Introduce .qfrc.
Soon we will need to extend qf for very specific usages of our internal maintenance and rebase bot.
So let's start with the only environment configuration we have but also let's allow qfrc to extend qf commands and aliases.
--- qf | 18 +++++++++++++++--- qf.rst | 25 +++++++++++++++++++++++++ qfrc.sample | 7 +++++++ 3 files changed, 47 insertions(+), 3 deletions(-) create mode 100644 qfrc.sample
qf +15 -3
@@ -26,12 +26,24 @@ # quilt git flow script -# config -QUILT_PREFIX=quilt/ - # fail on any goof-up set -e +# +# User configuration. Set in environment or configuration file. See +# qfrc.sample for an example. +# + +# qf configuration file +QF_CONFIG=${QF_CONFIG:-$HOME/.qfrc} +if [ -r $QF_CONFIG ]; then + # shellcheck source=/dev/null + . $QF_CONFIG +fi + +# prefix for quilt branch +QUILT_PREFIX=${QUILT_PREFIX:-quilt/} + function cd_toplevel { cd $(git rev-parse --show-toplevel)
qf.rst +25 -0
@@ -254,6 +254,31 @@ directory as git commands. When using quilt flow in scripts it is import to use the explicit forwarding to avoid clashes with furture extensions. + +ALIASES +======= + +Extending **qf** functionalities +--------------------------------- + +It is possible to create your own qf helper and aliases by adding them to \$HOME/.qfrc:: + + qf_my_fancy_list_aliases() + { + echo "Hello world!" + qf_list_aliases + } + + qf_alias_list_aliases=my-fancy-list-aliases + +ENVIRONMENT +=========== + +QUILT_PREFIX +------------ +Quilt branch prefix. This is a prefix for the git branch that contains the +patch files and quilt series file. + CONTRIBUTING ============
qfrc.sample new file +7 -0
@@ -0,0 +1,7 @@ +# Sample configuration file for qf. Place this at $HOME/.qfrc or point +# QF_CONFIG environment variable to it. +# +# Defaults are in the comments below. + +# Quilt branch prefix +#QUILT_PREFIX=quilt
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [maintainer-tools PATCH] qf: Introduce .qfrc.
Quoted 92 lines · Rodrigo Vivi
Soon we will need to extend qf for very specific usages of our internal maintenance and rebase bot.
So let's start with the only environment configuration we have but also let's allow qfrc to extend qf commands and aliases.
Cc Daniel Vetter <[email protected]>Cc Jani Nikula <[email protected]>Cc Joonas Lahtinen <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- qf | 18 +++++++++++++++--- qf.rst | 25 +++++++++++++++++++++++++ qfrc.sample | 7 +++++++ 3 files changed, 47 insertions(+), 3 deletions(-) create mode 100644 qfrc.sampleqf +15
-3@@ -26,12 +26,24 @@ # quilt git flow script -# config -QUILT_PREFIX=quilt/ - # fail on any goof-up set -e +# +# User configuration. Set in environment or configuration file. See +# qfrc.sample for an example. +# + +# qf configuration file +QF_CONFIG=${QF_CONFIG:-$HOME/.qfrc} +if [ -r $QF_CONFIG ]; then + # shellcheck source=/dev/null + . $QF_CONFIG +fi + +# prefix for quilt branch +QUILT_PREFIX=${QUILT_PREFIX:-quilt/} + function cd_toplevel { cd $(git rev-parse --show-toplevel)qf.rst +25
-0@@ -254,6 +254,31 @@ directory as git commands. When using quilt flow in scripts it is import to use the explicit forwarding to avoid clashes with furture extensions. + +ALIASES +======= + +Extending **qf** functionalities +--------------------------------- + +It is possible to create your own qf helper and aliases by adding them to \$HOME/.qfrc:: + + qf_my_fancy_list_aliases() + { + echo "Hello world!" + qf_list_aliases + } + + qf_alias_list_aliases=my-fancy-list-aliases + +ENVIRONMENT +=========== + +QUILT_PREFIX +------------ +Quilt branch prefix. This is a prefix for the git branch that contains the +patch files and quilt series file. + CONTRIBUTING ============qfrc.sample new file +0
-0
qfrc.sample line 7
Quoted 7 lines
qfrc.sample new file +7
-0@@ -0,0 +1,7 @@ +# Sample configuration file for qf. Place this at $HOME/.qfrc or point +# QF_CONFIG environment variable to it. +# +# Defaults are in the comments below. + +# Quilt branch prefix +#QUILT_PREFIX=quilt
Misses the / at the end. Otherwise lgtm, ack.
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Rodrigo Vivi
These sequences here are already covered by
qf gitsubcommand. I double checked and confirmed that our continuously rebasing bot does not use this qf directly here and I'm not aware of anyone else using it. So let's remove it so we can start handling everything with subcommands (dim style).
I do. It's super handy if you look around at the source code, but want to manipulate the qf history. This is similar to how git tools by default work anywhere in the working tree. It's not perfect (e.g. qf git blame doesn't do what you want it to do), but in many cases just adding a qf to whatever git command you though of Just Works (e.g. qf log).
If it annoys you too much I guess we could do qf run for cmds in general and qf git for git stuff, but would be really nice to keep this in some form.
-Daniel
Quoted 51 lines
Cc Paulo Zanoni <[email protected]>Cc Imre Deak <[email protected]>Cc Joonas Lahtinen <[email protected]>Cc Jani Nikula <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- qf | 7 +------ qf.rst | 7 ------- 2 files changed, 1 insertion(+), 13 deletions(-)qf +1
-6@@ -480,12 +480,7 @@ case "$1" in shift gitk "$@" ;; - help) - qf_help - ;; *) - cd_toplevel - cd patches - git "$@" + qf_help ;; esacqf.rst +0
-7@@ -233,13 +233,6 @@ help ---- This help text here -all other subcommands - IMPORTANT ---------------------------------- -Any other subcommands are executed directly in the quilt patches -directory as git commans. When using quilt flow in scripts it is -import to use the explicit forwarding to avoid clashes with -furture extensions. - CONTRIBUTING ============Signature · 1 line
2.13.2
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 13 lines · Daniel Vetter
Quoted 5 lines · Rodrigo Vivi
These sequences here are already covered by
qf gitsubcommand. I double checked and confirmed that our continuously rebasing bot does not use this qf directly here and I'm not aware of anyone else using it. So let's remove it so we can start handling everything with subcommands (dim style).I do. It's super handy if you look around at the source code, but want to manipulate the qf history. This is similar to how git tools by default work anywhere in the working tree. It's not perfect (e.g. qf git blame doesn't do what you want it to do), but in many cases just adding a qf to whatever git command you though of Just Works (e.g. qf log).
Quoted 3 lines
If it annoys you too much I guess we could do qf run for cmds in general and qf git for git stuff, but would be really nice to keep this in some form.
Otoh my opinion doesn't matter all that much anymore, so if others think it's ok I can live with qf git log :-)
Ack on the series, but I haven't really checked all the details, I think Jani's the better person for that.
-Daniel
Quoted 58 lines
-Daniel
Quoted 51 lines
Cc Paulo Zanoni <[email protected]>Cc Imre Deak <[email protected]>Cc Joonas Lahtinen <[email protected]>Cc Jani Nikula <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- qf | 7 +------ qf.rst | 7 ------- 2 files changed, 1 insertion(+), 13 deletions(-)qf +1
-6@@ -480,12 +480,7 @@ case "$1" in shift gitk "$@" ;; - help) - qf_help - ;; *) - cd_toplevel - cd patches - git "$@" + qf_help ;; esacqf.rst +0
-7@@ -233,13 +233,6 @@ help ---- This help text here -all other subcommands - IMPORTANT ---------------------------------- -Any other subcommands are executed directly in the quilt patches -directory as git commans. When using quilt flow in scripts it is -import to use the explicit forwarding to avoid clashes with -furture extensions. - CONTRIBUTING ============Signature · 1 line
2.13.2Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 14 lines · Daniel Vetter
Quoted 13 lines · Daniel Vetter
Quoted 5 lines · Rodrigo Vivi
These sequences here are already covered by
qf gitsubcommand. I double checked and confirmed that our continuously rebasing bot does not use this qf directly here and I'm not aware of anyone else using it. So let's remove it so we can start handling everything with subcommands (dim style).I do. It's super handy if you look around at the source code, but want to manipulate the qf history. This is similar to how git tools by default work anywhere in the working tree. It's not perfect (e.g. qf git blame doesn't do what you want it to do), but in many cases just adding a qf to whatever git command you though of Just Works (e.g. qf log).
Quoted 3 lines
Quoted 3 lines
If it annoys you too much I guess we could do qf run for cmds in general and qf git for git stuff, but would be really nice to keep this in some form.
it doesn't annoy me...
I just considered it to be more in sync with dim, but if we have users for that I don't want to break it ;)
Quoted 2 lines
Otoh my opinion doesn't matter all that much anymore, so if others think
of course it matters!
Quoted 1 line
it's ok I can live with qf git log :-)
well, if was/is just the log I believe we could do an alias on .qfrc..
But I imagine qfrc can increase a lot and get messy if we start adding all git subcommands to our .qfrc
Quoted 3 lines
Ack on the series, but I haven't really checked all the details, I think Jani's the better person for that.
Thanks!
But I will still do few changes like keep this default behaviour and use .qfrc instead of .dimrc as Jani prefers.
Later I will play with bash_completion for qf as well... Thanks for the suggestion.
Thanks,
Rodrigo.
Quoted 69 lines
-Daniel
Quoted 50 lines
-Daniel
Quoted 48 lines
Cc Paulo Zanoni <[email protected]>Cc Imre Deak <[email protected]>Cc Joonas Lahtinen <[email protected]>Cc Jani Nikula <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- qf | 7 +------ qf.rst | 7 ------- 2 files changed, 1 insertion(+), 13 deletions(-)qf +1
-6@@ -480,12 +480,7 @@ case "$1" in shift gitk "$@" ;; - help) - qf_help - ;; *) - cd_toplevel - cd patches - git "$@" + qf_help ;; esacqf.rst +0
-7@@ -233,13 +233,6 @@ help ---- This help text here -all other subcommands - IMPORTANT ---------------------------------- -Any other subcommands are executed directly in the quilt patches -directory as git commans. When using quilt flow in scripts it is -import to use the explicit forwarding to avoid clashes with -furture extensions. - CONTRIBUTING ============Quoted 8 lines
Quoted 3 lines
--
2.13.2--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Rodrigo Vivi Blog: http://blog.vivi.eng.br _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 1/1 qf: Introduce subcommand and aliases
In reply to Daniel VetterLet's start refreshing qf a bit by introducing subcommand and aliases like dim.
The goal is to have an standardized qf and dim where both have same style, documentation and also that is in a format that we can easily introduce to make check.
Actually all new code here is a simple copy from dim directly with s/dim/qf.
This patch also introduce qf_usage, qf_list_commands qf_list_aliases and already
move qf_help from the case parse $1 to a
subcommand.
v2: Keep default behaviour as git command executed on
quilt patches directory instead of qf_usage.
--- Makefile | 5 +++ qf | 109 +++++++++++++++++++++++++++++++++++++++++++++------------------ qf.rst | 16 +++++++++- 3 files changed, 99 insertions(+), 31 deletions(-)
Makefile +5 -0
@@ -51,6 +51,11 @@ mancheck: echo "$@: $$cmd not documented"; \ fi \ done + @for cmd in $$(./qf list-commands); do \ + if ! grep -q "^$$cmd" qf.rst; then \ + echo "$@: $$cmd not documented"; \ + fi \ + done rst2man --strict --no-raw dim.rst >/dev/null rst2man --strict --no-raw qf.rst >/dev/null
qf +79 -30
119 lines not on this page · raw message
qf.rst +15 -1
@@ -95,6 +95,16 @@ $ qf git bisect new|old COMMANDS ======== +list-aliases +------------ +List all aliases for the subcommand names. + +See \$qf_alias_<alias> under ENVIRONMENT below on how to define aliases. + +list-commands +------------- +List all subcommand names, including aliases. + setup [*branch-name*] --------------------- Sets up a git repository for this quilt worflow script by
@@ -233,10 +243,14 @@ help ---- This help text here +usage +----- +Short form usage help listing all subcommands. + all other subcommands - IMPORTANT --------------------------------- Any other subcommands are executed directly in the quilt patches -directory as git commans. When using quilt flow in scripts it is +directory as git commands. When using quilt flow in scripts it is import to use the explicit forwarding to avoid clashes with furture extensions.
Signature · 6 lines
2.13.2 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 5 lines · Rodrigo Vivi
These sequences here are already covered by
qf gitsubcommand. I double checked and confirmed that our continuously rebasing bot does not use this qf directly here and I'm not aware of anyone else using it. So let's remove it so we can start handling everything with subcommands (dim style).
Apart from the specific comments from me and Daniel, ack on the series. This is pretty much how I converted dim way back.
BR,
Jani.
Quoted 47 lines
Cc Paulo Zanoni <[email protected]>Cc Imre Deak <[email protected]>Cc Joonas Lahtinen <[email protected]>Cc Jani Nikula <[email protected]>Cc Daniel Vetter <[email protected]>Signed-off-by Rodrigo Vivi <[email protected]>--- qf | 7 +------ qf.rst | 7 ------- 2 files changed, 1 insertion(+), 13 deletions(-)qf +1
-6@@ -480,12 +480,7 @@ case "$1" in shift gitk "$@" ;; - help) - qf_help - ;; *) - cd_toplevel - cd patches - git "$@" + qf_help ;; esacqf.rst +0
-7@@ -233,13 +233,6 @@ help ---- This help text here -all other subcommands - IMPORTANT ---------------------------------- -Any other subcommands are executed directly in the quilt patches -directory as git commans. When using quilt flow in scripts it is -import to use the explicit forwarding to avoid clashes with -furture extensions. - CONTRIBUTING ============
Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx